From: Anusha Srivatsa <anusha.srivatsa@intel.com>
To: Manasi Navare <manasi.d.navare@intel.com>
Cc: dri-devel@lists.freedesktop.org, gfx-internal-devel@eclists.intel.com
Subject: Re: [PATCH v2 1/5] drm/dp: Add DP DSC DPCD receiver capability size define and missing SHIFT
Date: Mon, 8 Jan 2018 16:24:13 -0800 [thread overview]
Message-ID: <20180109002413.GA2694@intel.com> (raw)
In-Reply-To: <1515054200-11435-1-git-send-email-manasi.d.navare@intel.com>
On Thu, Jan 04, 2018 at 12:23:16AM -0800, Manasi Navare wrote:
> This patch defines the DP DSC receiver capability size that gives
> total number of DP DSC DPCD registers.
> This also adds a missing SHIFT define missed in the
> commit id (ab6a46ea6842ce "Add DPCD definitions for DP 1.4 DSC feature")
>
> v2:
> * Missed the SHIFT define that I mentioned in the message
>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: Ville Syrjala <ville.syrjala@linux.intel.com>
> Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: Manasi Navare <manasi.d.navare@intel.com>
Checked with the spec. Looks good to me.
Reviewed-by: Anusha Srivatsa <anushasrivatsa@intel.com>
> ---
> include/drm/drm_dp_helper.h | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
> index da58a42..06e41b2 100644
> --- a/include/drm/drm_dp_helper.h
> +++ b/include/drm/drm_dp_helper.h
> @@ -223,6 +223,8 @@
> #define DP_DSC_MAX_BITS_PER_PIXEL_LOW 0x067 /* eDP 1.4 */
>
> #define DP_DSC_MAX_BITS_PER_PIXEL_HI 0x068 /* eDP 1.4 */
> +# define DP_DSC_MAX_BITS_PER_PIXEL_HI_MASK (0x3 << 0)
> +# define DP_DSC_MAX_BITS_PER_PIXEL_HI_SHIFT 8
>
> #define DP_DSC_DEC_COLOR_FORMAT_CAP 0x069
> # define DP_DSC_RGB (1 << 0)
> @@ -271,6 +273,7 @@
> # define DP_DSC_THROUGHPUT_MODE_1_1000 (14 << 4)
>
> #define DP_DSC_MAX_SLICE_WIDTH 0x06C
> +#define DP_DSC_MAX_SLICE_WIDTH_VALUE 2560
>
> #define DP_DSC_SLICE_CAP_2 0x06D
> # define DP_DSC_16_PER_DP_DSC_SINK (1 << 0)
> @@ -894,6 +897,7 @@ u8 drm_dp_get_adjust_request_pre_emphasis(const u8 link_status[DP_LINK_STATUS_SI
>
> #define DP_BRANCH_OUI_HEADER_SIZE 0xc
> #define DP_RECEIVER_CAP_SIZE 0xf
> +#define DP_DSC_RECEIVER_CAP_SIZE 0xf
> #define EDP_PSR_RECEIVER_CAP_SIZE 2
> #define EDP_DISPLAY_CTL_CAP_SIZE 3
>
> --
> 2.7.4
>
--
Anusha Srivatsa
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2018-01-09 0:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-04 8:23 [PATCH v2 1/5] drm/dp: Add DP DSC DPCD receiver capability size define and missing SHIFT Manasi Navare
2018-01-04 8:23 ` [PATCH v2 4/5] drm/dp: Macro for DSC eDP Output BPP Manasi Navare
2018-01-11 22:13 ` Srivatsa, Anusha
2018-01-09 0:24 ` Anusha Srivatsa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180109002413.GA2694@intel.com \
--to=anusha.srivatsa@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gfx-internal-devel@eclists.intel.com \
--cc=manasi.d.navare@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.