* [PATCH v2 1/5] drm/dp: Add DP DSC DPCD receiver capability size define and missing SHIFT
@ 2018-01-04 8:23 Manasi Navare
2018-01-04 8:23 ` [PATCH v2 4/5] drm/dp: Macro for DSC eDP Output BPP Manasi Navare
2018-01-09 0:24 ` [PATCH v2 1/5] drm/dp: Add DP DSC DPCD receiver capability size define and missing SHIFT Anusha Srivatsa
0 siblings, 2 replies; 4+ messages in thread
From: Manasi Navare @ 2018-01-04 8:23 UTC (permalink / raw)
To: gfx-internal-devel; +Cc: Manasi Navare, dri-devel, Anusha Srivatsa
This patch defines the DP DSC receiver capability size that gives
total number of DP DSC DPCD registers.
This also adds a missing SHIFT define missed in the
commit id (ab6a46ea6842ce "Add DPCD definitions for DP 1.4 DSC feature")
v2:
* Missed the SHIFT define that I mentioned in the message
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Ville Syrjala <ville.syrjala@linux.intel.com>
Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Manasi Navare <manasi.d.navare@intel.com>
---
include/drm/drm_dp_helper.h | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
index da58a42..06e41b2 100644
--- a/include/drm/drm_dp_helper.h
+++ b/include/drm/drm_dp_helper.h
@@ -223,6 +223,8 @@
#define DP_DSC_MAX_BITS_PER_PIXEL_LOW 0x067 /* eDP 1.4 */
#define DP_DSC_MAX_BITS_PER_PIXEL_HI 0x068 /* eDP 1.4 */
+# define DP_DSC_MAX_BITS_PER_PIXEL_HI_MASK (0x3 << 0)
+# define DP_DSC_MAX_BITS_PER_PIXEL_HI_SHIFT 8
#define DP_DSC_DEC_COLOR_FORMAT_CAP 0x069
# define DP_DSC_RGB (1 << 0)
@@ -271,6 +273,7 @@
# define DP_DSC_THROUGHPUT_MODE_1_1000 (14 << 4)
#define DP_DSC_MAX_SLICE_WIDTH 0x06C
+#define DP_DSC_MAX_SLICE_WIDTH_VALUE 2560
#define DP_DSC_SLICE_CAP_2 0x06D
# define DP_DSC_16_PER_DP_DSC_SINK (1 << 0)
@@ -894,6 +897,7 @@ u8 drm_dp_get_adjust_request_pre_emphasis(const u8 link_status[DP_LINK_STATUS_SI
#define DP_BRANCH_OUI_HEADER_SIZE 0xc
#define DP_RECEIVER_CAP_SIZE 0xf
+#define DP_DSC_RECEIVER_CAP_SIZE 0xf
#define EDP_PSR_RECEIVER_CAP_SIZE 2
#define EDP_DISPLAY_CTL_CAP_SIZE 3
--
2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v2 4/5] drm/dp: Macro for DSC eDP Output BPP
2018-01-04 8:23 [PATCH v2 1/5] drm/dp: Add DP DSC DPCD receiver capability size define and missing SHIFT Manasi Navare
@ 2018-01-04 8:23 ` Manasi Navare
2018-01-11 22:13 ` Srivatsa, Anusha
2018-01-09 0:24 ` [PATCH v2 1/5] drm/dp: Add DP DSC DPCD receiver capability size define and missing SHIFT Anusha Srivatsa
1 sibling, 1 reply; 4+ messages in thread
From: Manasi Navare @ 2018-01-04 8:23 UTC (permalink / raw)
To: gfx-internal-devel; +Cc: Manasi Navare, dri-devel, Anusha Srivatsa
This returns the maximum output BPP supported by the
eDP panel by reading the MAX_SUPPORTED_BPP DSC DPCD register.
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Ville Syrjala <ville.syrjala@linux.intel.com>
Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Manasi Navare <manasi.d.navare@intel.com>
---
include/drm/drm_dp_helper.h | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
index 06e41b2..4e8f357 100644
--- a/include/drm/drm_dp_helper.h
+++ b/include/drm/drm_dp_helper.h
@@ -980,6 +980,16 @@ drm_dp_is_branch(const u8 dpcd[DP_RECEIVER_CAP_SIZE])
return dpcd[DP_DOWNSTREAMPORT_PRESENT] & DP_DWN_STRM_PORT_PRESENT;
}
+/* DP/eDP DSC support */
+static inline u16
+drm_edp_dsc_get_output_bpp(const u8 dsc_dpcd[DP_DSC_RECEIVER_CAP_SIZE])
+{
+ return dsc_dpcd[DP_DSC_MAX_BITS_PER_PIXEL_LOW - DP_DSC_SUPPORT] |
+ (dsc_dpcd[DP_DSC_MAX_BITS_PER_PIXEL_HI - DP_DSC_SUPPORT] &
+ DP_DSC_MAX_BITS_PER_PIXEL_HI_MASK <<
+ DP_DSC_MAX_BITS_PER_PIXEL_HI_SHIFT);
+}
+
/*
* DisplayPort AUX channel
*/
--
2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread* RE: [PATCH v2 4/5] drm/dp: Macro for DSC eDP Output BPP
2018-01-04 8:23 ` [PATCH v2 4/5] drm/dp: Macro for DSC eDP Output BPP Manasi Navare
@ 2018-01-11 22:13 ` Srivatsa, Anusha
0 siblings, 0 replies; 4+ messages in thread
From: Srivatsa, Anusha @ 2018-01-11 22:13 UTC (permalink / raw)
To: Navare, Manasi D, gfx-internal-devel@eclists.intel.com
Cc: dri-devel@lists.freedesktop.org
Looks good to me.
>-----Original Message-----
>From: Navare, Manasi D
>Sent: Thursday, January 4, 2018 12:23 AM
>To: gfx-internal-devel@eclists.intel.com
>Cc: Navare, Manasi D <manasi.d.navare@intel.com>; Jani Nikula
><jani.nikula@linux.intel.com>; Ville Syrjala <ville.syrjala@linux.intel.com>;
>Srivatsa, Anusha <anusha.srivatsa@intel.com>; dri-devel@lists.freedesktop.org
>Subject: [PATCH v2 4/5] drm/dp: Macro for DSC eDP Output BPP
>
>This returns the maximum output BPP supported by the eDP panel by reading the
>MAX_SUPPORTED_BPP DSC DPCD register.
>
>Cc: Jani Nikula <jani.nikula@linux.intel.com>
>Cc: Ville Syrjala <ville.syrjala@linux.intel.com>
>Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
>Cc: dri-devel@lists.freedesktop.org
>Signed-off-by: Manasi Navare <manasi.d.navare@intel.com>
Reviewed-by: Anusha Srivatsa<anusha.srivatsa@intel.com>
>---
> include/drm/drm_dp_helper.h | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
>diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h index
>06e41b2..4e8f357 100644
>--- a/include/drm/drm_dp_helper.h
>+++ b/include/drm/drm_dp_helper.h
>@@ -980,6 +980,16 @@ drm_dp_is_branch(const u8
>dpcd[DP_RECEIVER_CAP_SIZE])
> return dpcd[DP_DOWNSTREAMPORT_PRESENT] &
>DP_DWN_STRM_PORT_PRESENT; }
>
>+/* DP/eDP DSC support */
>+static inline u16
>+drm_edp_dsc_get_output_bpp(const u8
>dsc_dpcd[DP_DSC_RECEIVER_CAP_SIZE])
>+{
>+ return dsc_dpcd[DP_DSC_MAX_BITS_PER_PIXEL_LOW -
>DP_DSC_SUPPORT] |
>+ (dsc_dpcd[DP_DSC_MAX_BITS_PER_PIXEL_HI -
>DP_DSC_SUPPORT] &
>+ DP_DSC_MAX_BITS_PER_PIXEL_HI_MASK <<
>+ DP_DSC_MAX_BITS_PER_PIXEL_HI_SHIFT);
>+}
>+
> /*
> * DisplayPort AUX channel
> */
>--
>2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2 1/5] drm/dp: Add DP DSC DPCD receiver capability size define and missing SHIFT
2018-01-04 8:23 [PATCH v2 1/5] drm/dp: Add DP DSC DPCD receiver capability size define and missing SHIFT Manasi Navare
2018-01-04 8:23 ` [PATCH v2 4/5] drm/dp: Macro for DSC eDP Output BPP Manasi Navare
@ 2018-01-09 0:24 ` Anusha Srivatsa
1 sibling, 0 replies; 4+ messages in thread
From: Anusha Srivatsa @ 2018-01-09 0:24 UTC (permalink / raw)
To: Manasi Navare; +Cc: dri-devel, gfx-internal-devel
On Thu, Jan 04, 2018 at 12:23:16AM -0800, Manasi Navare wrote:
> This patch defines the DP DSC receiver capability size that gives
> total number of DP DSC DPCD registers.
> This also adds a missing SHIFT define missed in the
> commit id (ab6a46ea6842ce "Add DPCD definitions for DP 1.4 DSC feature")
>
> v2:
> * Missed the SHIFT define that I mentioned in the message
>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: Ville Syrjala <ville.syrjala@linux.intel.com>
> Cc: Anusha Srivatsa <anusha.srivatsa@intel.com>
> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: Manasi Navare <manasi.d.navare@intel.com>
Checked with the spec. Looks good to me.
Reviewed-by: Anusha Srivatsa <anushasrivatsa@intel.com>
> ---
> include/drm/drm_dp_helper.h | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
> index da58a42..06e41b2 100644
> --- a/include/drm/drm_dp_helper.h
> +++ b/include/drm/drm_dp_helper.h
> @@ -223,6 +223,8 @@
> #define DP_DSC_MAX_BITS_PER_PIXEL_LOW 0x067 /* eDP 1.4 */
>
> #define DP_DSC_MAX_BITS_PER_PIXEL_HI 0x068 /* eDP 1.4 */
> +# define DP_DSC_MAX_BITS_PER_PIXEL_HI_MASK (0x3 << 0)
> +# define DP_DSC_MAX_BITS_PER_PIXEL_HI_SHIFT 8
>
> #define DP_DSC_DEC_COLOR_FORMAT_CAP 0x069
> # define DP_DSC_RGB (1 << 0)
> @@ -271,6 +273,7 @@
> # define DP_DSC_THROUGHPUT_MODE_1_1000 (14 << 4)
>
> #define DP_DSC_MAX_SLICE_WIDTH 0x06C
> +#define DP_DSC_MAX_SLICE_WIDTH_VALUE 2560
>
> #define DP_DSC_SLICE_CAP_2 0x06D
> # define DP_DSC_16_PER_DP_DSC_SINK (1 << 0)
> @@ -894,6 +897,7 @@ u8 drm_dp_get_adjust_request_pre_emphasis(const u8 link_status[DP_LINK_STATUS_SI
>
> #define DP_BRANCH_OUI_HEADER_SIZE 0xc
> #define DP_RECEIVER_CAP_SIZE 0xf
> +#define DP_DSC_RECEIVER_CAP_SIZE 0xf
> #define EDP_PSR_RECEIVER_CAP_SIZE 2
> #define EDP_DISPLAY_CTL_CAP_SIZE 3
>
> --
> 2.7.4
>
--
Anusha Srivatsa
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-01-11 22:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-04 8:23 [PATCH v2 1/5] drm/dp: Add DP DSC DPCD receiver capability size define and missing SHIFT Manasi Navare
2018-01-04 8:23 ` [PATCH v2 4/5] drm/dp: Macro for DSC eDP Output BPP Manasi Navare
2018-01-11 22:13 ` Srivatsa, Anusha
2018-01-09 0:24 ` [PATCH v2 1/5] drm/dp: Add DP DSC DPCD receiver capability size define and missing SHIFT Anusha Srivatsa
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.