From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Quentin Schulz <quentin.schulz@free-electrons.com>
Cc: jic23@kernel.org, knaack.h@gmx.de, lars@metafoo.de,
pmeerw@pmeerw.net, robh+dt@kernel.org, mark.rutland@arm.com,
wens@csie.org, sre@kernel.org, linux@armlinux.org.uk,
lee.jones@linaro.org, linux-iio@vger.kernel.org,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
thomas.petazzoni@free-electrons.com,
linux-sunxi@googlegroups.com
Subject: Re: [PATCH v2 04/16] ARM: dtsi: axp209: add node for ADC
Date: Tue, 9 Jan 2018 10:48:46 +0100 [thread overview]
Message-ID: <20180109094846.fubahuqk5f4yuzrm@flea> (raw)
In-Reply-To: <d4de180d7f9555c3851f29a8c34d1f706cafd83e.1515486346.git-series.quentin.schulz@free-electrons.com>
[-- Attachment #1: Type: text/plain, Size: 928 bytes --]
On Tue, Jan 09, 2018 at 10:33:35AM +0100, Quentin Schulz wrote:
> This adds a DT node for the ADC of the PMIC so that there can be
> consumers of its IIO channels declaring their consumptions via DT.
>
> Signed-off-by: Quentin Schulz <quentin.schulz@free-electrons.com>
> ---
> arch/arm/boot/dts/axp209.dtsi | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/axp209.dtsi b/arch/arm/boot/dts/axp209.dtsi
> index 897103e..a2e0052 100644
> --- a/arch/arm/boot/dts/axp209.dtsi
> +++ b/arch/arm/boot/dts/axp209.dtsi
> @@ -58,6 +58,11 @@
> status = "disabled";
> };
>
> + axp_adc: axp-adc {
The node nade should be adc.
> + compatible = "x-powers,axp20x-adc";
And your compatible shouldn't have a wildcard but the first design
that introduced that IP.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Quentin Schulz
<quentin.schulz-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Cc: jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
knaack.h-Mmb7MZpHnFY@public.gmane.org,
lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org,
pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
wens-jdAy2FN1RRM@public.gmane.org,
sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org,
lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
Subject: Re: [PATCH v2 04/16] ARM: dtsi: axp209: add node for ADC
Date: Tue, 9 Jan 2018 10:48:46 +0100 [thread overview]
Message-ID: <20180109094846.fubahuqk5f4yuzrm@flea> (raw)
In-Reply-To: <d4de180d7f9555c3851f29a8c34d1f706cafd83e.1515486346.git-series.quentin.schulz-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 926 bytes --]
On Tue, Jan 09, 2018 at 10:33:35AM +0100, Quentin Schulz wrote:
> This adds a DT node for the ADC of the PMIC so that there can be
> consumers of its IIO channels declaring their consumptions via DT.
>
> Signed-off-by: Quentin Schulz <quentin.schulz-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
> ---
> arch/arm/boot/dts/axp209.dtsi | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/axp209.dtsi b/arch/arm/boot/dts/axp209.dtsi
> index 897103e..a2e0052 100644
> --- a/arch/arm/boot/dts/axp209.dtsi
> +++ b/arch/arm/boot/dts/axp209.dtsi
> @@ -58,6 +58,11 @@
> status = "disabled";
> };
>
> + axp_adc: axp-adc {
The node nade should be adc.
> + compatible = "x-powers,axp20x-adc";
And your compatible shouldn't have a wildcard but the first design
that introduced that IP.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 04/16] ARM: dtsi: axp209: add node for ADC
Date: Tue, 9 Jan 2018 10:48:46 +0100 [thread overview]
Message-ID: <20180109094846.fubahuqk5f4yuzrm@flea> (raw)
In-Reply-To: <d4de180d7f9555c3851f29a8c34d1f706cafd83e.1515486346.git-series.quentin.schulz@free-electrons.com>
On Tue, Jan 09, 2018 at 10:33:35AM +0100, Quentin Schulz wrote:
> This adds a DT node for the ADC of the PMIC so that there can be
> consumers of its IIO channels declaring their consumptions via DT.
>
> Signed-off-by: Quentin Schulz <quentin.schulz@free-electrons.com>
> ---
> arch/arm/boot/dts/axp209.dtsi | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/axp209.dtsi b/arch/arm/boot/dts/axp209.dtsi
> index 897103e..a2e0052 100644
> --- a/arch/arm/boot/dts/axp209.dtsi
> +++ b/arch/arm/boot/dts/axp209.dtsi
> @@ -58,6 +58,11 @@
> status = "disabled";
> };
>
> + axp_adc: axp-adc {
The node nade should be adc.
> + compatible = "x-powers,axp20x-adc";
And your compatible shouldn't have a wildcard but the first design
that introduced that IP.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180109/4db75619/attachment.sig>
next prev parent reply other threads:[~2018-01-09 9:48 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-09 9:33 [PATCH v2 00/16] add support for AXP813 ADC and battery power supply Quentin Schulz
2018-01-09 9:33 ` Quentin Schulz
2018-01-09 9:33 ` Quentin Schulz
2018-01-09 9:33 ` [PATCH v2 01/16] iio: adc: axp20x_adc: put ADC rate setting in a per-variant function Quentin Schulz
2018-01-09 9:33 ` Quentin Schulz
2018-01-09 9:33 ` Quentin Schulz
2018-01-09 9:33 ` [PATCH v2 02/16] dt-bindings: iio: adc: add binding for X-Powers AXP PMICs ADC Quentin Schulz
2018-01-09 9:33 ` Quentin Schulz
2018-01-09 9:33 ` Quentin Schulz
2018-01-11 22:07 ` Rob Herring
2018-01-11 22:07 ` Rob Herring
2018-01-09 9:33 ` [PATCH v2 03/16] iio: adc: axp20x_adc: make it possible to probe from DT Quentin Schulz
2018-01-09 9:33 ` Quentin Schulz
2018-01-09 9:33 ` Quentin Schulz
2018-01-09 9:33 ` [PATCH v2 04/16] ARM: dtsi: axp209: add node for ADC Quentin Schulz
2018-01-09 9:33 ` Quentin Schulz
2018-01-09 9:33 ` Quentin Schulz
2018-01-09 9:48 ` Maxime Ripard [this message]
2018-01-09 9:48 ` Maxime Ripard
2018-01-09 9:48 ` Maxime Ripard
2018-01-09 9:33 ` [PATCH v2 05/16] ARM: dtsi: axp22x: " Quentin Schulz
2018-01-09 9:33 ` Quentin Schulz
2018-01-09 9:33 ` Quentin Schulz
2018-01-09 9:33 ` [PATCH v2 06/16] mfd: axp20x: make AXP209/22x cells probe their ADC via DT Quentin Schulz
2018-01-09 9:33 ` Quentin Schulz
2018-01-09 9:33 ` Quentin Schulz
2018-01-09 9:33 ` [PATCH v2 07/16] dt-bindings: iio: adc: axp20x_adc: add AXP813 variant Quentin Schulz
2018-01-09 9:33 ` Quentin Schulz
2018-01-09 9:33 ` Quentin Schulz
2018-01-11 22:09 ` Rob Herring
2018-01-11 22:09 ` Rob Herring
2018-01-11 22:09 ` Rob Herring
2018-01-09 9:33 ` [PATCH v2 08/16] iio: adc: axp20x_adc: add support for AXP813 ADC Quentin Schulz
2018-01-09 9:33 ` Quentin Schulz
2018-01-09 9:33 ` Quentin Schulz
2018-01-09 9:33 ` [PATCH v2 09/16] ARM: dtsi: axp81x: add node for ADC Quentin Schulz
2018-01-09 9:33 ` Quentin Schulz
2018-01-09 9:33 ` Quentin Schulz
2018-01-09 9:33 ` [PATCH v2 10/16] mfd: axp20x: probe axp20x_adc driver for AXP813 Quentin Schulz
2018-01-09 9:33 ` Quentin Schulz
2018-01-09 9:33 ` Quentin Schulz
2018-01-09 9:33 ` [PATCH v2 11/16] power: supply: axp20x_battery: use data structure instead of ID for Quentin Schulz
2018-01-09 9:33 ` Quentin Schulz
2018-01-09 9:33 ` Quentin Schulz
2018-01-09 9:33 ` [PATCH v2 12/16] dt-bindings: power: supply: axp20x: add AXP813 battery DT binding Quentin Schulz
2018-01-09 9:33 ` Quentin Schulz
2018-01-09 9:33 ` Quentin Schulz
2018-01-11 19:46 ` Rob Herring
2018-01-11 19:46 ` Rob Herring
2018-01-11 19:46 ` Rob Herring
2018-01-09 9:33 ` [PATCH v2 13/16] power: supply: axp20x_battery: add support for AXP813 Quentin Schulz
2018-01-09 9:33 ` Quentin Schulz
2018-01-09 9:33 ` Quentin Schulz
2018-01-09 12:53 ` [linux-sunxi] " Julian Calaby
2018-01-09 12:53 ` Julian Calaby
2018-01-09 12:53 ` Julian Calaby
2018-01-09 9:33 ` [PATCH v2 14/16] mfd: axp20x: add battery power supply cell " Quentin Schulz
2018-01-09 9:33 ` Quentin Schulz
2018-01-09 9:33 ` Quentin Schulz
2018-01-09 9:33 ` [PATCH v2 15/16] ARM: dtsi: axp81x: add battery power supply subnode Quentin Schulz
2018-01-09 9:33 ` Quentin Schulz
2018-01-09 9:33 ` Quentin Schulz
2018-01-09 9:33 ` [PATCH v2 16/16] ARM: dtsi: sun8i: a711: enable " Quentin Schulz
2018-01-09 9:33 ` Quentin Schulz
2018-01-09 9:33 ` Quentin Schulz
2018-01-14 13:56 ` [PATCH v2 00/16] add support for AXP813 ADC and battery power supply Jonathan Cameron
2018-01-14 13:56 ` Jonathan Cameron
2018-01-14 13:56 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180109094846.fubahuqk5f4yuzrm@flea \
--to=maxime.ripard@free-electrons.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pmeerw@pmeerw.net \
--cc=quentin.schulz@free-electrons.com \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
--cc=thomas.petazzoni@free-electrons.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.