All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel RAYNAL <miquel.raynal@free-electrons.com>
To: Robert Jarzmik <robert.jarzmik@free.fr>
Cc: Boris Brezillon <boris.brezillon@free-electrons.com>,
	David Woodhouse <dwmw2@infradead.org>,
	Brian Norris <computersforpeace@gmail.com>,
	Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
	linux-mtd@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 00/12] Marvell NAND controller rework with ->exec_op()
Date: Tue, 9 Jan 2018 12:06:09 +0100	[thread overview]
Message-ID: <20180109120609.153b6bde@xps13> (raw)
In-Reply-To: <87zi5nbh14.fsf@belgarion.home>

Hello Robert,

On Tue, 09 Jan 2018 08:57:59 +0100
Robert Jarzmik <robert.jarzmik@free.fr> wrote:

> Boris Brezillon <boris.brezillon@free-electrons.com> writes:
> 
> Ok I recovered my NAND.
> 
> For the next try, I'd like you to provide another "temporary patch"
> to disable BBT actual writing, just to be sure. Once the driver is
> working properly, I'll make another try without the temporary patch.

The best way to do it is to avoid using the BBT at all, and while I was
looking for the right line to comment in the Zylonite's board file I
found out that the boolean flash_bbt is not actually set and then I
remembered an old mail from you, then you should:

----->8-----
diff --git a/arch/arm/mach-pxa/zylonite.c b/arch/arm/mach-pxa/zylonite.c
index 0534949d63f6..d247ef01dc62 100644
--- a/arch/arm/mach-pxa/zylonite.c
+++ b/arch/arm/mach-pxa/zylonite.c
@@ -378,6 +378,8 @@ static struct mtd_partition
zylonite_nand_partitions[] = { static struct pxa3xx_nand_platform_data
zylonite_nand_info = { .parts		= zylonite_nand_partitions,
 	.nr_parts	= ARRAY_SIZE(zylonite_nand_partitions),
-	.flash_bbt	= 1,
	.keep_config	= 1,
 };
 
 static void __init zylonite_init_nand(void)
-----8<-----

Then, do not forget to resize the partition that stores the BBT to
remove the last 4 erase blocks from it to avoid UBI/UBIFS smashing it.

Then you should be fine.

You can test this branch (updated with last version I sent earlier):
https://github.com/miquelraynal/linux/tree/marvell/nand-next/nfc


Thanks,
Miquèl

WARNING: multiple messages have this Message-ID (diff)
From: miquel.raynal@free-electrons.com (Miquel RAYNAL)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 00/12] Marvell NAND controller rework with ->exec_op()
Date: Tue, 9 Jan 2018 12:06:09 +0100	[thread overview]
Message-ID: <20180109120609.153b6bde@xps13> (raw)
In-Reply-To: <87zi5nbh14.fsf@belgarion.home>

Hello Robert,

On Tue, 09 Jan 2018 08:57:59 +0100
Robert Jarzmik <robert.jarzmik@free.fr> wrote:

> Boris Brezillon <boris.brezillon@free-electrons.com> writes:
> 
> Ok I recovered my NAND.
> 
> For the next try, I'd like you to provide another "temporary patch"
> to disable BBT actual writing, just to be sure. Once the driver is
> working properly, I'll make another try without the temporary patch.

The best way to do it is to avoid using the BBT at all, and while I was
looking for the right line to comment in the Zylonite's board file I
found out that the boolean flash_bbt is not actually set and then I
remembered an old mail from you, then you should:

----->8-----
diff --git a/arch/arm/mach-pxa/zylonite.c b/arch/arm/mach-pxa/zylonite.c
index 0534949d63f6..d247ef01dc62 100644
--- a/arch/arm/mach-pxa/zylonite.c
+++ b/arch/arm/mach-pxa/zylonite.c
@@ -378,6 +378,8 @@ static struct mtd_partition
zylonite_nand_partitions[] = { static struct pxa3xx_nand_platform_data
zylonite_nand_info = { .parts		= zylonite_nand_partitions,
 	.nr_parts	= ARRAY_SIZE(zylonite_nand_partitions),
-	.flash_bbt	= 1,
	.keep_config	= 1,
 };
 
 static void __init zylonite_init_nand(void)
-----8<-----

Then, do not forget to resize the partition that stores the BBT to
remove the last 4 erase blocks from it to avoid UBI/UBIFS smashing it.

Then you should be fine.

You can test this branch (updated with last version I sent earlier):
https://github.com/miquelraynal/linux/tree/marvell/nand-next/nfc


Thanks,
Miqu?l

  reply	other threads:[~2018-01-09 11:06 UTC|newest]

Thread overview: 126+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-07 20:18 [PATCH 00/12] Marvell NAND controller rework with ->exec_op() Miquel Raynal
2017-12-07 20:18 ` Miquel Raynal
2017-12-07 20:18 ` Miquel Raynal
2017-12-07 20:18 ` [PATCH 01/12] dt-bindings: mtd: add Marvell NAND controller documentation Miquel Raynal
2017-12-07 20:18   ` Miquel Raynal
2017-12-07 20:18   ` Miquel Raynal
2017-12-08 20:56   ` Boris Brezillon
2017-12-08 20:56     ` Boris Brezillon
2017-12-08 20:56     ` Boris Brezillon
2017-12-07 20:18 ` [PATCH 02/12] mtd: nand: add reworked Marvell NAND controller driver Miquel Raynal
2017-12-07 20:18   ` Miquel Raynal
2017-12-07 20:18   ` Miquel Raynal
2017-12-11 16:27   ` Ezequiel Garcia
2017-12-11 16:27     ` Ezequiel Garcia
2017-12-11 16:55     ` Miquel RAYNAL
2017-12-11 16:55       ` Miquel RAYNAL
2017-12-11 16:55       ` Miquel RAYNAL
2017-12-11 17:05       ` Boris Brezillon
2017-12-11 17:05         ` Boris Brezillon
2017-12-11 17:05         ` Boris Brezillon
2017-12-11 21:02         ` Miquel RAYNAL
2017-12-11 21:02           ` Miquel RAYNAL
2017-12-11 21:02           ` Miquel RAYNAL
2017-12-07 20:18 ` [PATCH 03/12] mtd: nand: replace pxa3xx_nand driver by its rework called marvell_nand Miquel Raynal
2017-12-07 20:18   ` Miquel Raynal
2017-12-07 20:18   ` Miquel Raynal
2017-12-07 20:18 ` [PATCH 04/12] dt-bindings: mtd: remove pxa3xx NAND controller documentation Miquel Raynal
2017-12-07 20:18   ` Miquel Raynal
2017-12-07 20:18   ` Miquel Raynal
2017-12-07 20:18 ` [PATCH 05/12] mtd: nand: remove useless fields from pxa3xx NAND platform data Miquel Raynal
2017-12-07 20:18   ` Miquel Raynal
2017-12-07 20:18   ` Miquel Raynal
2017-12-07 20:18 ` [PATCH 06/12] ARM: dts: armada-370-xp: use reworked NAND controller driver Miquel Raynal
2017-12-07 20:18   ` Miquel Raynal
2017-12-07 20:18   ` Miquel Raynal
2017-12-07 20:18 ` [PATCH 07/12] ARM: dts: armada-375: " Miquel Raynal
2017-12-07 20:18   ` Miquel Raynal
2017-12-07 20:18   ` Miquel Raynal
2017-12-07 20:18 ` [PATCH 08/12] ARM: dts: armada-38x: " Miquel Raynal
2017-12-07 20:18   ` Miquel Raynal
2017-12-07 20:18   ` Miquel Raynal
2017-12-07 20:18 ` [PATCH 09/12] ARM: dts: armada-39x: " Miquel Raynal
2017-12-07 20:18   ` Miquel Raynal
2017-12-07 20:18   ` Miquel Raynal
2017-12-07 20:18 ` [PATCH 10/12] ARM: dts: pxa: " Miquel Raynal
2017-12-07 20:18   ` Miquel Raynal
2017-12-07 20:18   ` Miquel Raynal
2017-12-07 20:18 ` [PATCH 11/12] ARM64: dts: marvell: use reworked NAND controller driver on Armada 7K Miquel Raynal
2017-12-07 20:18   ` Miquel Raynal
2017-12-07 20:18   ` Miquel Raynal
2017-12-15 10:29   ` Gregory CLEMENT
2017-12-15 10:29     ` Gregory CLEMENT
2017-12-15 10:29     ` Gregory CLEMENT
2017-12-15 10:44     ` Gregory CLEMENT
2017-12-15 10:44       ` Gregory CLEMENT
2017-12-15 10:44       ` Gregory CLEMENT
2017-12-07 20:18 ` [PATCH 12/12] ARM64: dts: marvell: use reworked NAND controller driver on Armada 8K Miquel Raynal
2017-12-07 20:18   ` Miquel Raynal
2017-12-07 20:18   ` Miquel Raynal
2017-12-15 10:29   ` Gregory CLEMENT
2017-12-15 10:29     ` Gregory CLEMENT
2017-12-15 10:29     ` Gregory CLEMENT
2017-12-15 10:44     ` Gregory CLEMENT
2017-12-15 10:44       ` Gregory CLEMENT
2017-12-15 10:44       ` Gregory CLEMENT
2017-12-09 23:27 ` [PATCH 00/12] Marvell NAND controller rework with ->exec_op() Ezequiel Garcia
2017-12-09 23:27   ` Ezequiel Garcia
2017-12-09 23:27   ` Ezequiel Garcia
2017-12-14  6:09 ` Boris Brezillon
2017-12-14  6:09   ` Boris Brezillon
2017-12-14  6:09   ` Boris Brezillon
2017-12-18  7:11   ` Robert Jarzmik
2017-12-18  7:11     ` Robert Jarzmik
2017-12-18  7:11     ` Robert Jarzmik
2017-12-18  8:25     ` Miquel RAYNAL
2017-12-18  8:25       ` Miquel RAYNAL
2017-12-18  8:25       ` Miquel RAYNAL
2017-12-20 21:26       ` Robert Jarzmik
2017-12-20 21:26         ` Robert Jarzmik
2017-12-20 21:26         ` Robert Jarzmik
2017-12-20 21:41         ` Boris Brezillon
2017-12-20 21:41           ` Boris Brezillon
2017-12-20 21:41           ` Boris Brezillon
2017-12-22 20:11           ` Robert Jarzmik
2017-12-22 20:11             ` Robert Jarzmik
2017-12-22 20:11             ` Robert Jarzmik
2017-12-22 21:24             ` Boris Brezillon
2017-12-22 21:24               ` Boris Brezillon
2017-12-22 21:24               ` Boris Brezillon
2017-12-22 22:37               ` Miquel RAYNAL
2017-12-22 22:37                 ` Miquel RAYNAL
2017-12-22 22:37                 ` Miquel RAYNAL
2017-12-22 22:50                 ` Miquel RAYNAL
2017-12-22 22:50                   ` Miquel RAYNAL
2017-12-22 22:50                   ` Miquel RAYNAL
2017-12-23 13:42                 ` Robert Jarzmik
2017-12-23 13:42                   ` Robert Jarzmik
2017-12-23 14:57                   ` Miquel RAYNAL
2017-12-23 14:57                     ` Miquel RAYNAL
2017-12-23 17:14                     ` Robert Jarzmik
2017-12-23 17:14                       ` Robert Jarzmik
2017-12-23 22:42                       ` Miquel RAYNAL
2017-12-23 22:42                         ` Miquel RAYNAL
2018-01-02 11:03                       ` Miquel RAYNAL
2018-01-02 11:03                         ` Miquel RAYNAL
2018-01-02 19:21                         ` Robert Jarzmik
2018-01-03  7:40                           ` Miquel RAYNAL
2018-01-03  7:40                             ` Miquel RAYNAL
2018-01-03 19:58                             ` Robert Jarzmik
2018-01-03 19:58                               ` Robert Jarzmik
2018-01-03 20:10                               ` Boris Brezillon
2018-01-03 20:10                                 ` Boris Brezillon
2018-01-03 20:52                                 ` Boris Brezillon
2018-01-03 20:52                                   ` Boris Brezillon
2018-01-07 20:55                                   ` Robert Jarzmik
2018-01-07 20:55                                     ` Robert Jarzmik
2018-01-07 21:09                                     ` Miquel RAYNAL
2018-01-07 21:09                                       ` Miquel RAYNAL
2018-01-07 21:19                                       ` Boris Brezillon
2018-01-07 21:19                                         ` Boris Brezillon
2018-01-07 21:26                                         ` Boris Brezillon
2018-01-07 21:26                                           ` Boris Brezillon
2018-01-09  7:57                                   ` Robert Jarzmik
2018-01-09  7:57                                     ` Robert Jarzmik
2018-01-09 11:06                                     ` Miquel RAYNAL [this message]
2018-01-09 11:06                                       ` Miquel RAYNAL

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180109120609.153b6bde@xps13 \
    --to=miquel.raynal@free-electrons.com \
    --cc=boris.brezillon@free-electrons.com \
    --cc=computersforpeace@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=ezequiel.garcia@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=robert.jarzmik@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.