All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Pete Zaitcev <zaitcev@redhat.com>
Cc: "Kirill A. Shutemov" <kirill@shutemov.name>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-mm@kvack.org, linux-usb@vger.kernel.org
Subject: The usbmon triggers a BUG in ./include/linux/mm.h
Date: Tue, 9 Jan 2018 16:03:12 +0100	[thread overview]
Message-ID: <20180109150312.GA24254@kroah.com> (raw)

On Mon, Jan 08, 2018 at 03:46:41PM -0600, Pete Zaitcev wrote:
> Automated tests triggered this by opening usbmon and accessing the
> mmap while simultaneously resizing the buffers. This bug was with
> us since 2006, because typically applications only size the buffers
> once and thus avoid racing. Reported by Kirill A. Shutemov.
> 
> Signed-off-by: Pete Zaitcev <zaitcev@redhat.com>
> ---
>  drivers/usb/mon/mon_bin.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)

You forgot a reported-by line :(

I'll go add it, it's been a while since you submitted a kernel patch,
you must have forgotten :)

thanks,

greg k-h
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Pete Zaitcev <zaitcev@redhat.com>
Cc: "Kirill A. Shutemov" <kirill@shutemov.name>,
	Andrew Morton <akpm@linux-foundation.org>,
	linux-mm@kvack.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH] The usbmon triggers a BUG in ./include/linux/mm.h
Date: Tue, 9 Jan 2018 16:03:12 +0100	[thread overview]
Message-ID: <20180109150312.GA24254@kroah.com> (raw)
In-Reply-To: <20180108154641.106218e8@lembas.zaitcev.lan>

On Mon, Jan 08, 2018 at 03:46:41PM -0600, Pete Zaitcev wrote:
> Automated tests triggered this by opening usbmon and accessing the
> mmap while simultaneously resizing the buffers. This bug was with
> us since 2006, because typically applications only size the buffers
> once and thus avoid racing. Reported by Kirill A. Shutemov.
> 
> Signed-off-by: Pete Zaitcev <zaitcev@redhat.com>
> ---
>  drivers/usb/mon/mon_bin.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)

You forgot a reported-by line :(

I'll go add it, it's been a while since you submitted a kernel patch,
you must have forgotten :)

thanks,

greg k-h

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

             reply	other threads:[~2018-01-09 15:03 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-09 15:03 Greg Kroah-Hartman [this message]
2018-01-09 15:03 ` [PATCH] The usbmon triggers a BUG in ./include/linux/mm.h Greg Kroah-Hartman
  -- strict thread matches above, loose matches on Subject: below --
2018-01-08 21:46 Pete Zaitcev
2018-01-08 21:46 ` [PATCH] " Pete Zaitcev
2018-01-08 21:25 Fw: kernel BUG at ./include/linux/mm.h:LINE! (3) Pete Zaitcev
2018-01-08 21:25 ` Pete Zaitcev
2018-01-08  5:22 Fw: " Pete Zaitcev
2018-01-08  5:22 ` Pete Zaitcev
2018-01-04  0:42 Pete Zaitcev
2018-01-04  0:42 ` Pete Zaitcev
2018-01-03 21:08 Matthew Wilcox
2018-01-03 21:08 ` Matthew Wilcox
2018-01-03 21:04 Pete Zaitcev
2018-01-03 21:04 ` Pete Zaitcev
2018-01-03  9:26 Fw: " Kirill A. Shutemov
2018-01-03  9:26 ` Kirill A. Shutemov
2018-01-03  7:02 Fw: " Pete Zaitcev
2018-01-03  7:02 ` Pete Zaitcev
2017-12-29 13:24 Fw: " Kirill A. Shutemov
2017-12-29 13:24 ` Kirill A. Shutemov
2017-12-29  0:03 Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180109150312.GA24254@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=akpm@linux-foundation.org \
    --cc=kirill@shutemov.name \
    --cc=linux-mm@kvack.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=zaitcev@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.