From: jacopo mondi <jacopo-AW8dsiIh9cEdnm+yROfE0A@public.gmane.org>
To: Shunqian Zheng <zhengsq-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
Cc: mchehab-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
ddl-TNX95d0MmH7DzftRWevZcw@public.gmane.org,
tfiga-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org
Subject: Re: [PATCH v5 1/4] dt-bindings: media: Add bindings for OV5695
Date: Wed, 10 Jan 2018 10:33:12 +0100 [thread overview]
Message-ID: <20180110093312.GE25666@w540> (raw)
In-Reply-To: <20180110092010.GC6834@w540>
On Wed, Jan 10, 2018 at 10:20:10AM +0100, jacopo mondi wrote:
> Hi Shunqian,
>
> On Wed, Jan 10, 2018 at 10:06:04AM +0800, Shunqian Zheng wrote:
> > Add device tree binding documentation for the OV5695 sensor.
> >
> > Signed-off-by: Shunqian Zheng <zhengsq-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
> > ---
> > .../devicetree/bindings/media/i2c/ov5695.txt | 41 ++++++++++++++++++++++
> > 1 file changed, 41 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/media/i2c/ov5695.txt
> >
> > diff --git a/Documentation/devicetree/bindings/media/i2c/ov5695.txt b/Documentation/devicetree/bindings/media/i2c/ov5695.txt
> > new file mode 100644
> > index 0000000..2f2f698
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/media/i2c/ov5695.txt
> > @@ -0,0 +1,41 @@
> > +* Omnivision OV5695 MIPI CSI-2 sensor
> > +
> > +Required Properties:
> > +- compatible: shall be "ovti,ov5695"
> > +- clocks: reference to the xvclk input clock
> > +- clock-names: shall be "xvclk"
> > +- avdd-supply: Analog voltage supply, 2.8 volts
> > +- dovdd-supply: Digital I/O voltage supply, 1.8 volts
> > +- dvdd-supply: Digital core voltage supply, 1.2 volts
> > +- reset-gpios: Low active reset gpio
> > +
> > +The device node shall contain one 'port' child node with an
> > +'endpoint' subnode for its digital output video port,
> > +in accordance with the video interface bindings defined in
> > +Documentation/devicetree/bindings/media/video-interfaces.txt.
> > +The endpoint optional property 'data-lanes' shall be "<1 2>".
>
> What happens if the property is not present? What's the default?
>
> I would:
>
> Required Properties:
> - compatible: ..
> ....
>
> Option Endpoint Properties:
Optional, not Option, sorry about this
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: jacopo mondi <jacopo@jmondi.org>
To: Shunqian Zheng <zhengsq@rock-chips.com>
Cc: mchehab@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
ddl@rock-chips.com, tfiga@chromium.org
Subject: Re: [PATCH v5 1/4] dt-bindings: media: Add bindings for OV5695
Date: Wed, 10 Jan 2018 10:33:12 +0100 [thread overview]
Message-ID: <20180110093312.GE25666@w540> (raw)
In-Reply-To: <20180110092010.GC6834@w540>
On Wed, Jan 10, 2018 at 10:20:10AM +0100, jacopo mondi wrote:
> Hi Shunqian,
>
> On Wed, Jan 10, 2018 at 10:06:04AM +0800, Shunqian Zheng wrote:
> > Add device tree binding documentation for the OV5695 sensor.
> >
> > Signed-off-by: Shunqian Zheng <zhengsq@rock-chips.com>
> > ---
> > .../devicetree/bindings/media/i2c/ov5695.txt | 41 ++++++++++++++++++++++
> > 1 file changed, 41 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/media/i2c/ov5695.txt
> >
> > diff --git a/Documentation/devicetree/bindings/media/i2c/ov5695.txt b/Documentation/devicetree/bindings/media/i2c/ov5695.txt
> > new file mode 100644
> > index 0000000..2f2f698
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/media/i2c/ov5695.txt
> > @@ -0,0 +1,41 @@
> > +* Omnivision OV5695 MIPI CSI-2 sensor
> > +
> > +Required Properties:
> > +- compatible: shall be "ovti,ov5695"
> > +- clocks: reference to the xvclk input clock
> > +- clock-names: shall be "xvclk"
> > +- avdd-supply: Analog voltage supply, 2.8 volts
> > +- dovdd-supply: Digital I/O voltage supply, 1.8 volts
> > +- dvdd-supply: Digital core voltage supply, 1.2 volts
> > +- reset-gpios: Low active reset gpio
> > +
> > +The device node shall contain one 'port' child node with an
> > +'endpoint' subnode for its digital output video port,
> > +in accordance with the video interface bindings defined in
> > +Documentation/devicetree/bindings/media/video-interfaces.txt.
> > +The endpoint optional property 'data-lanes' shall be "<1 2>".
>
> What happens if the property is not present? What's the default?
>
> I would:
>
> Required Properties:
> - compatible: ..
> ....
>
> Option Endpoint Properties:
Optional, not Option, sorry about this
next prev parent reply other threads:[~2018-01-10 9:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-10 2:06 [PATCH v5 0/4] Add supports for OV2685 and OV5695 sensors Shunqian Zheng
2018-01-10 2:06 ` [PATCH v5 1/4] dt-bindings: media: Add bindings for OV5695 Shunqian Zheng
[not found] ` <1515549967-5302-2-git-send-email-zhengsq-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2018-01-10 9:20 ` jacopo mondi
2018-01-10 9:20 ` jacopo mondi
2018-01-10 9:33 ` jacopo mondi [this message]
2018-01-10 9:33 ` jacopo mondi
2018-01-11 6:44 ` Shunqian Zheng
[not found] ` <807c4307-0617-788e-7129-039b33ce99d5-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2018-01-18 22:30 ` Sakari Ailus
2018-01-18 22:30 ` Sakari Ailus
2018-01-10 2:06 ` [PATCH v5 2/4] media: ov5695: add support for OV5695 sensor Shunqian Zheng
[not found] ` <1515549967-5302-3-git-send-email-zhengsq-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2018-01-10 9:08 ` jacopo mondi
2018-01-10 9:08 ` jacopo mondi
2018-01-11 6:21 ` Shunqian Zheng
2018-01-10 2:06 ` [PATCH v5 3/4] dt-bindings: media: Add bindings for OV2685 Shunqian Zheng
[not found] ` <1515549967-5302-1-git-send-email-zhengsq-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2018-01-10 2:06 ` [PATCH v5 4/4] media: ov2685: add support for OV2685 sensor Shunqian Zheng
2018-01-10 2:06 ` Shunqian Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180110093312.GE25666@w540 \
--to=jacopo-aw8dsiih9cednm+yrofe0a@public.gmane.org \
--cc=ddl-TNX95d0MmH7DzftRWevZcw@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=mchehab-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=tfiga-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
--cc=zhengsq-TNX95d0MmH7DzftRWevZcw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.