From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Robin Murphy <robin.murphy@arm.com>,
arno@natisbad.org, herbert@gondor.apana.org.au,
davem@davemloft.net, linux-crypto@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] crypto: marvell/cesa - Fix DMA API misuse
Date: Wed, 10 Jan 2018 17:23:20 +0100 [thread overview]
Message-ID: <20180110172320.5ab39e43@bbrezillon> (raw)
In-Reply-To: <20180110154817.GA18707@lst.de>
Hi Christoph,
On Wed, 10 Jan 2018 16:48:17 +0100
Christoph Hellwig <hch@lst.de> wrote:
> On Wed, Jan 10, 2018 at 04:25:22PM +0100, Boris Brezillon wrote:
> > On Wed, 10 Jan 2018 15:15:43 +0000
> > Robin Murphy <robin.murphy@arm.com> wrote:
> >
> > > phys_to_dma() is an internal helper for certain DMA API implementations,
> > > and is not appropriate for drivers to use. It appears that what the CESA
> > > driver really wants to be using is dma_map_resource() - admittedly that
> > > didn't exist when the offending code was first merged, but it does now.
> > >
> > > Signed-off-by: Robin Murphy <robin.murphy@arm.com>
> >
> > Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
>
> Thanks. Robin, Boris: do you want me to pick this up in the
> dma-mapping tree and move it before the dma-direct.h introduction?
You should probably sync with Herbert, I'm just the maintainer of this
driver, not the crypto subsystem.
Regards,
Boris
WARNING: multiple messages have this Message-ID (diff)
From: boris.brezillon@free-electrons.com (Boris Brezillon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] crypto: marvell/cesa - Fix DMA API misuse
Date: Wed, 10 Jan 2018 17:23:20 +0100 [thread overview]
Message-ID: <20180110172320.5ab39e43@bbrezillon> (raw)
In-Reply-To: <20180110154817.GA18707@lst.de>
Hi Christoph,
On Wed, 10 Jan 2018 16:48:17 +0100
Christoph Hellwig <hch@lst.de> wrote:
> On Wed, Jan 10, 2018 at 04:25:22PM +0100, Boris Brezillon wrote:
> > On Wed, 10 Jan 2018 15:15:43 +0000
> > Robin Murphy <robin.murphy@arm.com> wrote:
> >
> > > phys_to_dma() is an internal helper for certain DMA API implementations,
> > > and is not appropriate for drivers to use. It appears that what the CESA
> > > driver really wants to be using is dma_map_resource() - admittedly that
> > > didn't exist when the offending code was first merged, but it does now.
> > >
> > > Signed-off-by: Robin Murphy <robin.murphy@arm.com>
> >
> > Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
>
> Thanks. Robin, Boris: do you want me to pick this up in the
> dma-mapping tree and move it before the dma-direct.h introduction?
You should probably sync with Herbert, I'm just the maintainer of this
driver, not the crypto subsystem.
Regards,
Boris
next prev parent reply other threads:[~2018-01-10 16:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-10 15:15 [PATCH] crypto: marvell/cesa - Fix DMA API misuse Robin Murphy
2018-01-10 15:15 ` Robin Murphy
2018-01-10 15:25 ` Boris Brezillon
2018-01-10 15:25 ` Boris Brezillon
2018-01-10 15:48 ` Christoph Hellwig
2018-01-10 15:48 ` Christoph Hellwig
2018-01-10 16:23 ` Boris Brezillon [this message]
2018-01-10 16:23 ` Boris Brezillon
2018-01-18 12:03 ` Herbert Xu
2018-01-18 12:03 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180110172320.5ab39e43@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=arno@natisbad.org \
--cc=davem@davemloft.net \
--cc=hch@lst.de \
--cc=herbert@gondor.apana.org.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.