From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Yu Zhao <yuzhao@google.com>
Cc: Dan Streetman <ddstreet@ieee.org>,
Seth Jennings <sjenning@redhat.com>,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
Minchan Kim <minchan@kernel.org>, Nitin Gupta <ngupta@vflare.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] zswap: only save zswap header when necessary
Date: Thu, 11 Jan 2018 16:04:59 +0900 [thread overview]
Message-ID: <20180111070459.GH494@jagdpanzerIV> (raw)
In-Reply-To: <20180110225626.110330-1-yuzhao@google.com>
On (01/10/18 14:56), Yu Zhao wrote:
[..]
> We waste sizeof(swp_entry_t) for zswap header when using zsmalloc
> as zpool driver because zsmalloc doesn't support eviction.
>
> Add zpool_evictable() to detect if zpool is potentially evictable,
> and use it in zswap to avoid waste memory for zswap header.
>
> Signed-off-by: Yu Zhao <yuzhao@google.com>
looks good to me.
FWIW,
Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
-ss
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Yu Zhao <yuzhao@google.com>
Cc: Dan Streetman <ddstreet@ieee.org>,
Seth Jennings <sjenning@redhat.com>,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
Minchan Kim <minchan@kernel.org>, Nitin Gupta <ngupta@vflare.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] zswap: only save zswap header when necessary
Date: Thu, 11 Jan 2018 16:04:59 +0900 [thread overview]
Message-ID: <20180111070459.GH494@jagdpanzerIV> (raw)
In-Reply-To: <20180110225626.110330-1-yuzhao@google.com>
On (01/10/18 14:56), Yu Zhao wrote:
[..]
> We waste sizeof(swp_entry_t) for zswap header when using zsmalloc
> as zpool driver because zsmalloc doesn't support eviction.
>
> Add zpool_evictable() to detect if zpool is potentially evictable,
> and use it in zswap to avoid waste memory for zswap header.
>
> Signed-off-by: Yu Zhao <yuzhao@google.com>
looks good to me.
FWIW,
Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
-ss
next prev parent reply other threads:[~2018-01-11 7:05 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-08 22:51 [PATCH] zswap: only save zswap header if zpool is shrinkable Yu Zhao
2018-01-08 22:51 ` Yu Zhao
2018-01-09 2:35 ` Sergey Senozhatsky
2018-01-09 2:35 ` Sergey Senozhatsky
2018-01-09 4:48 ` Sergey Senozhatsky
2018-01-09 4:48 ` Sergey Senozhatsky
2018-01-09 11:01 ` Yu Zhao
2018-01-09 11:01 ` Yu Zhao
2018-01-09 18:25 ` Dan Streetman
2018-01-09 18:25 ` Dan Streetman
2018-01-09 22:47 ` Yu Zhao
2018-01-09 22:47 ` Yu Zhao
2018-01-10 20:06 ` Dan Streetman
2018-01-10 20:06 ` Dan Streetman
2018-01-10 22:23 ` Yu Zhao
2018-01-10 22:23 ` Yu Zhao
2018-01-11 6:57 ` Sergey Senozhatsky
2018-01-11 6:57 ` Sergey Senozhatsky
2018-01-10 22:47 ` [PATCH v2] zswap: only save zswap header when necessary Yu Zhao
2018-01-10 22:47 ` Yu Zhao
2018-01-10 22:56 ` [PATCH v3] " Yu Zhao
2018-01-10 22:56 ` Yu Zhao
2018-01-11 7:04 ` Sergey Senozhatsky [this message]
2018-01-11 7:04 ` Sergey Senozhatsky
2018-01-11 21:59 ` Dan Streetman
2018-01-11 21:59 ` Dan Streetman
2018-01-10 23:00 ` [PATCH v2] " Yu Zhao
2018-01-10 23:00 ` Yu Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180111070459.GH494@jagdpanzerIV \
--to=sergey.senozhatsky.work@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=ddstreet@ieee.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan@kernel.org \
--cc=ngupta@vflare.org \
--cc=sjenning@redhat.com \
--cc=yuzhao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.