From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH] nvme-pci: calculate iod and avg_seg_size just before use them
Date: Thu, 11 Jan 2018 08:48:58 -0700 [thread overview]
Message-ID: <20180111154857.GA2602@localhost.localdomain> (raw)
In-Reply-To: <1515647379-1877-1-git-send-email-jianchao.w.wang@oracle.com>
On Thu, Jan 11, 2018@01:09:39PM +0800, Jianchao Wang wrote:
> The calculation of iod and avg_seg_size maybe meaningless if
> nvme_pci_use_sgls returns before uses them. So calculate
> just before use them.
The compiler will do the right thing here, but I see what you mean. I
think Christoph has some SGL improvements coming, though, that will
obviate this.
WARNING: multiple messages have this Message-ID (diff)
From: Keith Busch <keith.busch@intel.com>
To: Jianchao Wang <jianchao.w.wang@oracle.com>
Cc: axboe@fb.com, hch@lst.de, sagi@grimberg.me,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nvme-pci: calculate iod and avg_seg_size just before use them
Date: Thu, 11 Jan 2018 08:48:58 -0700 [thread overview]
Message-ID: <20180111154857.GA2602@localhost.localdomain> (raw)
In-Reply-To: <1515647379-1877-1-git-send-email-jianchao.w.wang@oracle.com>
On Thu, Jan 11, 2018 at 01:09:39PM +0800, Jianchao Wang wrote:
> The calculation of iod and avg_seg_size maybe meaningless if
> nvme_pci_use_sgls returns before uses them. So calculate
> just before use them.
The compiler will do the right thing here, but I see what you mean. I
think Christoph has some SGL improvements coming, though, that will
obviate this.
next prev parent reply other threads:[~2018-01-11 15:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-11 5:09 [PATCH] nvme-pci: calculate iod and avg_seg_size just before use them Jianchao Wang
2018-01-11 5:09 ` Jianchao Wang
2018-01-11 15:48 ` Keith Busch [this message]
2018-01-11 15:48 ` Keith Busch
2018-01-12 1:31 ` jianchao.wang
2018-01-12 1:31 ` jianchao.wang
2018-01-14 9:28 ` Sagi Grimberg
2018-01-14 9:28 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180111154857.GA2602@localhost.localdomain \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.