* [U-Boot] [GIT PULL] u-boot-uniphier/master
@ 2018-01-09 13:04 Masahiro Yamada
2018-01-09 17:30 ` Tom Rini
2018-01-10 3:21 ` [U-Boot] [GIT PULL] ZFS: lundman/master Jorgen Lundman
0 siblings, 2 replies; 6+ messages in thread
From: Masahiro Yamada @ 2018-01-09 13:04 UTC (permalink / raw)
To: u-boot
Hi Tom,
The MW is open, and here are some updates. Please pull!
The following changes since commit f3dd87e0b98999a78e500e8c6d2b063ebadf535a:
Prepare v2018.01 (2018-01-08 20:25:29 -0500)
are available in the git repository at:
git://git.denx.de/u-boot-uniphier.git master
for you to fetch changes up to a322eb9ff6f4c43d378b683457bdbfc59c1c19a6:
ARM: uniphier: hide memory top by platform hook instead of CONFIG
(2018-01-09 21:58:19 +0900)
----------------------------------------------------------------
Masahiro Yamada (3):
ARM: uniphier: do not use RAM that exceeds 32 bit address range
ARM: uniphier: enable CONFIG_MMC_SDHCI_SDMA for ARMv8 SoCs
ARM: uniphier: hide memory top by platform hook instead of CONFIG
arch/arm/mach-uniphier/dram_init.c | 24 ++++++++++++++++++++++++
configs/uniphier_v8_defconfig | 1 +
include/configs/uniphier.h | 2 --
3 files changed, 25 insertions(+), 2 deletions(-)
--
Best Regards
Masahiro Yamada
^ permalink raw reply [flat|nested] 6+ messages in thread* [U-Boot] [GIT PULL] u-boot-uniphier/master
2018-01-09 13:04 [U-Boot] [GIT PULL] u-boot-uniphier/master Masahiro Yamada
@ 2018-01-09 17:30 ` Tom Rini
2018-01-10 3:21 ` [U-Boot] [GIT PULL] ZFS: lundman/master Jorgen Lundman
1 sibling, 0 replies; 6+ messages in thread
From: Tom Rini @ 2018-01-09 17:30 UTC (permalink / raw)
To: u-boot
On Tue, Jan 09, 2018 at 10:04:38PM +0900, Masahiro Yamada wrote:
> Hi Tom,
>
> The MW is open, and here are some updates. Please pull!
>
>
>
> The following changes since commit f3dd87e0b98999a78e500e8c6d2b063ebadf535a:
>
> Prepare v2018.01 (2018-01-08 20:25:29 -0500)
>
> are available in the git repository at:
>
> git://git.denx.de/u-boot-uniphier.git master
>
> for you to fetch changes up to a322eb9ff6f4c43d378b683457bdbfc59c1c19a6:
>
> ARM: uniphier: hide memory top by platform hook instead of CONFIG
> (2018-01-09 21:58:19 +0900)
>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180109/b088b955/attachment.sig>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [GIT PULL] ZFS: lundman/master
2018-01-09 13:04 [U-Boot] [GIT PULL] u-boot-uniphier/master Masahiro Yamada
2018-01-09 17:30 ` Tom Rini
@ 2018-01-10 3:21 ` Jorgen Lundman
2018-01-10 13:28 ` Tom Rini
1 sibling, 1 reply; 6+ messages in thread
From: Jorgen Lundman @ 2018-01-10 3:21 UTC (permalink / raw)
To: u-boot
Hello,
I didn't hear back about the changes, so I'll proceed to this stage. :)
Please find additional ZFS boot features, and fixes. Please advise if
outside git repositories are not allowed.
The following changes since commit ab61e175713a0400c6ece6348e8f655998cf574d:
ARM: rmobile: Rework the ULCB CPLD driver (Sun Nov 26 20:32:44 2017 +0100)
are available in the git repository at:
https://github.com/lundman/u-boot.git master
for you to fetch changes up to c2727e5004fe011d19156d728babdf968515b28d:
Update ZFS support to latest (Thu Dec 7 16:09:26 2017 +0900)
----------------------------------------------------------------
Jorgen Lundman (1):
Update ZFS support to latest
cmd/zfs.c | 22 +-
fs/zfs/Makefile | 4 +-
fs/zfs/dev.c | 20 +-
fs/zfs/zfs.c | 3223 +++++++++++++++++++++++++++++++-----------
fs/zfs/zfs_fletcher.c | 6 +-
fs/zfs/zfs_lz4.c | 286 ++++
fs/zfs/zfs_sha256.c | 14 +-
include/zfs/dmu.h | 48 +-
include/zfs/sa_impl.h | 5 +-
include/zfs/spa.h | 18 +
include/zfs/uberblock_impl.h | 15 +-
include/zfs/zap_leaf.h | 4 +-
include/zfs/zfs.h | 22 +-
include/zfs/zio.h | 9 +-
include/zfs_common.h | 27 +-
15 files changed, 2819 insertions(+), 904 deletions(-)
--
Jorgen Lundman | <lundman@lundman.net>
Unix Administrator | +81 (0)90-5578-8500
Shibuya-ku, Tokyo | Japan
^ permalink raw reply [flat|nested] 6+ messages in thread* [U-Boot] [GIT PULL] ZFS: lundman/master
2018-01-10 3:21 ` [U-Boot] [GIT PULL] ZFS: lundman/master Jorgen Lundman
@ 2018-01-10 13:28 ` Tom Rini
2018-01-11 0:12 ` Jorgen Lundman
0 siblings, 1 reply; 6+ messages in thread
From: Tom Rini @ 2018-01-10 13:28 UTC (permalink / raw)
To: u-boot
On Wed, Jan 10, 2018 at 12:21:32PM +0900, Jorgen Lundman wrote:
>
> Hello,
> I didn't hear back about the changes, so I'll proceed to this stage. :)
> Please find additional ZFS boot features, and fixes. Please advise if
> outside git repositories are not allowed.
>
> The following changes since commit ab61e175713a0400c6ece6348e8f655998cf574d:
>
> ARM: rmobile: Rework the ULCB CPLD driver (Sun Nov 26 20:32:44 2017 +0100)
>
> are available in the git repository at:
>
> https://github.com/lundman/u-boot.git master
>
> for you to fetch changes up to c2727e5004fe011d19156d728babdf968515b28d:
>
> Update ZFS support to latest (Thu Dec 7 16:09:26 2017 +0900)
> ----------------------------------------------------------------
> Jorgen Lundman (1):
> Update ZFS support to latest
>
> cmd/zfs.c | 22 +-
> fs/zfs/Makefile | 4 +-
> fs/zfs/dev.c | 20 +-
> fs/zfs/zfs.c | 3223 +++++++++++++++++++++++++++++++-----------
> fs/zfs/zfs_fletcher.c | 6 +-
> fs/zfs/zfs_lz4.c | 286 ++++
> fs/zfs/zfs_sha256.c | 14 +-
> include/zfs/dmu.h | 48 +-
> include/zfs/sa_impl.h | 5 +-
> include/zfs/spa.h | 18 +
> include/zfs/uberblock_impl.h | 15 +-
> include/zfs/zap_leaf.h | 4 +-
> include/zfs/zfs.h | 22 +-
> include/zfs/zio.h | 9 +-
> include/zfs_common.h | 27 +-
> 15 files changed, 2819 insertions(+), 904 deletions(-)
I'm reluctant to just take this as-is. That's a lot of code changes in
a single commit that was not posted (as far as I can see) to the mailing
list. Can you break that down into a series of changes that can be
reviewed and post that? Thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180110/2c4894e5/attachment.sig>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [GIT PULL] ZFS: lundman/master
2018-01-10 13:28 ` Tom Rini
@ 2018-01-11 0:12 ` Jorgen Lundman
2018-01-11 16:29 ` Tom Rini
0 siblings, 1 reply; 6+ messages in thread
From: Jorgen Lundman @ 2018-01-11 0:12 UTC (permalink / raw)
To: u-boot
>
> I'm reluctant to just take this as-is. That's a lot of code changes in
> a single commit that was not posted (as far as I can see) to the mailing
> list. Can you break that down into a series of changes that can be
> reviewed and post that? Thanks!
>
I received an email that ZFS U-boot booting was tricky to get to work,
since it required old pool version, and didn't work at all with big endian.
When I first did ZFS, I took the GRUB sources in 2012. So this time around,
I collected the commits from 2012 to now, and merged them into u-boot. Some
~50 commits or so. It makes U-boot work with modern pools, and current
default compression (lz4) as well as raidz/mirror boots.
It is a large change, I agree. But I'm unsure how to split it into smaller
commits. It is mostly bring it up to current with its upstream.
If it is preferred to post to the ML, I will do so - I thought "git pull"
was an alternate. Please advice,
Lund
--
Jorgen Lundman | <lundman@lundman.net>
Unix Administrator | +81 (0)90-5578-8500
Shibuya-ku, Tokyo | Japan
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [GIT PULL] ZFS: lundman/master
2018-01-11 0:12 ` Jorgen Lundman
@ 2018-01-11 16:29 ` Tom Rini
0 siblings, 0 replies; 6+ messages in thread
From: Tom Rini @ 2018-01-11 16:29 UTC (permalink / raw)
To: u-boot
On Thu, Jan 11, 2018 at 09:12:04AM +0900, Jorgen Lundman wrote:
> >
> > I'm reluctant to just take this as-is. That's a lot of code changes in
> > a single commit that was not posted (as far as I can see) to the mailing
> > list. Can you break that down into a series of changes that can be
> > reviewed and post that? Thanks!
> >
>
> I received an email that ZFS U-boot booting was tricky to get to work,
> since it required old pool version, and didn't work at all with big endian.
>
> When I first did ZFS, I took the GRUB sources in 2012. So this time around,
> I collected the commits from 2012 to now, and merged them into u-boot. Some
> ~50 commits or so. It makes U-boot work with modern pools, and current
> default compression (lz4) as well as raidz/mirror boots.
>
> It is a large change, I agree. But I'm unsure how to split it into smaller
> commits. It is mostly bring it up to current with its upstream.
>
> If it is preferred to post to the ML, I will do so - I thought "git pull"
> was an alternate. Please advice,
OK, so I took a look at
https://github.com/lundman/u-boot/commit/c2727e5004fe011d19156d728babdf968515b28d
and here's my comments:
- You're missing the Signed-off-by line
- You should mention the starting / ending revisions of your sync of the
code from GRUB.
- fs/zfs/zfs_lz4.c needs to use an SPDX tag.
- You've got some changes that change the Copyright year from 2012 to
2018, when it should be 2012-2018
And finally, it's not so large that you can't post the patch to the ML
for additional reviews and I'll pick it up and apply it directly.
Thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180111/0591599d/attachment.sig>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-01-11 16:29 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-09 13:04 [U-Boot] [GIT PULL] u-boot-uniphier/master Masahiro Yamada
2018-01-09 17:30 ` Tom Rini
2018-01-10 3:21 ` [U-Boot] [GIT PULL] ZFS: lundman/master Jorgen Lundman
2018-01-10 13:28 ` Tom Rini
2018-01-11 0:12 ` Jorgen Lundman
2018-01-11 16:29 ` Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.