From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH net-next v4 0/4] net: mvpp2: 1000BaseX and 2500BaseX support
Date: Thu, 11 Jan 2018 17:36:29 +0100 [thread overview]
Message-ID: <20180111173629.5d682190@windsurf.lan> (raw)
In-Reply-To: <20180111.113203.1899608306187914852.davem@davemloft.net>
Hello,
On Thu, 11 Jan 2018 11:32:03 -0500 (EST), David Miller wrote:
> From: David Miller <davem@davemloft.net>
> Date: Thu, 11 Jan 2018 11:23:37 -0500 (EST)
>
> > From: Antoine Tenart <antoine.tenart@free-electrons.com>
> > Date: Wed, 10 Jan 2018 16:58:04 +0100
> >
> >> This series adds 1000BaseX and 2500BaseX support to the Marvell PPv2
> >> driver. In order to use it, the 2.5 SGMII mode is added in the Marvell
> >> common PHY driver (cp110-comphy).
> >
> > Series applied, thank you.
>
> Actually, this introduced build warnings, I'm reverting. Please fix this
> and repost.
>
> Thank you.
>
> drivers/net/ethernet/marvell/mvpp2.c: In function ?mvpp2_port_mii_gmac_configure_mode?:
> drivers/net/ethernet/marvell/mvpp2.c:4687:26: warning: suggest parentheses around comparison in operand of ?|? [-Wparentheses]
> if (port->phy_interface == PHY_INTERFACE_MODE_1000BASEX |
> ~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
This is actually a very good warning: it should be a || and not |.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: David Miller <davem@davemloft.net>
Cc: antoine.tenart@free-electrons.com, kishon@ti.com, andrew@lunn.ch,
gregory.clement@free-electrons.com, linux@armlinux.org.uk,
mw@semihalf.com, stefanc@marvell.com, ymarkman@marvell.com,
miquel.raynal@free-electrons.com, nadavh@marvell.com,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v4 0/4] net: mvpp2: 1000BaseX and 2500BaseX support
Date: Thu, 11 Jan 2018 17:36:29 +0100 [thread overview]
Message-ID: <20180111173629.5d682190@windsurf.lan> (raw)
In-Reply-To: <20180111.113203.1899608306187914852.davem@davemloft.net>
Hello,
On Thu, 11 Jan 2018 11:32:03 -0500 (EST), David Miller wrote:
> From: David Miller <davem@davemloft.net>
> Date: Thu, 11 Jan 2018 11:23:37 -0500 (EST)
>
> > From: Antoine Tenart <antoine.tenart@free-electrons.com>
> > Date: Wed, 10 Jan 2018 16:58:04 +0100
> >
> >> This series adds 1000BaseX and 2500BaseX support to the Marvell PPv2
> >> driver. In order to use it, the 2.5 SGMII mode is added in the Marvell
> >> common PHY driver (cp110-comphy).
> >
> > Series applied, thank you.
>
> Actually, this introduced build warnings, I'm reverting. Please fix this
> and repost.
>
> Thank you.
>
> drivers/net/ethernet/marvell/mvpp2.c: In function ‘mvpp2_port_mii_gmac_configure_mode’:
> drivers/net/ethernet/marvell/mvpp2.c:4687:26: warning: suggest parentheses around comparison in operand of ‘|’ [-Wparentheses]
> if (port->phy_interface == PHY_INTERFACE_MODE_1000BASEX |
> ~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
This is actually a very good warning: it should be a || and not |.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2018-01-11 16:36 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-10 15:58 [PATCH net-next v4 0/4] net: mvpp2: 1000BaseX and 2500BaseX support Antoine Tenart
2018-01-10 15:58 ` Antoine Tenart
2018-01-10 15:58 ` Antoine Tenart
2018-01-10 15:58 ` [PATCH net-next v4 1/4] phy: add 2.5G SGMII mode to the phy_mode enum Antoine Tenart
2018-01-10 15:58 ` Antoine Tenart
2018-01-10 15:58 ` Antoine Tenart
2018-01-10 15:58 ` [PATCH net-next v4 2/4] phy: cp110-comphy: 2.5G SGMII mode Antoine Tenart
2018-01-10 15:58 ` Antoine Tenart
2018-01-10 15:58 ` Antoine Tenart
2018-01-10 15:58 ` [PATCH net-next v4 3/4] net: mvpp2: 1000baseX support Antoine Tenart
2018-01-10 15:58 ` Antoine Tenart
2018-01-10 15:58 ` [PATCH net-next v4 4/4] net: mvpp2: 2500baseX support Antoine Tenart
2018-01-10 15:58 ` Antoine Tenart
2018-01-11 16:23 ` [PATCH net-next v4 0/4] net: mvpp2: 1000BaseX and 2500BaseX support David Miller
2018-01-11 16:23 ` David Miller
2018-01-11 16:32 ` David Miller
2018-01-11 16:32 ` David Miller
2018-01-11 16:36 ` Thomas Petazzoni [this message]
2018-01-11 16:36 ` Thomas Petazzoni
2018-01-12 7:30 ` Antoine Tenart
2018-01-12 7:30 ` Antoine Tenart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180111173629.5d682190@windsurf.lan \
--to=thomas.petazzoni@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.