All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Jason Gunthorpe <jgg-uk2M96/98Pc@public.gmane.org>
Cc: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	RDMA mailing list
	<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	Mark Bloch <markb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
	Parav Pandit <parav-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
	Dasaratharaman Chandramouli
	<dasaratharaman.chandramouli-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	Don Hiatt <don.hiatt-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	Ira Weiny <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH rdma-next 4/6] RDMA/{cma, ucma}: Refactor to have transport specific checks
Date: Thu, 11 Jan 2018 20:50:04 +0200	[thread overview]
Message-ID: <20180111185004.GD15760@mtr-leonro.local> (raw)
In-Reply-To: <20180111165622.GB1309-uk2M96/98Pc@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 817 bytes --]

On Thu, Jan 11, 2018 at 09:56:22AM -0700, Jason Gunthorpe wrote:
> On Thu, Jan 11, 2018 at 08:05:37AM +0200, Leon Romanovsky wrote:
>
> > > If anything should be fixed here, it is to move the degradation closer
> > > to the actual copy_to_user.
> > >
> > > Why was it put here anyhow? I don't see a uapi boundary?
>
> Actually, looking again, in the morning, it seems placed OK. This is
> about as close to the copy_to_user as possible in this flow..

So, are you going to pick up?

>
> > As Parav wrote, it was added in commit 57520751445b ("IB/SA: Add OPA
> > path record type") and it looks like this sa_convert_path_ib_to_opa()
> > can be deleted, because there is the same conversion in ucma_query_path().
>
> ucma_path_query is OK, the sa_convert_path_opa_to_ib is directly before
> the copy_to_user.
>
> Jason

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  parent reply	other threads:[~2018-01-11 18:50 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-08 15:04 [PATCH rdma-next 0/6] RoCE Path Record refactoring Leon Romanovsky
     [not found] ` <20180108150448.29069-1-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2018-01-08 15:04   ` [PATCH rdma-next 1/6] RDMA/cma: Use the net namespace of the rdma_cm_id Leon Romanovsky
     [not found]     ` <20180108150448.29069-2-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2018-01-19  8:38       ` Knut Omang
2018-01-08 15:04   ` [PATCH rdma-next 2/6] RDMA/cma: Provide function to set RoCE path record L2 parameters Leon Romanovsky
2018-01-08 15:04   ` [PATCH rdma-next 3/6] RDMA/{cma, ucma}: Simplify and rename rdma_set_ib_paths Leon Romanovsky
2018-01-08 15:04   ` [PATCH rdma-next 4/6] RDMA/{cma, ucma}: Refactor to have transport specific checks Leon Romanovsky
     [not found]     ` <20180108150448.29069-5-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2018-01-10 23:37       ` Jason Gunthorpe
     [not found]         ` <20180110233748.GS4518-uk2M96/98Pc@public.gmane.org>
2018-01-11  0:55           ` Parav Pandit
2018-01-11  6:05           ` Leon Romanovsky
     [not found]             ` <20180111060537.GO7368-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2018-01-11 16:56               ` Jason Gunthorpe
     [not found]                 ` <20180111165622.GB1309-uk2M96/98Pc@public.gmane.org>
2018-01-11 18:50                   ` Leon Romanovsky [this message]
     [not found]                     ` <20180111185004.GD15760-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2018-01-11 18:53                       ` Jason Gunthorpe
2018-01-08 15:04   ` [PATCH rdma-next 5/6] RDMA/cma: Fix setting RoCE specific path record fields Leon Romanovsky
     [not found]     ` <20180108150448.29069-6-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2018-01-11  5:04       ` Jason Gunthorpe
     [not found]         ` <20180111050453.GB16668-uk2M96/98Pc@public.gmane.org>
2018-01-11 13:57           ` Parav Pandit
2018-01-08 15:04   ` [PATCH rdma-next 6/6] RDMA/cma: Fix returning correct path record entry for RoCE Leon Romanovsky
2018-01-11  0:20   ` [PATCH rdma-next 0/6] RoCE Path Record refactoring Jason Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180111185004.GD15760@mtr-leonro.local \
    --to=leon-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
    --cc=dasaratharaman.chandramouli-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=don.hiatt-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=jgg-uk2M96/98Pc@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=markb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=parav-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.