From: Jason Gunthorpe <jgg-uk2M96/98Pc@public.gmane.org>
To: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
RDMA mailing list
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Mark Bloch <markb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
Parav Pandit <parav-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
Dasaratharaman Chandramouli
<dasaratharaman.chandramouli-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Don Hiatt <don.hiatt-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Ira Weiny <ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH rdma-next 4/6] RDMA/{cma, ucma}: Refactor to have transport specific checks
Date: Thu, 11 Jan 2018 11:53:04 -0700 [thread overview]
Message-ID: <20180111185304.GD1309@ziepe.ca> (raw)
In-Reply-To: <20180111185004.GD15760-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
On Thu, Jan 11, 2018 at 08:50:04PM +0200, Leon Romanovsky wrote:
> On Thu, Jan 11, 2018 at 09:56:22AM -0700, Jason Gunthorpe wrote:
> > On Thu, Jan 11, 2018 at 08:05:37AM +0200, Leon Romanovsky wrote:
> >
> > > > If anything should be fixed here, it is to move the degradation closer
> > > > to the actual copy_to_user.
> > > >
> > > > Why was it put here anyhow? I don't see a uapi boundary?
> >
> > Actually, looking again, in the morning, it seems placed OK. This is
> > about as close to the copy_to_user as possible in this flow..
>
> So, are you going to pick up?
I ment the current code is OK as is and the sa_covert_path is as close
to the copy_to/from_user as it can be.
What is wrong about this patch is moving the uapi translation further from
the uapi boundary. So still dropped.
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-01-11 18:53 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-08 15:04 [PATCH rdma-next 0/6] RoCE Path Record refactoring Leon Romanovsky
[not found] ` <20180108150448.29069-1-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2018-01-08 15:04 ` [PATCH rdma-next 1/6] RDMA/cma: Use the net namespace of the rdma_cm_id Leon Romanovsky
[not found] ` <20180108150448.29069-2-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2018-01-19 8:38 ` Knut Omang
2018-01-08 15:04 ` [PATCH rdma-next 2/6] RDMA/cma: Provide function to set RoCE path record L2 parameters Leon Romanovsky
2018-01-08 15:04 ` [PATCH rdma-next 3/6] RDMA/{cma, ucma}: Simplify and rename rdma_set_ib_paths Leon Romanovsky
2018-01-08 15:04 ` [PATCH rdma-next 4/6] RDMA/{cma, ucma}: Refactor to have transport specific checks Leon Romanovsky
[not found] ` <20180108150448.29069-5-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2018-01-10 23:37 ` Jason Gunthorpe
[not found] ` <20180110233748.GS4518-uk2M96/98Pc@public.gmane.org>
2018-01-11 0:55 ` Parav Pandit
2018-01-11 6:05 ` Leon Romanovsky
[not found] ` <20180111060537.GO7368-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2018-01-11 16:56 ` Jason Gunthorpe
[not found] ` <20180111165622.GB1309-uk2M96/98Pc@public.gmane.org>
2018-01-11 18:50 ` Leon Romanovsky
[not found] ` <20180111185004.GD15760-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org>
2018-01-11 18:53 ` Jason Gunthorpe [this message]
2018-01-08 15:04 ` [PATCH rdma-next 5/6] RDMA/cma: Fix setting RoCE specific path record fields Leon Romanovsky
[not found] ` <20180108150448.29069-6-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2018-01-11 5:04 ` Jason Gunthorpe
[not found] ` <20180111050453.GB16668-uk2M96/98Pc@public.gmane.org>
2018-01-11 13:57 ` Parav Pandit
2018-01-08 15:04 ` [PATCH rdma-next 6/6] RDMA/cma: Fix returning correct path record entry for RoCE Leon Romanovsky
2018-01-11 0:20 ` [PATCH rdma-next 0/6] RoCE Path Record refactoring Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180111185304.GD1309@ziepe.ca \
--to=jgg-uk2m96/98pc@public.gmane.org \
--cc=dasaratharaman.chandramouli-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=don.hiatt-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=markb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=parav-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.