All of lore.kernel.org
 help / color / mirror / Atom feed
From: Theodore Ts'o <tytso@mit.edu>
To: Jan Kara <jack@suse.cz>
Cc: Colin King <colin.king@canonical.com>,
	Andreas Dilger <adilger.kernel@dilger.ca>,
	linux-ext4@vger.kernel.org, kernel-janitors@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ext4: fix incorrect indentation of if statement
Date: Thu, 11 Jan 2018 19:18:10 +0000	[thread overview]
Message-ID: <20180111191810.GF19241@thunk.org> (raw)
In-Reply-To: <20180104154018.GB2170@quack2.suse.cz>

On Thu, Jan 04, 2018 at 04:40:18PM +0100, Jan Kara wrote:
> On Wed 29-11-17 14:20:59, Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> > 
> > The indentation is incorrect and spaces need replacing with a tab
> > on the if statement.
> > 
> > Cleans up smatch warning:
> > fs/ext4/namei.c:3220 ext4_link() warn: inconsistent indenting
> > 
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
> 
> This seems to fall through cracks. The patch looks good. You can add:
> 
> Reviewed-by: Jan Kara <jack@suse.cz>

Thanks, applied.  There was actually another whitespace issue on the
following line, which I've fixed up and merged into this patch.

	  	      	   	    	- Ted

WARNING: multiple messages have this Message-ID (diff)
From: Theodore Ts'o <tytso@mit.edu>
To: Jan Kara <jack@suse.cz>
Cc: Colin King <colin.king@canonical.com>,
	Andreas Dilger <adilger.kernel@dilger.ca>,
	linux-ext4@vger.kernel.org, kernel-janitors@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ext4: fix incorrect indentation of if statement
Date: Thu, 11 Jan 2018 14:18:10 -0500	[thread overview]
Message-ID: <20180111191810.GF19241@thunk.org> (raw)
In-Reply-To: <20180104154018.GB2170@quack2.suse.cz>

On Thu, Jan 04, 2018 at 04:40:18PM +0100, Jan Kara wrote:
> On Wed 29-11-17 14:20:59, Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> > 
> > The indentation is incorrect and spaces need replacing with a tab
> > on the if statement.
> > 
> > Cleans up smatch warning:
> > fs/ext4/namei.c:3220 ext4_link() warn: inconsistent indenting
> > 
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
> 
> This seems to fall through cracks. The patch looks good. You can add:
> 
> Reviewed-by: Jan Kara <jack@suse.cz>

Thanks, applied.  There was actually another whitespace issue on the
following line, which I've fixed up and merged into this patch.

	  	      	   	    	- Ted

  reply	other threads:[~2018-01-11 19:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-29 14:20 [PATCH] ext4: fix incorrect indentation of if statement Colin King
2018-01-04 15:40 ` Jan Kara
2018-01-04 15:40   ` Jan Kara
2018-01-11 19:18   ` Theodore Ts'o [this message]
2018-01-11 19:18     ` Theodore Ts'o

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180111191810.GF19241@thunk.org \
    --to=tytso@mit.edu \
    --cc=adilger.kernel@dilger.ca \
    --cc=colin.king@canonical.com \
    --cc=jack@suse.cz \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.