From: Andrew Lunn <andrew@lunn.ch>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Jae Hyun Yoo <jae.hyun.yoo@linux.intel.com>,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
jdelvare@suse.com, arnd@arndb.de, linux-doc@vger.kernel.org,
andrew@aj.id.au, gregkh@linuxfoundation.org,
openbmc@lists.ozlabs.org, linux-kernel@vger.kernel.org,
joel@jms.id.au, linux-arm-kernel@lists.infradead.org
Subject: Re: [linux, dev-4.10, 6/6] drivers/hwmon: Add a driver for a generic PECI hwmon
Date: Thu, 11 Jan 2018 23:18:45 +0100 [thread overview]
Message-ID: <20180111221845.GA9278@lunn.ch> (raw)
In-Reply-To: <20180111214035.GA14748@roeck-us.net>
> > >>+static const struct of_device_id peci_of_table[] = {
> > >>+ { .compatible = "peci-hwmon", },
> > >
> > >This does not look like a reference to some piece of hardware.
> > >
> >
> > This driver provides generic PECI hwmon function to which controller has
> > PECI HW such as Aspeed or Nuvoton BMC chip so it's not dependant on a
> > specific hardware. Should I remove this or any suggestion?
PECI seems to be an Intel thing. So at least it should be
{ .compatible = "intel,peci-hwmon", }
assuming it is actually compatible with the Intel specification.
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [linux, dev-4.10, 6/6] drivers/hwmon: Add a driver for a generic PECI hwmon
Date: Thu, 11 Jan 2018 23:18:45 +0100 [thread overview]
Message-ID: <20180111221845.GA9278@lunn.ch> (raw)
In-Reply-To: <20180111214035.GA14748@roeck-us.net>
> > >>+static const struct of_device_id peci_of_table[] = {
> > >>+ { .compatible = "peci-hwmon", },
> > >
> > >This does not look like a reference to some piece of hardware.
> > >
> >
> > This driver provides generic PECI hwmon function to which controller has
> > PECI HW such as Aspeed or Nuvoton BMC chip so it's not dependant on a
> > specific hardware. Should I remove this or any suggestion?
PECI seems to be an Intel thing. So at least it should be
{ .compatible = "intel,peci-hwmon", }
assuming it is actually compatible with the Intel specification.
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>
To: Guenter Roeck <linux-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
Cc: Jae Hyun Yoo
<jae.hyun.yoo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
linux-hwmon-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
jdelvare-IBi9RG/b67k@public.gmane.org,
arnd-r2nGTMty4D4@public.gmane.org,
linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
andrew-zrmu5oMJ5Fs@public.gmane.org,
gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org,
openbmc-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
joel-U3u1mxZcP9KHXe+LvDLADg@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [linux, dev-4.10, 6/6] drivers/hwmon: Add a driver for a generic PECI hwmon
Date: Thu, 11 Jan 2018 23:18:45 +0100 [thread overview]
Message-ID: <20180111221845.GA9278@lunn.ch> (raw)
In-Reply-To: <20180111214035.GA14748-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
> > >>+static const struct of_device_id peci_of_table[] = {
> > >>+ { .compatible = "peci-hwmon", },
> > >
> > >This does not look like a reference to some piece of hardware.
> > >
> >
> > This driver provides generic PECI hwmon function to which controller has
> > PECI HW such as Aspeed or Nuvoton BMC chip so it's not dependant on a
> > specific hardware. Should I remove this or any suggestion?
PECI seems to be an Intel thing. So at least it should be
{ .compatible = "intel,peci-hwmon", }
assuming it is actually compatible with the Intel specification.
Andrew
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-01-11 22:18 UTC|newest]
Thread overview: 112+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-09 22:31 [PATCH linux dev-4.10 0/6] Add support PECI and PECI hwmon drivers Jae Hyun Yoo
2018-01-09 22:31 ` Jae Hyun Yoo
2018-01-09 22:31 ` Jae Hyun Yoo
2018-01-09 22:31 ` [PATCH linux dev-4.10 1/6] Documentation: dt-bindings: Add Aspeed PECI Jae Hyun Yoo
2018-01-09 22:31 ` Jae Hyun Yoo
2018-01-09 22:31 ` [PATCH linux dev-4.10 2/6] ARM: dts: aspeed: peci: " Jae Hyun Yoo
2018-01-09 22:31 ` Jae Hyun Yoo
2018-01-09 22:31 ` [PATCH linux dev-4.10 3/6] drivers/misc: Add driver for Aspeed PECI and generic PECI headers Jae Hyun Yoo
2018-01-09 22:31 ` Jae Hyun Yoo
2018-01-09 22:31 ` Jae Hyun Yoo
2018-01-10 10:18 ` Greg KH
2018-01-10 10:18 ` Greg KH
2018-01-10 10:18 ` Greg KH
2018-01-10 19:32 ` Jae Hyun Yoo
2018-01-10 19:32 ` Jae Hyun Yoo
2018-01-11 9:02 ` Benjamin Herrenschmidt
2018-01-11 9:02 ` Benjamin Herrenschmidt
2018-01-11 9:02 ` Benjamin Herrenschmidt
2018-01-11 20:33 ` Jae Hyun Yoo
2018-01-11 20:33 ` Jae Hyun Yoo
2018-01-10 10:20 ` Greg KH
2018-01-10 10:20 ` Greg KH
2018-01-10 10:20 ` Greg KH
2018-01-10 19:34 ` Jae Hyun Yoo
2018-01-10 19:34 ` Jae Hyun Yoo
2018-01-10 11:55 ` Arnd Bergmann
2018-01-10 11:55 ` Arnd Bergmann
2018-01-10 23:11 ` Jae Hyun Yoo
2018-01-10 23:11 ` Jae Hyun Yoo
2018-01-11 9:06 ` Benjamin Herrenschmidt
2018-01-11 9:06 ` Benjamin Herrenschmidt
2018-01-11 9:06 ` Benjamin Herrenschmidt
2018-01-11 20:42 ` Jae Hyun Yoo
2018-01-11 20:42 ` Jae Hyun Yoo
2018-01-11 20:42 ` Jae Hyun Yoo
2018-01-09 22:31 ` [PATCH linux dev-4.10 4/6] Documentation: dt-bindings: Add a generic PECI hwmon Jae Hyun Yoo
2018-01-09 22:31 ` Jae Hyun Yoo
2018-01-10 12:20 ` Arnd Bergmann
2018-01-10 12:20 ` Arnd Bergmann
2018-01-10 23:20 ` Jae Hyun Yoo
2018-01-10 23:20 ` Jae Hyun Yoo
2018-01-09 22:31 ` [PATCH linux dev-4.10 5/6] Documentation: hwmon: " Jae Hyun Yoo
2018-01-09 22:31 ` Jae Hyun Yoo
2018-01-09 22:31 ` Jae Hyun Yoo
2018-01-09 22:31 ` [PATCH linux dev-4.10 6/6] drivers/hwmon: Add a driver for " Jae Hyun Yoo
2018-01-09 22:31 ` Jae Hyun Yoo
2018-01-10 12:29 ` Arnd Bergmann
2018-01-10 12:29 ` Arnd Bergmann
2018-01-10 23:45 ` Jae Hyun Yoo
2018-01-10 23:45 ` Jae Hyun Yoo
2018-01-11 13:22 ` Arnd Bergmann
2018-01-11 13:22 ` Arnd Bergmann
2018-01-11 20:49 ` Jae Hyun Yoo
2018-01-11 20:49 ` Jae Hyun Yoo
2018-01-10 21:47 ` [linux, dev-4.10, " Guenter Roeck
2018-01-10 21:47 ` Guenter Roeck
2018-01-11 19:47 ` Jae Hyun Yoo
2018-01-11 19:47 ` Jae Hyun Yoo
2018-01-11 19:47 ` Jae Hyun Yoo
2018-01-11 21:40 ` Guenter Roeck
2018-01-11 21:40 ` Guenter Roeck
2018-01-11 22:18 ` Andrew Lunn [this message]
2018-01-11 22:18 ` Andrew Lunn
2018-01-11 22:18 ` Andrew Lunn
2018-01-11 23:14 ` Jae Hyun Yoo
2018-01-11 23:14 ` Jae Hyun Yoo
2018-01-11 23:53 ` Andrew Lunn
2018-01-11 23:53 ` Andrew Lunn
2018-01-12 0:26 ` Jae Hyun Yoo
2018-01-12 0:26 ` Jae Hyun Yoo
2018-01-11 23:03 ` Jae Hyun Yoo
2018-01-11 23:03 ` Jae Hyun Yoo
2018-01-11 23:03 ` Jae Hyun Yoo
2018-01-10 10:17 ` [PATCH linux dev-4.10 0/6] Add support PECI and PECI hwmon drivers Greg KH
2018-01-10 10:17 ` Greg KH
2018-01-10 10:17 ` Greg KH
2018-01-10 19:14 ` Jae Hyun Yoo
2018-01-10 19:14 ` Jae Hyun Yoo
2018-01-10 19:17 ` Greg KH
2018-01-10 19:17 ` Greg KH
2018-01-10 19:17 ` Greg KH
2018-01-10 19:30 ` Jae Hyun Yoo
2018-01-10 19:30 ` Jae Hyun Yoo
2018-01-10 20:27 ` Greg KH
2018-01-10 20:27 ` Greg KH
2018-01-10 20:27 ` Greg KH
2018-01-10 21:46 ` Jae Hyun Yoo
2018-01-10 21:46 ` Jae Hyun Yoo
2018-01-10 21:46 ` Jae Hyun Yoo
2018-01-11 7:30 ` Greg KH
2018-01-11 7:30 ` Greg KH
2018-01-11 8:28 ` Joel Stanley
2018-01-11 8:28 ` Joel Stanley
2018-01-11 8:41 ` Greg KH
2018-01-11 8:41 ` Greg KH
2018-01-11 8:41 ` Greg KH
2018-01-11 9:17 ` Arnd Bergmann
2018-01-11 9:17 ` Arnd Bergmann
2018-01-11 9:17 ` Arnd Bergmann
2018-01-11 9:21 ` Benjamin Herrenschmidt
2018-01-11 9:21 ` Benjamin Herrenschmidt
2018-01-11 9:21 ` Benjamin Herrenschmidt
2018-01-11 8:56 ` Benjamin Herrenschmidt
2018-01-11 8:56 ` Benjamin Herrenschmidt
2018-01-11 9:59 ` Greg KH
2018-01-11 9:59 ` Greg KH
2018-01-11 9:59 ` Greg KH
2018-01-11 20:49 ` Benjamin Herrenschmidt
2018-01-11 20:49 ` Benjamin Herrenschmidt
2018-01-11 20:49 ` Benjamin Herrenschmidt
2018-01-11 19:54 ` Jae Hyun Yoo
2018-01-11 19:54 ` Jae Hyun Yoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180111221845.GA9278@lunn.ch \
--to=andrew@lunn.ch \
--cc=andrew@aj.id.au \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jae.hyun.yoo@linux.intel.com \
--cc=jdelvare@suse.com \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=openbmc@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.