From: Brian Norris <briannorris@chromium.org>
To: Marc Dietrich <marvin24@gmx.de>
Cc: Heiko Stuebner <heiko@sntech.de>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
linux-tegra@vger.kernel.org, Lin Huang <hl@rock-chips.com>
Subject: Re: [PATCH 2/3] ARM: tegra: paz00: drop nonstandard 'backlight-boot-off'
Date: Thu, 11 Jan 2018 18:18:02 -0800 [thread overview]
Message-ID: <20180112021801.GA243980@google.com> (raw)
In-Reply-To: <27065017.X8cFkIFnZg@fb07-iapwap2>
On Wed, Jan 10, 2018 at 12:31:31PM +0100, Marc Dietrich wrote:
> Hi,
>
> Am Samstag, 6. Januar 2018, 01:47:56 CET schrieb Brian Norris:
> > This was used out-of-tree as a hack for resolving issues where some
> > systems expect the backlight to turn on automatically at boot, while
> > others expect to manage the backlight status via a DRM/panel driver.
> > Those issues have since been fixed upstream in pwm_bl.c without device
> > tree hacks, and so this un-documented property should no longer be
> > useful.
> >
> > Signed-off-by: Brian Norris <briannorris@chromium.org>
>
> seems to work again. Thanks!
BTW, I guess I could have put this in the commit message, but the
problem that this out-of-tree property was trying to resolve was fixed
by this (and some other related patches):
d1b812945750 backlight: pwm_bl: Check the PWM state for initial backlight power state
Brian
> Reviewed-by: Marc Dietrich <marvin24@gmx.de>
>
> > ---
> > arch/arm/boot/dts/tegra20-paz00.dts | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/tegra20-paz00.dts
> > b/arch/arm/boot/dts/tegra20-paz00.dts index 30436969adc0..12c63b23ed5e
> > 100644
> > --- a/arch/arm/boot/dts/tegra20-paz00.dts
> > +++ b/arch/arm/boot/dts/tegra20-paz00.dts
> > @@ -504,8 +504,6 @@
> >
> > brightness-levels = <0 16 32 48 64 80 96 112 128 144 160 176 192 208 224
> > 240 255>; default-brightness-level = <10>;
> > -
> > - backlight-boot-off;
> > };
> >
> > clocks {
>
WARNING: multiple messages have this Message-ID (diff)
From: briannorris@chromium.org (Brian Norris)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] ARM: tegra: paz00: drop nonstandard 'backlight-boot-off'
Date: Thu, 11 Jan 2018 18:18:02 -0800 [thread overview]
Message-ID: <20180112021801.GA243980@google.com> (raw)
In-Reply-To: <27065017.X8cFkIFnZg@fb07-iapwap2>
On Wed, Jan 10, 2018 at 12:31:31PM +0100, Marc Dietrich wrote:
> Hi,
>
> Am Samstag, 6. Januar 2018, 01:47:56 CET schrieb Brian Norris:
> > This was used out-of-tree as a hack for resolving issues where some
> > systems expect the backlight to turn on automatically at boot, while
> > others expect to manage the backlight status via a DRM/panel driver.
> > Those issues have since been fixed upstream in pwm_bl.c without device
> > tree hacks, and so this un-documented property should no longer be
> > useful.
> >
> > Signed-off-by: Brian Norris <briannorris@chromium.org>
>
> seems to work again. Thanks!
BTW, I guess I could have put this in the commit message, but the
problem that this out-of-tree property was trying to resolve was fixed
by this (and some other related patches):
d1b812945750 backlight: pwm_bl: Check the PWM state for initial backlight power state
Brian
> Reviewed-by: Marc Dietrich <marvin24@gmx.de>
>
> > ---
> > arch/arm/boot/dts/tegra20-paz00.dts | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/tegra20-paz00.dts
> > b/arch/arm/boot/dts/tegra20-paz00.dts index 30436969adc0..12c63b23ed5e
> > 100644
> > --- a/arch/arm/boot/dts/tegra20-paz00.dts
> > +++ b/arch/arm/boot/dts/tegra20-paz00.dts
> > @@ -504,8 +504,6 @@
> >
> > brightness-levels = <0 16 32 48 64 80 96 112 128 144 160 176 192 208 224
> > 240 255>; default-brightness-level = <10>;
> > -
> > - backlight-boot-off;
> > };
> >
> > clocks {
>
next prev parent reply other threads:[~2018-01-12 2:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-06 0:47 [PATCH 1/3] ARM: dts: rockchip: drop veyron's nonstandard 'backlight-boot-off' Brian Norris
2018-01-06 0:47 ` Brian Norris
2018-01-06 0:47 ` Brian Norris
2018-01-06 0:47 ` [PATCH 2/3] ARM: tegra: paz00: drop " Brian Norris
2018-01-06 0:47 ` Brian Norris
2018-01-06 0:47 ` Brian Norris
2018-01-10 11:31 ` Marc Dietrich
2018-01-10 11:31 ` Marc Dietrich
2018-01-12 2:18 ` Brian Norris [this message]
2018-01-12 2:18 ` Brian Norris
2018-01-06 0:47 ` [PATCH 3/3] arm64: tegra: remove tegra132 norrin's " Brian Norris
2018-01-06 0:47 ` Brian Norris
2018-01-06 0:47 ` Brian Norris
[not found] ` <20180106004757.8239-1-briannorris-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
2018-01-13 18:49 ` [PATCH 1/3] ARM: dts: rockchip: drop veyron's " Heiko Stuebner
2018-01-13 18:49 ` Heiko Stuebner
2018-01-13 18:49 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180112021801.GA243980@google.com \
--to=briannorris@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=hl@rock-chips.com \
--cc=jonathanh@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-tegra@vger.kernel.org \
--cc=marvin24@gmx.de \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.