From: Florian Westphal <fw@strlen.de>
To: Subash Abhinov Kasiviswanathan <subashab@codeaurora.org>
Cc: pablo@netfilter.org, netfilter-devel@vger.kernel.org, fw@strlen.de
Subject: Re: [PATCH nf-next] netfilter: ipv6: nf_defrag: Always pass on packets to stack
Date: Fri, 12 Jan 2018 07:35:52 +0100 [thread overview]
Message-ID: <20180112063552.GA27085@breakpoint.cc> (raw)
In-Reply-To: <1515737073-32344-2-git-send-email-subashab@codeaurora.org>
Subash Abhinov Kasiviswanathan <subashab@codeaurora.org> wrote:
> diff --git a/net/ipv6/netfilter/nf_conntrack_reasm.c b/net/ipv6/netfilter/nf_conntrack_reasm.c
> index 977d890..a44c8b2 100644
> --- a/net/ipv6/netfilter/nf_conntrack_reasm.c
> +++ b/net/ipv6/netfilter/nf_conntrack_reasm.c
> @@ -574,17 +574,26 @@ int nf_ct_frag6_gather(struct net *net, struct sk_buff *skb, u32 user)
> struct ipv6hdr *hdr;
> u8 prevhdr;
>
> + skb = skb_clone(skb, GFP_ATOMIC);
> + if (!skb)
> + return -ENOMEM;
> +
> /* Jumbo payload inhibits frag. header */
> if (ipv6_hdr(skb)->payload_len == 0) {
> pr_debug("payload len = 0\n");
> + kfree(skb);
kfree_skb ?
next prev parent reply other threads:[~2018-01-12 6:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-12 6:04 [PATCH nf-next] netfilter: nf_defrag: Fix compiler errors Subash Abhinov Kasiviswanathan
2018-01-12 6:04 ` [PATCH nf-next] netfilter: ipv6: nf_defrag: Always pass on packets to stack Subash Abhinov Kasiviswanathan
2018-01-12 6:35 ` Florian Westphal [this message]
2018-01-12 7:55 ` Subash Abhinov Kasiviswanathan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180112063552.GA27085@breakpoint.cc \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=subashab@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.