Re: [PATCH nf-next] netfilter: ipv6: nf_defrag: Always pass on packets to stack

[Subash Abhinov Kasiviswanathan <subashab@codeaurora.org>]

On 2018-01-11 23:35, Florian Westphal wrote:
> Subash Abhinov Kasiviswanathan <subashab@codeaurora.org> wrote:
>> diff --git a/net/ipv6/netfilter/nf_conntrack_reasm.c 
>> b/net/ipv6/netfilter/nf_conntrack_reasm.c
>> index 977d890..a44c8b2 100644
>> --- a/net/ipv6/netfilter/nf_conntrack_reasm.c
>> +++ b/net/ipv6/netfilter/nf_conntrack_reasm.c
>> @@ -574,17 +574,26 @@ int nf_ct_frag6_gather(struct net *net, struct 
>> sk_buff *skb, u32 user)
>>  	struct ipv6hdr *hdr;
>>  	u8 prevhdr;
>> 
>> +	skb = skb_clone(skb, GFP_ATOMIC);
>> +	if (!skb)
>> +		return -ENOMEM;
>> +
>>  	/* Jumbo payload inhibits frag. header */
>>  	if (ipv6_hdr(skb)->payload_len == 0) {
>>  		pr_debug("payload len = 0\n");
>> +		kfree(skb);
> 
> kfree_skb ?

Hi Florian

Yes, it should have been kfree_skb(skb) in all the instances.
I will update it in v2.
-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project