All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH net-next] mlxsw: spectrum: qdiscs: Make function mlxsw_sp_qdisc_prio_unoffload static
@ 2018-01-15 10:43 ` Wei Yongjun
  0 siblings, 0 replies; 6+ messages in thread
From: Wei Yongjun @ 2018-01-15 10:43 UTC (permalink / raw)
  To: Jiri Pirko, Ido Schimmel; +Cc: Wei Yongjun, netdev, kernel-janitors

Fixes the following sparse warning:

drivers/net/ethernet/mellanox/mlxsw/spectrum_qdisc.c:464:1: warning:
 symbol 'mlxsw_sp_qdisc_prio_unoffload' was not declared. Should it be static?

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 drivers/net/ethernet/mellanox/mlxsw/spectrum_qdisc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_qdisc.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_qdisc.c
index e11a0ab..fee9da8 100644
--- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_qdisc.c
+++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_qdisc.c
@@ -460,7 +460,7 @@ int mlxsw_sp_setup_tc_red(struct mlxsw_sp_port *mlxsw_sp_port,
 	return 0;
 }
 
-void
+static void
 mlxsw_sp_qdisc_prio_unoffload(struct mlxsw_sp_port *mlxsw_sp_port,
 			      struct mlxsw_sp_qdisc *mlxsw_sp_qdisc,
 			      void *params)


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH net-next] mlxsw: spectrum: qdiscs: Make function mlxsw_sp_qdisc_prio_unoffload static
@ 2018-01-15 10:43 ` Wei Yongjun
  0 siblings, 0 replies; 6+ messages in thread
From: Wei Yongjun @ 2018-01-15 10:43 UTC (permalink / raw)
  To: Jiri Pirko, Ido Schimmel; +Cc: Wei Yongjun, netdev, kernel-janitors

Fixes the following sparse warning:

drivers/net/ethernet/mellanox/mlxsw/spectrum_qdisc.c:464:1: warning:
 symbol 'mlxsw_sp_qdisc_prio_unoffload' was not declared. Should it be static?

Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 drivers/net/ethernet/mellanox/mlxsw/spectrum_qdisc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_qdisc.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_qdisc.c
index e11a0ab..fee9da8 100644
--- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_qdisc.c
+++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_qdisc.c
@@ -460,7 +460,7 @@ int mlxsw_sp_setup_tc_red(struct mlxsw_sp_port *mlxsw_sp_port,
 	return 0;
 }
 
-void
+static void
 mlxsw_sp_qdisc_prio_unoffload(struct mlxsw_sp_port *mlxsw_sp_port,
 			      struct mlxsw_sp_qdisc *mlxsw_sp_qdisc,
 			      void *params)


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH net-next] mlxsw: spectrum: qdiscs: Make function mlxsw_sp_qdisc_prio_unoffload static
  2018-01-15 10:43 ` Wei Yongjun
@ 2018-01-15 11:19   ` Jiri Pirko
  -1 siblings, 0 replies; 6+ messages in thread
From: Jiri Pirko @ 2018-01-15 11:19 UTC (permalink / raw)
  To: Wei Yongjun; +Cc: Jiri Pirko, Ido Schimmel, netdev, kernel-janitors

Mon, Jan 15, 2018 at 11:43:03AM CET, weiyongjun1@huawei.com wrote:
>Fixes the following sparse warning:
>
>drivers/net/ethernet/mellanox/mlxsw/spectrum_qdisc.c:464:1: warning:
> symbol 'mlxsw_sp_qdisc_prio_unoffload' was not declared. Should it be static?
>
>Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Jiri Pirko <jiri@mellanox.com>

Thanks.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH net-next] mlxsw: spectrum: qdiscs: Make function mlxsw_sp_qdisc_prio_unoffload static
@ 2018-01-15 11:19   ` Jiri Pirko
  0 siblings, 0 replies; 6+ messages in thread
From: Jiri Pirko @ 2018-01-15 11:19 UTC (permalink / raw)
  To: Wei Yongjun; +Cc: Jiri Pirko, Ido Schimmel, netdev, kernel-janitors

Mon, Jan 15, 2018 at 11:43:03AM CET, weiyongjun1@huawei.com wrote:
>Fixes the following sparse warning:
>
>drivers/net/ethernet/mellanox/mlxsw/spectrum_qdisc.c:464:1: warning:
> symbol 'mlxsw_sp_qdisc_prio_unoffload' was not declared. Should it be static?
>
>Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Jiri Pirko <jiri@mellanox.com>

Thanks.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH net-next] mlxsw: spectrum: qdiscs: Make function mlxsw_sp_qdisc_prio_unoffload static
  2018-01-15 10:43 ` Wei Yongjun
@ 2018-01-16 19:27   ` David Miller
  -1 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2018-01-16 19:27 UTC (permalink / raw)
  To: weiyongjun1; +Cc: jiri, idosch, netdev, kernel-janitors

From: Wei Yongjun <weiyongjun1@huawei.com>
Date: Mon, 15 Jan 2018 10:43:03 +0000

> Fixes the following sparse warning:
> 
> drivers/net/ethernet/mellanox/mlxsw/spectrum_qdisc.c:464:1: warning:
>  symbol 'mlxsw_sp_qdisc_prio_unoffload' was not declared. Should it be static?
> 
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>

Applied.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH net-next] mlxsw: spectrum: qdiscs: Make function mlxsw_sp_qdisc_prio_unoffload static
@ 2018-01-16 19:27   ` David Miller
  0 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2018-01-16 19:27 UTC (permalink / raw)
  To: weiyongjun1; +Cc: jiri, idosch, netdev, kernel-janitors

From: Wei Yongjun <weiyongjun1@huawei.com>
Date: Mon, 15 Jan 2018 10:43:03 +0000

> Fixes the following sparse warning:
> 
> drivers/net/ethernet/mellanox/mlxsw/spectrum_qdisc.c:464:1: warning:
>  symbol 'mlxsw_sp_qdisc_prio_unoffload' was not declared. Should it be static?
> 
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>

Applied.

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2018-01-16 19:27 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-15 10:43 [PATCH net-next] mlxsw: spectrum: qdiscs: Make function mlxsw_sp_qdisc_prio_unoffload static Wei Yongjun
2018-01-15 10:43 ` Wei Yongjun
2018-01-15 11:19 ` Jiri Pirko
2018-01-15 11:19   ` Jiri Pirko
2018-01-16 19:27 ` David Miller
2018-01-16 19:27   ` David Miller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.