* [PATCH] modpost: Remove trailing semicolon
@ 2018-01-16 13:21 Luis de Bethencourt
2018-01-16 17:55 ` Kees Cook
2018-01-16 18:39 ` Jessica Yu
0 siblings, 2 replies; 3+ messages in thread
From: Luis de Bethencourt @ 2018-01-16 13:21 UTC (permalink / raw)
To: linux-kernel
Cc: Joe Perches, Jessica Yu, Kees Cook, Ingo Molnar, Ard Biesheuvel,
Luis de Bethencourt
The trailing semicolon is an empty statement that does no operation.
Removing it since it doesn't do anything.
Signed-off-by: Luis de Bethencourt <luisbg@kernel.org>
---
Hi,
After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches
suggested I fix it treewide [0].
Best regards
Luis
[0] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115410.html
[1] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115390.html
scripts/mod/modpost.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
index f51cf977c65b..49dfcd556c78 100644
--- a/scripts/mod/modpost.c
+++ b/scripts/mod/modpost.c
@@ -1685,7 +1685,7 @@ static void extable_mismatch_handler(const char* modname, struct elf_info *elf,
static void check_section_mismatch(const char *modname, struct elf_info *elf,
Elf_Rela *r, Elf_Sym *sym, const char *fromsec)
{
- const char *tosec = sec_name(elf, get_secindex(elf, sym));;
+ const char *tosec = sec_name(elf, get_secindex(elf, sym));
const struct sectioncheck *mismatch = section_mismatch(fromsec, tosec);
if (mismatch) {
--
2.15.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] modpost: Remove trailing semicolon
2018-01-16 13:21 [PATCH] modpost: Remove trailing semicolon Luis de Bethencourt
@ 2018-01-16 17:55 ` Kees Cook
2018-01-16 18:39 ` Jessica Yu
1 sibling, 0 replies; 3+ messages in thread
From: Kees Cook @ 2018-01-16 17:55 UTC (permalink / raw)
To: Luis de Bethencourt
Cc: LKML, Joe Perches, Jessica Yu, Ingo Molnar, Ard Biesheuvel
On Tue, Jan 16, 2018 at 5:21 AM, Luis de Bethencourt <luisbg@kernel.org> wrote:
> The trailing semicolon is an empty statement that does no operation.
> Removing it since it doesn't do anything.
>
> Signed-off-by: Luis de Bethencourt <luisbg@kernel.org>
Yup, good.
Signed-off-by: Kees Cook <keescook@chromium.org>
-Kees
> ---
>
> Hi,
>
> After fixing the same thing in drivers/staging/rtl8723bs/, Joe Perches
> suggested I fix it treewide [0].
>
> Best regards
> Luis
>
>
> [0] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115410.html
> [1] http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2018-January/115390.html
>
> scripts/mod/modpost.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
> index f51cf977c65b..49dfcd556c78 100644
> --- a/scripts/mod/modpost.c
> +++ b/scripts/mod/modpost.c
> @@ -1685,7 +1685,7 @@ static void extable_mismatch_handler(const char* modname, struct elf_info *elf,
> static void check_section_mismatch(const char *modname, struct elf_info *elf,
> Elf_Rela *r, Elf_Sym *sym, const char *fromsec)
> {
> - const char *tosec = sec_name(elf, get_secindex(elf, sym));;
> + const char *tosec = sec_name(elf, get_secindex(elf, sym));
> const struct sectioncheck *mismatch = section_mismatch(fromsec, tosec);
>
> if (mismatch) {
> --
> 2.15.1
>
--
Kees Cook
Pixel Security
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] modpost: Remove trailing semicolon
2018-01-16 13:21 [PATCH] modpost: Remove trailing semicolon Luis de Bethencourt
2018-01-16 17:55 ` Kees Cook
@ 2018-01-16 18:39 ` Jessica Yu
1 sibling, 0 replies; 3+ messages in thread
From: Jessica Yu @ 2018-01-16 18:39 UTC (permalink / raw)
To: Luis de Bethencourt
Cc: linux-kernel, Joe Perches, Kees Cook, Ingo Molnar, Ard Biesheuvel
+++ Luis de Bethencourt [16/01/18 13:21 +0000]:
>The trailing semicolon is an empty statement that does no operation.
>Removing it since it doesn't do anything.
>
>Signed-off-by: Luis de Bethencourt <luisbg@kernel.org>
Applied. Thanks,
Jessica
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-01-16 18:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-16 13:21 [PATCH] modpost: Remove trailing semicolon Luis de Bethencourt
2018-01-16 17:55 ` Kees Cook
2018-01-16 18:39 ` Jessica Yu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.