All of lore.kernel.org
 help / color / mirror / Atom feed
From: Archit Taneja <architt@codeaurora.org>
To: robdclark@gmail.com
Cc: linux-arm-msm@vger.kernel.org, latkinso@codeaurora.org,
	sibis@codeaurora.org, dri-devel@lists.freedesktop.org
Subject: [PATCH 1/7] drm/msm/dsi: Use msm_clk_get in dsi_get_config
Date: Wed, 17 Jan 2018 15:04:42 +0530	[thread overview]
Message-ID: <20180117093448.4102-2-architt@codeaurora.org> (raw)
In-Reply-To: <20180117093448.4102-1-architt@codeaurora.org>

We try to get the interface clock in dsi_get_config early during DSI's
component bind. Try getting both the "iface" and "iface_clk" clock name
variants so that we are compatible with both new and legacy DT.

Signed-off-by: Archit Taneja <architt@codeaurora.org>
---
 drivers/gpu/drm/msm/dsi/dsi_host.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/msm/dsi/dsi_host.c b/drivers/gpu/drm/msm/dsi/dsi_host.c
index 0f7324a686ca..7611fe014036 100644
--- a/drivers/gpu/drm/msm/dsi/dsi_host.c
+++ b/drivers/gpu/drm/msm/dsi/dsi_host.c
@@ -214,7 +214,7 @@ static const struct msm_dsi_cfg_handler *dsi_get_config(
 		goto exit;
 	}
 
-	ahb_clk = clk_get(dev, "iface_clk");
+	ahb_clk = msm_clk_get(msm_host->pdev, "iface");
 	if (IS_ERR(ahb_clk)) {
 		pr_err("%s: cannot get interface clock\n", __func__);
 		goto put_gdsc;
@@ -225,7 +225,7 @@ static const struct msm_dsi_cfg_handler *dsi_get_config(
 	ret = regulator_enable(gdsc_reg);
 	if (ret) {
 		pr_err("%s: unable to enable gdsc\n", __func__);
-		goto put_clk;
+		goto put_gdsc;
 	}
 
 	ret = clk_prepare_enable(ahb_clk);
@@ -249,8 +249,6 @@ static const struct msm_dsi_cfg_handler *dsi_get_config(
 disable_gdsc:
 	regulator_disable(gdsc_reg);
 	pm_runtime_put_sync(dev);
-put_clk:
-	clk_put(ahb_clk);
 put_gdsc:
 	regulator_put(gdsc_reg);
 exit:
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2018-01-17  9:34 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-17  9:34 [PATCH 0/7] drm/msm/dsi: SDM845 DSI host controller and DT updates Archit Taneja
2018-01-17  9:34 ` Archit Taneja [this message]
2018-01-17  9:34 ` [PATCH 2/7] drm/msm/dsi: Add SDM845 in dsi_cfg Archit Taneja
2018-01-17  9:34 ` [PATCH 3/7] drm/msm/dsi: Add byte_intf_clk Archit Taneja
2018-01-17  9:34 ` [PATCH 4/7] dt-bindings: display: msm/dsi: Remove unused properties Archit Taneja
2018-01-29 17:11   ` Rob Herring
2018-01-17  9:34 ` [PATCH 5/7] dt-bindings: display: msm/dsi: Fix the PHY regulator supply props Archit Taneja
     [not found]   ` <20180117093448.4102-6-architt-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2018-01-29 17:13     ` Rob Herring
2018-01-17  9:34 ` [PATCH 6/7] dt-bindings: display: msm/dsi: Add compatible for 14nm DSI PHY Archit Taneja
2018-01-29 17:15   ` Rob Herring
2018-01-31  6:40     ` Archit Taneja
2018-01-31 16:20       ` Rob Clark
     [not found]         ` <CAF6AEGsLrXBUub9Y5r-bTY2OPDksRSDjYpJXYoKxYp3MvHCP2w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-02-01  5:29           ` Archit Taneja
2018-02-01 14:41             ` Rob Herring
2018-01-17  9:34 ` [PATCH 7/7] dt-bindings: display: msm/dsi: Add updates for SDM845 Archit Taneja
2018-01-29 17:16   ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180117093448.4102-2-architt@codeaurora.org \
    --to=architt@codeaurora.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=latkinso@codeaurora.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=robdclark@gmail.com \
    --cc=sibis@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.