USB TYPEC: RT1711H Type-C Chip Driver

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Greg KH <greg@kroah.com>
To: ShuFanLee <leechu729@gmail.com>
Cc: heikki.krogerus@linux.intel.com, cy_huang@richtek.com,
	shufan_lee@richtek.com, linux-kernel@vger.kernel.org,
	linux-usb@vger.kernel.org
Subject: USB TYPEC: RT1711H Type-C Chip Driver
Date: Wed, 17 Jan 2018 14:33:59 +0100	[thread overview]
Message-ID: <20180117133359.GD3188@kroah.com> (raw)

On Wed, Jan 10, 2018 at 02:59:12PM +0800, ShuFanLee wrote:
> +static inline int rt1711h_reg_write_word(struct rt1711h_chip *chip, uint8_t reg,
> +	uint16_t data)
> +{
> +	data = cpu_to_le16(data);
> +	return rt1711h_reg_block_write(chip, reg, 2, (uint8_t *)&data);
> +}

Did you run sparse on this code?  What are you doing casting the types
all over the place for data?  That does not seem correct at all.

thanks,

greg k-h
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)

From: Greg KH <greg@kroah.com>
To: ShuFanLee <leechu729@gmail.com>
Cc: heikki.krogerus@linux.intel.com, cy_huang@richtek.com,
	shufan_lee@richtek.com, linux-kernel@vger.kernel.org,
	linux-usb@vger.kernel.org
Subject: Re: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver
Date: Wed, 17 Jan 2018 14:33:59 +0100	[thread overview]
Message-ID: <20180117133359.GD3188@kroah.com> (raw)
In-Reply-To: <1515567552-7692-1-git-send-email-leechu729@gmail.com>

On Wed, Jan 10, 2018 at 02:59:12PM +0800, ShuFanLee wrote:
> +static inline int rt1711h_reg_write_word(struct rt1711h_chip *chip, uint8_t reg,
> +	uint16_t data)
> +{
> +	data = cpu_to_le16(data);
> +	return rt1711h_reg_block_write(chip, reg, 2, (uint8_t *)&data);
> +}

Did you run sparse on this code?  What are you doing casting the types
all over the place for data?  That does not seem correct at all.

thanks,

greg k-h

next             reply	other threads:[~2018-01-17 13:33 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-17 13:33 Greg KH [this message]
2018-01-17 13:33 ` [PATCH] USB TYPEC: RT1711H Type-C Chip Driver Greg KH
  -- strict thread matches above, loose matches on Subject: below --
2018-01-30 23:25 Guenter Roeck
2018-01-30 23:25 ` [PATCH] " Guenter Roeck
2018-01-30 13:21 shufan_lee(李書帆)
2018-01-30 13:21 ` [PATCH] " shufan_lee(李書帆)
2018-01-29 19:57 Guenter Roeck
2018-01-29 19:57 ` [PATCH] " Guenter Roeck
2018-01-29  7:19 shufan_lee(李書帆)
2018-01-29  7:19 ` [PATCH] " shufan_lee(李書帆)
2018-01-22 18:50 Guenter Roeck
2018-01-22 18:50 ` [PATCH] " Guenter Roeck
2018-01-22  2:01 shufan_lee(李書帆)
2018-01-22  2:01 ` [PATCH] " shufan_lee(李書帆)
2018-01-19 16:02 Guenter Roeck
2018-01-19 16:02 ` [PATCH] " Guenter Roeck
2018-01-19  9:24 Heikki Krogerus
2018-01-19  9:24 ` [PATCH] " Heikki Krogerus
2018-01-19  9:01 shufan_lee(李書帆)
2018-01-19  9:01 ` [PATCH] " shufan_lee(李書帆)
2018-01-19  8:22 Heikki Krogerus
2018-01-19  8:22 ` [PATCH] " Heikki Krogerus
2018-01-19  8:03 Greg KH
2018-01-19  8:03 ` [PATCH] " 'Greg KH'
2018-01-19  5:48 shufan_lee(李書帆)
2018-01-19  5:48 ` [PATCH] " shufan_lee(李書帆)
2018-01-19  3:09 Jun Li
2018-01-19  3:09 ` [PATCH] " Jun Li
2018-01-18 13:13 shufan_lee(李書帆)
2018-01-18 13:13 ` [PATCH] " shufan_lee(李書帆)
2018-01-17 13:42 Greg KH
2018-01-17 13:42 ` [PATCH] " Greg KH
2018-01-17 13:33 Greg KH
2018-01-17 13:33 ` [PATCH] " Greg KH
2018-01-17 13:31 Greg Kroah-Hartman
2018-01-17 13:31 ` [PATCH] " Greg KH
2018-01-17 12:00 Heikki Krogerus
2018-01-17 12:00 ` [PATCH] " Heikki Krogerus
2018-01-17 11:14 Greg Kroah-Hartman
2018-01-17 11:14 ` [PATCH] " Greg KH
2018-01-17 11:08 Heikki Krogerus
2018-01-17 11:08 ` [PATCH] " Heikki Krogerus
2018-01-17  9:30 shufan_lee(李書帆)
2018-01-17  9:30 ` [PATCH] " shufan_lee(李書帆)
2018-01-10  6:59 ShuFanLee
2018-01-10  6:59 ` [PATCH] " ShuFanLee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180117133359.GD3188@kroah.com \
    --to=greg@kroah.com \
    --cc=cy_huang@richtek.com \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=leechu729@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=shufan_lee@richtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.