From: Jiri Benc <jbenc@redhat.com>
To: William Tu <u9012063@gmail.com>
Cc: netdev@vger.kernel.org, pshelar@ovn.org
Subject: Re: [PATCHv3 net-next 2/2] openvswitch: add erspan version I and II support
Date: Thu, 18 Jan 2018 11:13:49 +0100 [thread overview]
Message-ID: <20180118111349.74e90798@redhat.com> (raw)
In-Reply-To: <1516210371-20732-3-git-send-email-u9012063@gmail.com>
Looks much better.
On Wed, 17 Jan 2018 09:32:51 -0800, William Tu wrote:
> + OVS_ERSPAN_OPT_IDX, /* be32 index */
Why don't you convert this to u32 while passing to/from user space?
> + [OVS_ERSPAN_OPT_IDX] = { .len = sizeof(u32) },
sizeof(__be32) but see above.
Thanks,
Jiri
next prev parent reply other threads:[~2018-01-18 10:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-17 17:32 [PATCHv3 net-next 0/2] net: erspan: add support for openvswitch William Tu
2018-01-17 17:32 ` [PATCHv3 net-next 1/2] net: erspan: use bitfield instead of mask and offset William Tu
2018-01-17 17:32 ` [PATCHv3 net-next 2/2] openvswitch: add erspan version I and II support William Tu
2018-01-18 10:13 ` Jiri Benc [this message]
2018-01-18 20:45 ` William Tu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180118111349.74e90798@redhat.com \
--to=jbenc@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pshelar@ovn.org \
--cc=u9012063@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.