From: Vadim.Lomovtsev@caviumnetworks.com (Vadim Lomovtsev)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] net: ethernet: cavium: Correct Cavium Thunderx nicvf/nicpf modules names
Date: Thu, 18 Jan 2018 10:18:57 -0800 [thread overview]
Message-ID: <20180118181857.GA4207@localhost.localdomain> (raw)
In-Reply-To: <1516290789-3585-1-git-send-email-Vadim.Lomovtsev@caviumnetworks.com>
Self NACK here: modules names has to contain dashes instead
of underscores, as it defined at sources (or update modules
DRV_NAME definitions whithin the source files with underscores).
Shame on me.
Vadim
On Thu, Jan 18, 2018 at 07:53:09AM -0800, Vadim Lomovtsev wrote:
> From: Vadim Lomovtsev <Vadim.Lomovtsev@cavium.com>
>
> It was found that ethtool provides unexisting module name while
> it queries the specified network device for associated driver
> information.
>
> This patch is to correct Cavium CN88xx Thunder nicvf/nicpf modules
> names 'nicvf' to 'thunder_nicvf' and 'nicpf' to 'thunder_nicpf'.
>
> Signed-off-by: Dean Nelson <dnelson@redhat.com>
> Signed-off-by: Vadim Lomovtsev <Vadim.Lomovtsev@cavium.com>
> ---
> drivers/net/ethernet/cavium/thunder/Makefile | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/ethernet/cavium/thunder/Makefile b/drivers/net/ethernet/cavium/thunder/Makefile
> index 6b4d4add7353..f5642337d0fe 100644
> --- a/drivers/net/ethernet/cavium/thunder/Makefile
> +++ b/drivers/net/ethernet/cavium/thunder/Makefile
> @@ -4,9 +4,9 @@
>
> obj-$(CONFIG_THUNDER_NIC_RGX) += thunder_xcv.o
> obj-$(CONFIG_THUNDER_NIC_BGX) += thunder_bgx.o
> -obj-$(CONFIG_THUNDER_NIC_PF) += nicpf.o
> -obj-$(CONFIG_THUNDER_NIC_VF) += nicvf.o
> +obj-$(CONFIG_THUNDER_NIC_PF) += thunder_nicpf.o
> +obj-$(CONFIG_THUNDER_NIC_VF) += thunder_nicvf.o
>
> -nicpf-y := nic_main.o
> -nicvf-y := nicvf_main.o nicvf_queues.o
> -nicvf-y += nicvf_ethtool.o
> +thunder_nicpf-y := nic_main.o
> +thunder_nicvf-y := nicvf_main.o nicvf_queues.o
> +thunder_nicvf-y += nicvf_ethtool.o
> --
> 2.14.3
>
WARNING: multiple messages have this Message-ID (diff)
From: Vadim Lomovtsev <Vadim.Lomovtsev@caviumnetworks.com>
To: sgoutham@cavium.com, rric@kernel.org,
linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Vadim Lomovtsev <Vadim.Lomovtsev@cavium.com>,
Dean Nelson <dnelson@redhat.com>
Subject: Re: [PATCH v2] net: ethernet: cavium: Correct Cavium Thunderx nicvf/nicpf modules names
Date: Thu, 18 Jan 2018 10:18:57 -0800 [thread overview]
Message-ID: <20180118181857.GA4207@localhost.localdomain> (raw)
In-Reply-To: <1516290789-3585-1-git-send-email-Vadim.Lomovtsev@caviumnetworks.com>
Self NACK here: modules names has to contain dashes instead
of underscores, as it defined at sources (or update modules
DRV_NAME definitions whithin the source files with underscores).
Shame on me.
Vadim
On Thu, Jan 18, 2018 at 07:53:09AM -0800, Vadim Lomovtsev wrote:
> From: Vadim Lomovtsev <Vadim.Lomovtsev@cavium.com>
>
> It was found that ethtool provides unexisting module name while
> it queries the specified network device for associated driver
> information.
>
> This patch is to correct Cavium CN88xx Thunder nicvf/nicpf modules
> names 'nicvf' to 'thunder_nicvf' and 'nicpf' to 'thunder_nicpf'.
>
> Signed-off-by: Dean Nelson <dnelson@redhat.com>
> Signed-off-by: Vadim Lomovtsev <Vadim.Lomovtsev@cavium.com>
> ---
> drivers/net/ethernet/cavium/thunder/Makefile | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/ethernet/cavium/thunder/Makefile b/drivers/net/ethernet/cavium/thunder/Makefile
> index 6b4d4add7353..f5642337d0fe 100644
> --- a/drivers/net/ethernet/cavium/thunder/Makefile
> +++ b/drivers/net/ethernet/cavium/thunder/Makefile
> @@ -4,9 +4,9 @@
>
> obj-$(CONFIG_THUNDER_NIC_RGX) += thunder_xcv.o
> obj-$(CONFIG_THUNDER_NIC_BGX) += thunder_bgx.o
> -obj-$(CONFIG_THUNDER_NIC_PF) += nicpf.o
> -obj-$(CONFIG_THUNDER_NIC_VF) += nicvf.o
> +obj-$(CONFIG_THUNDER_NIC_PF) += thunder_nicpf.o
> +obj-$(CONFIG_THUNDER_NIC_VF) += thunder_nicvf.o
>
> -nicpf-y := nic_main.o
> -nicvf-y := nicvf_main.o nicvf_queues.o
> -nicvf-y += nicvf_ethtool.o
> +thunder_nicpf-y := nic_main.o
> +thunder_nicvf-y := nicvf_main.o nicvf_queues.o
> +thunder_nicvf-y += nicvf_ethtool.o
> --
> 2.14.3
>
next prev parent reply other threads:[~2018-01-18 18:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-18 15:42 [PATCH] net: ethernet: cavium: Correct Cacivum Thunderx nicvf/nicpf modules names Vadim Lomovtsev
2018-01-18 15:42 ` Vadim Lomovtsev
2018-01-18 15:49 ` Vadim Lomovtsev
2018-01-18 15:49 ` Vadim Lomovtsev
2018-01-18 15:53 ` [PATCH v2] net: ethernet: cavium: Correct Cavium " Vadim Lomovtsev
2018-01-18 15:53 ` Vadim Lomovtsev
2018-01-18 18:18 ` Vadim Lomovtsev [this message]
2018-01-18 18:18 ` Vadim Lomovtsev
2018-01-22 14:13 ` [PATCH v3] net: ethernet: cavium: Correct Cavium Thunderx NIC module and driver names Vadim Lomovtsev
2018-01-22 14:13 ` Vadim Lomovtsev
2018-01-24 21:27 ` David Miller
2018-01-24 21:27 ` David Miller
2018-01-25 11:11 ` Vadim Lomovtsev
2018-01-25 11:11 ` Vadim Lomovtsev
2018-01-25 11:38 ` [PATCH v4] net: ethernet: cavium: Correct Cavium Thunderx NIC driver names accordingly to module name Vadim Lomovtsev
2018-01-25 11:38 ` Vadim Lomovtsev
2018-01-29 17:22 ` David Miller
2018-01-29 17:22 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180118181857.GA4207@localhost.localdomain \
--to=vadim.lomovtsev@caviumnetworks.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.