All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/vmwgfx: Return boolean instead of integer in vmw_fence_obj_signaled
@ 2018-01-19  0:02 Gustavo A. R. Silva
  2018-01-19 12:40 ` Thomas Hellstrom
  0 siblings, 1 reply; 2+ messages in thread
From: Gustavo A. R. Silva @ 2018-01-19  0:02 UTC (permalink / raw)
  To: VMware Graphics, Sinclair Yeh, Thomas Hellstrom, David Airlie
  Cc: dri-devel, linux-kernel, Gustavo A. R. Silva

Return statements in functions returning bool should use
true/false instead of 1/0.

This issue was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
---
 drivers/gpu/drm/vmwgfx/vmwgfx_fence.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c b/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c
index 6c5c75c..35fd6f9 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c
@@ -496,7 +496,7 @@ bool vmw_fence_obj_signaled(struct vmw_fence_obj *fence)
 	struct vmw_fence_manager *fman = fman_from_fence(fence);
 
 	if (test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->base.flags))
-		return 1;
+		return true;
 
 	vmw_fences_update(fman);
 
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread
* Re: [PATCH] drm/vmwgfx: Return boolean instead of integer in vmw_fence_obj_signaled
  2018-01-19  0:02 [PATCH] drm/vmwgfx: Return boolean instead of integer in vmw_fence_obj_signaled Gustavo A. R. Silva
@ 2018-01-19 12:40 ` Thomas Hellstrom
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Hellstrom @ 2018-01-19 12:40 UTC (permalink / raw)
  To: Gustavo A. R. Silva, VMware Graphics, Sinclair Yeh, David Airlie
  Cc: dri-devel, linux-kernel

On 01/19/2018 01:02 AM, Gustavo A. R. Silva wrote:
> Return statements in functions returning bool should use
> true/false instead of 1/0.
>
> This issue was detected with the help of Coccinelle.
>
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Reviewed-by: Thomas Hellström <thellstrom@vmware.com>

I'll queue this for 4.17.

Thanks,
Thomas




> ---
>   drivers/gpu/drm/vmwgfx/vmwgfx_fence.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c b/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c
> index 6c5c75c..35fd6f9 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c
> @@ -496,7 +496,7 @@ bool vmw_fence_obj_signaled(struct vmw_fence_obj *fence)
>   	struct vmw_fence_manager *fman = fman_from_fence(fence);
>   
>   	if (test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->base.flags))
> -		return 1;
> +		return true;
>   
>   	vmw_fences_update(fman);
>   

^ permalink raw reply	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-01-19 12:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-19  0:02 [PATCH] drm/vmwgfx: Return boolean instead of integer in vmw_fence_obj_signaled Gustavo A. R. Silva
2018-01-19 12:40 ` Thomas Hellstrom

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.