From: Miquel Raynal <miquel.raynal@free-electrons.com>
To: Colin King <colin.king@canonical.com>
Cc: Boris Brezillon <boris.brezillon@free-electrons.com>,
Richard Weinberger <richard@nod.at>,
David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Marek Vasut <marek.vasut@gmail.com>,
Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>,
linux-mtd@lists.infradead.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH][next] mtd: nand: remove redundant variable 'oob_len'
Date: Fri, 19 Jan 2018 07:41:18 +0000 [thread overview]
Message-ID: <20180119084118.3450d47f@xps13> (raw)
In-Reply-To: <20180116125748.26042-1-colin.king@canonical.com>
Hello,
On Tue, 16 Jan 2018 12:57:48 +0000
Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Variable oob_len is assigned and never read, hence it is redundant and
> can be removed.
>
> Cleans up clang warnings:
>
> drivers/mtd/nand/marvell_nand.c:1356:6: warning: Value stored to
> 'oob_len' during its initialization is never read
> drivers/mtd/nand/marvell_nand.c:1369:4: warning: Value stored to
> 'oob_len' is never read
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
Same as before, can you change the prefix to:
mtd: nand: marvell:
Thank you,
Miquèl
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@free-electrons.com>
To: Colin King <colin.king@canonical.com>
Cc: Boris Brezillon <boris.brezillon@free-electrons.com>,
Richard Weinberger <richard@nod.at>,
David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Marek Vasut <marek.vasut@gmail.com>,
Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>,
linux-mtd@lists.infradead.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH][next] mtd: nand: remove redundant variable 'oob_len'
Date: Fri, 19 Jan 2018 08:41:18 +0100 [thread overview]
Message-ID: <20180119084118.3450d47f@xps13> (raw)
In-Reply-To: <20180116125748.26042-1-colin.king@canonical.com>
Hello,
On Tue, 16 Jan 2018 12:57:48 +0000
Colin King <colin.king@canonical.com> wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Variable oob_len is assigned and never read, hence it is redundant and
> can be removed.
>
> Cleans up clang warnings:
>
> drivers/mtd/nand/marvell_nand.c:1356:6: warning: Value stored to
> 'oob_len' during its initialization is never read
> drivers/mtd/nand/marvell_nand.c:1369:4: warning: Value stored to
> 'oob_len' is never read
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
Same as before, can you change the prefix to:
mtd: nand: marvell:
Thank you,
Miquèl
next prev parent reply other threads:[~2018-01-19 7:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-16 12:57 [PATCH][next] mtd: nand: remove redundant variable 'oob_len' Colin King
2018-01-19 7:41 ` Miquel Raynal [this message]
2018-01-19 7:41 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180119084118.3450d47f@xps13 \
--to=miquel.raynal@free-electrons.com \
--cc=boris.brezillon@free-electrons.com \
--cc=colin.king@canonical.com \
--cc=computersforpeace@gmail.com \
--cc=cyrille.pitchen@wedev4u.fr \
--cc=dwmw2@infradead.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.