From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH V5 0/2] nvme-pci: fix the timeout case when reset is ongoing
Date: Fri, 19 Jan 2018 04:52:56 -0700 [thread overview]
Message-ID: <20180119115255.GH12043@localhost.localdomain> (raw)
In-Reply-To: <84b4e3bc-fe23-607e-9d5e-bb5644eedb54@oracle.com>
On Fri, Jan 19, 2018@05:02:06PM +0800, jianchao.wang wrote:
> We should not use blk_sync_queue here, the requeue_work and run_work will be canceled.
> Just flush_work(&q->timeout_work) should be ok.
I agree flushing timeout_work is sufficient. All the other work had
already better not be running either, so it doesn't hurt to call the
sync API.
> In addition, we could check NVME_CC_ENABLE in nvme_dev_disable to avoid redundant invoking.
> :)
That should already be inferred through reading back the CSTS register.
WARNING: multiple messages have this Message-ID (diff)
From: Keith Busch <keith.busch@intel.com>
To: "jianchao.wang" <jianchao.w.wang@oracle.com>
Cc: axboe@fb.com, hch@lst.de, sagi@grimberg.me, maxg@mellanox.com,
james.smart@broadcom.com, linux-nvme@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V5 0/2] nvme-pci: fix the timeout case when reset is ongoing
Date: Fri, 19 Jan 2018 04:52:56 -0700 [thread overview]
Message-ID: <20180119115255.GH12043@localhost.localdomain> (raw)
In-Reply-To: <84b4e3bc-fe23-607e-9d5e-bb5644eedb54@oracle.com>
On Fri, Jan 19, 2018 at 05:02:06PM +0800, jianchao.wang wrote:
> We should not use blk_sync_queue here, the requeue_work and run_work will be canceled.
> Just flush_work(&q->timeout_work) should be ok.
I agree flushing timeout_work is sufficient. All the other work had
already better not be running either, so it doesn't hurt to call the
sync API.
> In addition, we could check NVME_CC_ENABLE in nvme_dev_disable to avoid redundant invoking.
> :)
That should already be inferred through reading back the CSTS register.
next prev parent reply other threads:[~2018-01-19 11:52 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-18 10:10 [PATCH V5 0/2] nvme-pci: fix the timeout case when reset is ongoing Jianchao Wang
2018-01-18 10:10 ` Jianchao Wang
2018-01-18 10:10 ` [PATCH V5 1/2] nvme-pci: introduce RECONNECTING state to mark initializing procedure Jianchao Wang
2018-01-18 10:10 ` Jianchao Wang
2018-01-18 10:17 ` Max Gurtovoy
2018-01-18 10:17 ` Max Gurtovoy
2018-01-19 9:49 ` jianchao.wang
2018-01-19 9:49 ` jianchao.wang
2018-01-18 15:23 ` James Smart
2018-01-18 15:23 ` James Smart
2018-01-18 10:10 ` [PATCH V5 2/2] nvme-pci: fixup the timeout case when reset is ongoing Jianchao Wang
2018-01-18 10:10 ` Jianchao Wang
2018-01-19 4:59 ` Keith Busch
2018-01-19 4:59 ` Keith Busch
2018-01-19 5:55 ` jianchao.wang
2018-01-19 5:55 ` jianchao.wang
2018-01-19 6:05 ` Keith Busch
2018-01-19 6:05 ` Keith Busch
2018-01-19 6:53 ` jianchao.wang
2018-01-19 6:53 ` jianchao.wang
2018-01-18 15:34 ` [PATCH V5 0/2] nvme-pci: fix " James Smart
2018-01-18 15:34 ` James Smart
2018-01-19 8:01 ` Keith Busch
2018-01-19 8:01 ` Keith Busch
2018-01-19 8:14 ` jianchao.wang
2018-01-19 8:14 ` jianchao.wang
2018-01-19 8:42 ` Keith Busch
2018-01-19 8:42 ` Keith Busch
2018-01-19 9:02 ` jianchao.wang
2018-01-19 9:02 ` jianchao.wang
2018-01-19 11:52 ` Keith Busch [this message]
2018-01-19 11:52 ` Keith Busch
2018-01-19 13:56 ` jianchao.wang
2018-01-19 13:56 ` jianchao.wang
2018-01-20 2:11 ` Keith Busch
2018-01-20 2:11 ` Keith Busch
2018-01-20 14:07 ` jianchao.wang
2018-01-20 14:07 ` jianchao.wang
2018-01-20 14:14 ` jianchao.wang
2018-01-20 14:14 ` jianchao.wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180119115255.GH12043@localhost.localdomain \
--to=keith.busch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.