From: Kalle Valo <kvalo@codeaurora.org>
To: Ramon Fried <rfried@codeaurora.org>
Cc: k.eugene.e@gmail.com, bjorn.andersson@linaro.org,
wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, Ramon Fried <rfried@codeaurora.org>
Subject: Re: wcn36xx: release resources in case of error
Date: Mon, 22 Jan 2018 06:14:48 +0000 (UTC) [thread overview]
Message-ID: <20180122061448.B010B6079C@smtp.codeaurora.org> (raw)
In-Reply-To: <20180118142348.12759-1-rfried@codeaurora.org>
Ramon Fried <rfried@codeaurora.org> wrote:
> wcn36xx_dxe_init() doesn't check for the return value
> of wcn36xx_dxe_init_descs().
> This patch releases the resources in case an error ocurred.
>
> Signed-off-by: Ramon Fried <rfried@codeaurora.org>
Doesn't compile:
drivers/net/wireless/ath/wcn36xx/dxe.c: In function ‘wcn36xx_dxe_deinit_descs’:
drivers/net/wireless/ath/wcn36xx/dxe.c:243:15: error: ‘struct wcn36xx_dxe_ch’ has no member named ‘desc_bum’
size = wcn_ch->desc_bum * sizeof(struct wcn36xx_dxe_desc);
^
drivers/net/wireless/ath/wcn36xx/dxe.c:244:20: error: ‘wcn’ undeclared (first use in this function)
dma_free_coherent(wcn->dev, size,
^
drivers/net/wireless/ath/wcn36xx/dxe.c:244:20: note: each undeclared identifier is reported only once for each function it appears in
drivers/net/wireless/ath/wcn36xx/dxe.c: In function ‘wcn36xx_dxe_init’:
drivers/net/wireless/ath/wcn36xx/dxe.c:737:3: error: implicit declaration of function ‘dev_error’ [-Werror=implicit-function-declaration]
dev_error("Error allocating descriptor\n");
^
drivers/net/wireless/ath/wcn36xx/dxe.c:818:2: error: expected ‘;’ before ‘if’
if (ret) {
^
drivers/net/wireless/ath/wcn36xx/dxe.c:860:1: warning: label ‘out_err_txh_ch’ defined but not used [-Wunused-label]
out_err_txh_ch:
^
drivers/net/wireless/ath/wcn36xx/dxe.c:856:1: warning: label ‘out_err_rxh_ch’ defined but not used [-Wunused-label]
out_err_rxh_ch:
^
drivers/net/wireless/ath/wcn36xx/dxe.c:760:3: error: label ‘our_err_txh_ch’ used but not defined
goto our_err_txh_ch;
^
cc1: some warnings being treated as errors
make[5]: *** [drivers/net/wireless/ath/wcn36xx/dxe.o] Error 1
make[4]: *** [drivers/net/wireless/ath/wcn36xx] Error 2
make[3]: *** [drivers/net/wireless/ath] Error 2
make[2]: *** [drivers/net/wireless] Error 2
make[1]: *** [drivers/net] Error 2
make[1]: *** Waiting for unfinished jobs....
make: *** [drivers] Error 2
Patch set to Changes Requested.
--
https://patchwork.kernel.org/patch/10173325/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
To: Ramon Fried <rfried-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
Cc: k.eugene.e-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
bjorn.andersson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
wcn36xx-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Ramon Fried <rfried-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
Subject: Re: wcn36xx: release resources in case of error
Date: Mon, 22 Jan 2018 06:14:48 +0000 (UTC) [thread overview]
Message-ID: <20180122061448.B010B6079C@smtp.codeaurora.org> (raw)
In-Reply-To: <20180118142348.12759-1-rfried-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
Ramon Fried <rfried-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> wrote:
> wcn36xx_dxe_init() doesn't check for the return value
> of wcn36xx_dxe_init_descs().
> This patch releases the resources in case an error ocurred.
>
> Signed-off-by: Ramon Fried <rfried-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
Doesn't compile:
drivers/net/wireless/ath/wcn36xx/dxe.c: In function ‘wcn36xx_dxe_deinit_descs’:
drivers/net/wireless/ath/wcn36xx/dxe.c:243:15: error: ‘struct wcn36xx_dxe_ch’ has no member named ‘desc_bum’
size = wcn_ch->desc_bum * sizeof(struct wcn36xx_dxe_desc);
^
drivers/net/wireless/ath/wcn36xx/dxe.c:244:20: error: ‘wcn’ undeclared (first use in this function)
dma_free_coherent(wcn->dev, size,
^
drivers/net/wireless/ath/wcn36xx/dxe.c:244:20: note: each undeclared identifier is reported only once for each function it appears in
drivers/net/wireless/ath/wcn36xx/dxe.c: In function ‘wcn36xx_dxe_init’:
drivers/net/wireless/ath/wcn36xx/dxe.c:737:3: error: implicit declaration of function ‘dev_error’ [-Werror=implicit-function-declaration]
dev_error("Error allocating descriptor\n");
^
drivers/net/wireless/ath/wcn36xx/dxe.c:818:2: error: expected ‘;’ before ‘if’
if (ret) {
^
drivers/net/wireless/ath/wcn36xx/dxe.c:860:1: warning: label ‘out_err_txh_ch’ defined but not used [-Wunused-label]
out_err_txh_ch:
^
drivers/net/wireless/ath/wcn36xx/dxe.c:856:1: warning: label ‘out_err_rxh_ch’ defined but not used [-Wunused-label]
out_err_rxh_ch:
^
drivers/net/wireless/ath/wcn36xx/dxe.c:760:3: error: label ‘our_err_txh_ch’ used but not defined
goto our_err_txh_ch;
^
cc1: some warnings being treated as errors
make[5]: *** [drivers/net/wireless/ath/wcn36xx/dxe.o] Error 1
make[4]: *** [drivers/net/wireless/ath/wcn36xx] Error 2
make[3]: *** [drivers/net/wireless/ath] Error 2
make[2]: *** [drivers/net/wireless] Error 2
make[1]: *** [drivers/net] Error 2
make[1]: *** Waiting for unfinished jobs....
make: *** [drivers] Error 2
Patch set to Changes Requested.
--
https://patchwork.kernel.org/patch/10173325/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2018-01-22 6:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-18 14:23 [PATCH] wcn36xx: release resources in case of error Ramon Fried
2018-01-18 14:23 ` Ramon Fried
2018-01-22 6:14 ` Kalle Valo [this message]
2018-01-22 6:14 ` Kalle Valo
[not found] ` <20180122061448.91CBD6081E@smtp.codeaurora.org>
2018-01-23 15:12 ` Ramon Fried
2018-01-23 15:12 ` Ramon Fried
-- strict thread matches above, loose matches on Subject: below --
2018-01-18 14:31 [PATCH] " Ramon Fried
2018-01-22 6:15 ` Kalle Valo
2018-01-22 6:15 ` Kalle Valo
2018-01-18 14:33 [PATCH] " Ramon Fried
2018-01-22 6:15 ` Kalle Valo
2018-01-22 6:15 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180122061448.B010B6079C@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=k.eugene.e@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rfried@codeaurora.org \
--cc=wcn36xx@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.