From: Ladislav Michl <ladis@linux-mips.org>
To: Claudiu Beznea <Claudiu.Beznea@microchip.com>
Cc: linux-omap@vger.kernel.org, linux-pwm@vger.kernel.org,
Keerthy <j-keerthy@ti.com>,
daniel.lezcano@linaro.org, thierry.reding@gmail.com,
tony@atomide.com, aaro.koskinen@iki.fi, narmstrong@baylibre.com,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
sebastian.reichel@collabora.co.uk, robh+dt@kernel.org,
t-kristo@ti.com, grygorii.strashko@ti.com
Subject: Re: [PATCH 2/3] pwm: pwm-omap-dmtimer: Fix frequency when using prescaler
Date: Mon, 22 Jan 2018 11:53:31 +0100 [thread overview]
Message-ID: <20180122105331.GA21159@lenoch> (raw)
In-Reply-To: <3e00e721-984c-e8db-49f7-046d7b335404@microchip.com>
Dear Claudiu,
On Mon, Jan 22, 2018 at 11:17:08AM +0200, Claudiu Beznea wrote:
> On 17.01.2018 23:47, Ladislav Michl wrote:
> > @@ -334,18 +348,18 @@ static int pwm_omap_dmtimer_probe(struct platform_device *pdev)
> >
> > mutex_init(&omap->mutex);
> >
> > - status = pwmchip_add(&omap->chip);
> > - if (status < 0) {
> > + ret = pwmchip_add(&omap->chip);
> > + if (ret < 0) {
> > dev_err(&pdev->dev, "failed to register PWM\n");
> > - omap->pdata->free(omap->dm_timer);
> > - ret = status;
> > - goto put;
> > + goto free;
> > }
> >
> > platform_set_drvdata(pdev, omap);
> >From documentation: "of_parse_phandle(): Returns the device_node pointer with refcount
> incremented. Use of_node_put() on it when done."
> In case of success the of_node_put() should also be called as I see.
Based on you previous suggestions found here:
https://patchwork.kernel.org/patch/10140209/
I'd say this fix belongs to patch which introduces of_node_put() in the error
path. I'll then rebase this patches on top of the fix.
Thank you,
ladis
WARNING: multiple messages have this Message-ID (diff)
From: ladis@linux-mips.org (Ladislav Michl)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] pwm: pwm-omap-dmtimer: Fix frequency when using prescaler
Date: Mon, 22 Jan 2018 11:53:31 +0100 [thread overview]
Message-ID: <20180122105331.GA21159@lenoch> (raw)
In-Reply-To: <3e00e721-984c-e8db-49f7-046d7b335404@microchip.com>
Dear Claudiu,
On Mon, Jan 22, 2018 at 11:17:08AM +0200, Claudiu Beznea wrote:
> On 17.01.2018 23:47, Ladislav Michl wrote:
> > @@ -334,18 +348,18 @@ static int pwm_omap_dmtimer_probe(struct platform_device *pdev)
> >
> > mutex_init(&omap->mutex);
> >
> > - status = pwmchip_add(&omap->chip);
> > - if (status < 0) {
> > + ret = pwmchip_add(&omap->chip);
> > + if (ret < 0) {
> > dev_err(&pdev->dev, "failed to register PWM\n");
> > - omap->pdata->free(omap->dm_timer);
> > - ret = status;
> > - goto put;
> > + goto free;
> > }
> >
> > platform_set_drvdata(pdev, omap);
> >From documentation: "of_parse_phandle(): Returns the device_node pointer with refcount
> incremented. Use of_node_put() on it when done."
> In case of success the of_node_put() should also be called as I see.
Based on you previous suggestions found here:
https://patchwork.kernel.org/patch/10140209/
I'd say this fix belongs to patch which introduces of_node_put() in the error
path. I'll then rebase this patches on top of the fix.
Thank you,
ladis
next prev parent reply other threads:[~2018-01-22 10:53 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-17 21:46 [PATCH 0/3] omap: dmtimer: Fix and cleanup moved driver Ladislav Michl
2018-01-17 21:46 ` Ladislav Michl
2018-01-17 21:47 ` [PATCH 1/3] clocksource: timer-dm: Check prescaler value Ladislav Michl
2018-01-17 21:47 ` Ladislav Michl
2018-01-17 21:47 ` Ladislav Michl
2018-01-22 9:00 ` Claudiu Beznea
2018-01-22 9:00 ` Claudiu Beznea
2018-01-22 9:00 ` Claudiu Beznea
2018-01-22 9:59 ` Ladislav Michl
2018-01-22 9:59 ` Ladislav Michl
2018-01-22 10:04 ` Claudiu Beznea
2018-01-22 10:04 ` Claudiu Beznea
2018-01-22 10:04 ` Claudiu Beznea
2018-01-17 21:47 ` [PATCH 2/3] pwm: pwm-omap-dmtimer: Fix frequency when using prescaler Ladislav Michl
2018-01-17 21:47 ` Ladislav Michl
2018-01-17 21:47 ` Ladislav Michl
2018-01-22 9:17 ` Claudiu Beznea
2018-01-22 9:17 ` Claudiu Beznea
2018-01-22 9:17 ` Claudiu Beznea
2018-01-22 9:17 ` Claudiu Beznea
2018-01-22 10:53 ` Ladislav Michl [this message]
2018-01-22 10:53 ` Ladislav Michl
2018-01-24 5:26 ` Keerthy
2018-01-24 5:26 ` Keerthy
2018-01-24 5:26 ` Keerthy
2018-01-24 5:49 ` Keerthy
2018-01-24 5:49 ` Keerthy
2018-01-24 5:49 ` Keerthy
2018-01-17 21:48 ` [PATCH 3/3] clocksource: timer-dm: Make unexported functions static Ladislav Michl
2018-01-17 21:48 ` Ladislav Michl
2018-01-22 9:26 ` Claudiu Beznea
2018-01-22 9:26 ` Claudiu Beznea
2018-01-22 9:26 ` Claudiu Beznea
2018-01-22 10:39 ` Ladislav Michl
2018-01-22 10:39 ` Ladislav Michl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180122105331.GA21159@lenoch \
--to=ladis@linux-mips.org \
--cc=Claudiu.Beznea@microchip.com \
--cc=aaro.koskinen@iki.fi \
--cc=daniel.lezcano@linaro.org \
--cc=grygorii.strashko@ti.com \
--cc=j-keerthy@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=narmstrong@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sebastian.reichel@collabora.co.uk \
--cc=t-kristo@ti.com \
--cc=thierry.reding@gmail.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.