From: Vinod Koul <vinod.koul@intel.com>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: Andy Gross <andy.gross@linaro.org>,
dmaengine@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
David Brown <david.brown@linaro.org>,
Dan Williams <dan.j.williams@intel.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
yanhe@quicinc.com, ramkri@qti.qualcomm.com, sdharia@quicinc.com
Subject: [1/4] dmaengine: qcom: bam_dma: make bam clk optional
Date: Tue, 23 Jan 2018 14:49:05 +0530 [thread overview]
Message-ID: <20180123091905.GY18649@localhost> (raw)
On Mon, Jan 22, 2018 at 09:55:01AM +0000, Srinivas Kandagatla wrote:
> >>@@ -1180,13 +1180,14 @@ static int bam_dma_probe(struct platform_device *pdev)
> >> "qcom,controlled-remotely");
> >> bdev->bamclk = devm_clk_get(bdev->dev, "bam_clk");
> >
> >but you still do clk_get unconditionally?
>
> Only reason to do this way is to not break existing users in the mainline.
>
> remotely controlled BAM is already supported in upstream driver, there are
> users of this who pass clk from device tree, If I make this conditional then
> subsequent reads to the BAM registers for those instances might crash the
> system.
But these instances are remote controlled, so if we stop representing them
in Linux, why would we read them?
WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
To: Srinivas Kandagatla
<srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: Andy Gross <andy.gross-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
David Brown <david.brown-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Dan Williams
<dan.j.williams-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
yanhe-jfJNa2p1gH1BDgjK7y7TUQ@public.gmane.org,
ramkri-Rm6X0d1/PG5y9aJCnZT0Uw@public.gmane.org,
sdharia-jfJNa2p1gH1BDgjK7y7TUQ@public.gmane.org
Subject: Re: [PATCH 1/4] dmaengine: qcom: bam_dma: make bam clk optional
Date: Tue, 23 Jan 2018 14:49:05 +0530 [thread overview]
Message-ID: <20180123091905.GY18649@localhost> (raw)
In-Reply-To: <8dfa8ba1-6e98-a8e4-614c-592861cef571-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
On Mon, Jan 22, 2018 at 09:55:01AM +0000, Srinivas Kandagatla wrote:
> >>@@ -1180,13 +1180,14 @@ static int bam_dma_probe(struct platform_device *pdev)
> >> "qcom,controlled-remotely");
> >> bdev->bamclk = devm_clk_get(bdev->dev, "bam_clk");
> >
> >but you still do clk_get unconditionally?
>
> Only reason to do this way is to not break existing users in the mainline.
>
> remotely controlled BAM is already supported in upstream driver, there are
> users of this who pass clk from device tree, If I make this conditional then
> subsequent reads to the BAM registers for those instances might crash the
> system.
But these instances are remote controlled, so if we stop representing them
in Linux, why would we read them?
--
~Vinod
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vinod.koul@intel.com>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: Andy Gross <andy.gross@linaro.org>,
dmaengine@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
David Brown <david.brown@linaro.org>,
Dan Williams <dan.j.williams@intel.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
yanhe@quicinc.com, ramkri@qti.qualcomm.com, sdharia@quicinc.com
Subject: Re: [PATCH 1/4] dmaengine: qcom: bam_dma: make bam clk optional
Date: Tue, 23 Jan 2018 14:49:05 +0530 [thread overview]
Message-ID: <20180123091905.GY18649@localhost> (raw)
In-Reply-To: <8dfa8ba1-6e98-a8e4-614c-592861cef571@linaro.org>
On Mon, Jan 22, 2018 at 09:55:01AM +0000, Srinivas Kandagatla wrote:
> >>@@ -1180,13 +1180,14 @@ static int bam_dma_probe(struct platform_device *pdev)
> >> "qcom,controlled-remotely");
> >> bdev->bamclk = devm_clk_get(bdev->dev, "bam_clk");
> >
> >but you still do clk_get unconditionally?
>
> Only reason to do this way is to not break existing users in the mainline.
>
> remotely controlled BAM is already supported in upstream driver, there are
> users of this who pass clk from device tree, If I make this conditional then
> subsequent reads to the BAM registers for those instances might crash the
> system.
But these instances are remote controlled, so if we stop representing them
in Linux, why would we read them?
--
~Vinod
next reply other threads:[~2018-01-23 9:19 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-23 9:19 Vinod Koul [this message]
2018-01-23 9:19 ` [PATCH 1/4] dmaengine: qcom: bam_dma: make bam clk optional Vinod Koul
2018-01-23 9:19 ` Vinod Koul
-- strict thread matches above, loose matches on Subject: below --
2018-01-30 9:18 [4/4] dmaengine: qcom: bam_dma: Add num-ees dt binding for remotely controlled Srinivas Kandagatla
2018-01-30 9:18 ` [PATCH 4/4] " Srinivas Kandagatla
2018-01-30 9:18 ` Srinivas Kandagatla
2018-01-29 16:21 [4/4] " Rob Herring
2018-01-29 16:21 ` [PATCH 4/4] " Rob Herring
2018-01-29 16:21 ` Rob Herring
2018-01-29 16:19 [2/4] dmaengine: qcom: bam_dma: add num-channels " Rob Herring
2018-01-29 16:19 ` [PATCH 2/4] " Rob Herring
2018-01-29 16:19 ` Rob Herring
2018-01-23 9:20 [1/4] dmaengine: qcom: bam_dma: make bam clk optional Srinivas Kandagatla
2018-01-23 9:20 ` [PATCH 1/4] " Srinivas Kandagatla
2018-01-23 9:20 ` Srinivas Kandagatla
2018-01-22 9:55 [2/4] dmaengine: qcom: bam_dma: add num-channels binding for remotely controlled Srinivas Kandagatla
2018-01-22 9:55 ` [PATCH 2/4] " Srinivas Kandagatla
2018-01-22 9:55 [1/4] dmaengine: qcom: bam_dma: make bam clk optional Srinivas Kandagatla
2018-01-22 9:55 ` [PATCH 1/4] " Srinivas Kandagatla
2018-01-19 5:55 [2/4] dmaengine: qcom: bam_dma: add num-channels binding for remotely controlled Vinod Koul
2018-01-19 5:55 ` [PATCH 2/4] " Vinod Koul
2018-01-19 5:52 [1/4] dmaengine: qcom: bam_dma: make bam clk optional Vinod Koul
2018-01-19 5:52 ` [PATCH 1/4] " Vinod Koul
2018-01-17 9:46 [1/4] " Srinivas Kandagatla
2018-01-17 9:46 ` [PATCH 1/4] " Srinivas Kandagatla
2018-01-16 19:38 [1/4] " Sagar Dharia
2018-01-16 19:38 ` [PATCH 1/4] " Sagar Dharia
2018-01-16 19:02 [4/4] dmaengine: qcom: bam_dma: Add num-ees dt binding for remotely controlled Srinivas Kandagatla
2018-01-16 19:02 ` [PATCH 4/4] " srinivas.kandagatla
2018-01-16 19:02 [3/4] dmaengine: qcom: bam_dma: do not write to global regs in remote mode Srinivas Kandagatla
2018-01-16 19:02 ` [PATCH 3/4] " srinivas.kandagatla
2018-01-16 19:02 [2/4] dmaengine: qcom: bam_dma: add num-channels binding for remotely controlled Srinivas Kandagatla
2018-01-16 19:02 ` [PATCH 2/4] " srinivas.kandagatla
2018-01-16 19:02 ` srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A
2018-01-16 19:02 [1/4] dmaengine: qcom: bam_dma: make bam clk optional Srinivas Kandagatla
2018-01-16 19:02 ` [PATCH 1/4] " srinivas.kandagatla
2018-01-16 19:02 [PATCH 0/4] dmaengine: qcom: bam_dma: fixes for remotely controlled bam srinivas.kandagatla
[not found] ` <20180116190236.14558-1-srinivas.kandagatla-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2018-01-17 10:18 ` Vinod Koul
2018-01-17 10:18 ` Vinod Koul
2018-01-17 10:55 ` Srinivas Kandagatla
2018-01-17 15:59 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180123091905.GY18649@localhost \
--to=vinod.koul@intel.com \
--cc=andy.gross@linaro.org \
--cc=dan.j.williams@intel.com \
--cc=david.brown@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=ramkri@qti.qualcomm.com \
--cc=robh+dt@kernel.org \
--cc=sdharia@quicinc.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=yanhe@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.