[PATCH] drm/etnaviv: fix '%x' warning

[PATCH] drm/etnaviv: fix '%x' warning

[Gustavo A. R. Silva]

Fix the following warning by using %zx instead of %x for variable of
type size_t:

warning: format ‘%x’ expects argument of type ‘unsigned int’, but
argument 4 has type ‘size_t {aka long unsigned int}’ [-Wformat=]

Fixes: 50073cf98d16 ("drm/etnaviv: mmu: stop using iommu map/unmap functions")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
This code was compiled with GCC 7.2.0

 drivers/gpu/drm/etnaviv/etnaviv_mmu.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/etnaviv/etnaviv_mmu.c b/drivers/gpu/drm/etnaviv/etnaviv_mmu.c
index d113fe0..49e0497 100644
--- a/drivers/gpu/drm/etnaviv/etnaviv_mmu.c
+++ b/drivers/gpu/drm/etnaviv/etnaviv_mmu.c
@@ -29,7 +29,7 @@ static void etnaviv_domain_unmap(struct etnaviv_iommu_domain *domain,
 	size_t pgsize = SZ_4K;
 
 	if (!IS_ALIGNED(iova | size, pgsize)) {
-		pr_err("unaligned: iova 0x%lx size 0x%zx min_pagesz 0x%x\n",
+		pr_err("unaligned: iova 0x%lx size 0x%zx min_pagesz 0x%zx\n",
 		       iova, size, pgsize);
 		return;
 	}
@@ -54,7 +54,7 @@ static int etnaviv_domain_map(struct etnaviv_iommu_domain *domain,
 	int ret = 0;
 
 	if (!IS_ALIGNED(iova | paddr | size, pgsize)) {
-		pr_err("unaligned: iova 0x%lx pa %pa size 0x%zx min_pagesz 0x%x\n",
+		pr_err("unaligned: iova 0x%lx pa %pa size 0x%zx min_pagesz 0x%zx\n",
 		       iova, &paddr, size, pgsize);
 		return -EINVAL;
 	}
-- 
2.7.4

Re: [PATCH] drm/etnaviv: fix '%x' warning

[Lucas Stach]

Hi Gustavo,

Am Dienstag, den 23.01.2018, 11:07 -0600 schrieb Gustavo A. R. Silva:
> Fix the following warning by using %zx instead of %x for variable of
> type size_t:
> 
> warning: format ‘%x’ expects argument of type ‘unsigned int’, but
> argument 4 has type ‘size_t {aka long unsigned int}’ [-Wformat=]
> 
> Fixes: 50073cf98d16 ("drm/etnaviv: mmu: stop using iommu map/unmap functions")
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>

Thanks for the patch, but I already have an equivalent change queued up.

Regards,
Lucas

> ---
> This code was compiled with GCC 7.2.0
> 
>  drivers/gpu/drm/etnaviv/etnaviv_mmu.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_mmu.c b/drivers/gpu/drm/etnaviv/etnaviv_mmu.c
> index d113fe0..49e0497 100644
> --- a/drivers/gpu/drm/etnaviv/etnaviv_mmu.c
> +++ b/drivers/gpu/drm/etnaviv/etnaviv_mmu.c
> @@ -29,7 +29,7 @@ static void etnaviv_domain_unmap(struct etnaviv_iommu_domain *domain,
> >  	size_t pgsize = SZ_4K;
>  
> >  	if (!IS_ALIGNED(iova | size, pgsize)) {
> > -		pr_err("unaligned: iova 0x%lx size 0x%zx min_pagesz 0x%x\n",
> > +		pr_err("unaligned: iova 0x%lx size 0x%zx min_pagesz 0x%zx\n",
> >  		       iova, size, pgsize);
> >  		return;
> >  	}
> @@ -54,7 +54,7 @@ static int etnaviv_domain_map(struct etnaviv_iommu_domain *domain,
> >  	int ret = 0;
>  
> >  	if (!IS_ALIGNED(iova | paddr | size, pgsize)) {
> > -		pr_err("unaligned: iova 0x%lx pa %pa size 0x%zx min_pagesz 0x%x\n",
> > +		pr_err("unaligned: iova 0x%lx pa %pa size 0x%zx min_pagesz 0x%zx\n",
> >  		       iova, &paddr, size, pgsize);
> >  		return -EINVAL;
> >  	}
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] drm/etnaviv: fix '%x' warning

[Lucas Stach]

Hi Gustavo,

Am Dienstag, den 23.01.2018, 11:07 -0600 schrieb Gustavo A. R. Silva:
> Fix the following warning by using %zx instead of %x for variable of
> type size_t:
> 
> warning: format ‘%x’ expects argument of type ‘unsigned int’, but
> argument 4 has type ‘size_t {aka long unsigned int}’ [-Wformat=]
> 
> Fixes: 50073cf98d16 ("drm/etnaviv: mmu: stop using iommu map/unmap functions")
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>

Thanks for the patch, but I already have an equivalent change queued up.

Regards,
Lucas

> ---
> This code was compiled with GCC 7.2.0
> 
>  drivers/gpu/drm/etnaviv/etnaviv_mmu.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_mmu.c b/drivers/gpu/drm/etnaviv/etnaviv_mmu.c
> index d113fe0..49e0497 100644
> --- a/drivers/gpu/drm/etnaviv/etnaviv_mmu.c
> +++ b/drivers/gpu/drm/etnaviv/etnaviv_mmu.c
> @@ -29,7 +29,7 @@ static void etnaviv_domain_unmap(struct etnaviv_iommu_domain *domain,
> >  	size_t pgsize = SZ_4K;
>  
> >  	if (!IS_ALIGNED(iova | size, pgsize)) {
> > -		pr_err("unaligned: iova 0x%lx size 0x%zx min_pagesz 0x%x\n",
> > +		pr_err("unaligned: iova 0x%lx size 0x%zx min_pagesz 0x%zx\n",
> >  		       iova, size, pgsize);
> >  		return;
> >  	}
> @@ -54,7 +54,7 @@ static int etnaviv_domain_map(struct etnaviv_iommu_domain *domain,
> >  	int ret = 0;
>  
> >  	if (!IS_ALIGNED(iova | paddr | size, pgsize)) {
> > -		pr_err("unaligned: iova 0x%lx pa %pa size 0x%zx min_pagesz 0x%x\n",
> > +		pr_err("unaligned: iova 0x%lx pa %pa size 0x%zx min_pagesz 0x%zx\n",
> >  		       iova, &paddr, size, pgsize);
> >  		return -EINVAL;
> >  	}

Re: [PATCH] drm/etnaviv: fix '%x' warning

[Gustavo A. R. Silva]

Hello Lucas,

Quoting Lucas Stach <l.stach@pengutronix.de>:

> Hi Gustavo,
>
> Am Dienstag, den 23.01.2018, 11:07 -0600 schrieb Gustavo A. R. Silva:
>> Fix the following warning by using %zx instead of %x for variable of
>> type size_t:
>>
>> warning: format ‘%x’ expects argument of type ‘unsigned int’, but
>> argument 4 has type ‘size_t {aka long unsigned int}’ [-Wformat=]
>>
>> Fixes: 50073cf98d16 ("drm/etnaviv: mmu: stop using iommu map/unmap  
>> functions")
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>
> Thanks for the patch, but I already have an equivalent change queued up.
>

That's great. I'm glad it is already fixed.

Thanks
--
Gustavo