From: Jon Mason <jdmason@kudzu.us>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] ntb_perf: Fix an error code in perf_copy_chunk()
Date: Wed, 24 Jan 2018 04:07:29 +0000 [thread overview]
Message-ID: <20180124040728.GC20474@kudzu.us> (raw)
In-Reply-To: <20180123083356.GC10091@mwanda>
On Tue, Jan 23, 2018 at 11:55:31AM +0300, Serge Semin wrote:
> On Tue, Jan 23, 2018 at 11:33:56AM +0300, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> > We accidentally return success if dmaengine_submit() fails. The fix is
> > to preserve the error code from dma_submit_error().
> >
>
> Yep, absolutely right. Thanks!
>
> Acked-by: Serge Semin <fancer.lancer@gmail.com>
Applied to ntb-next
Thanks,
Jon
>
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> >
> > diff --git a/drivers/ntb/test/ntb_perf.c b/drivers/ntb/test/ntb_perf.c
> > index 8de72f3fba4d..387e685063fc 100644
> > --- a/drivers/ntb/test/ntb_perf.c
> > +++ b/drivers/ntb/test/ntb_perf.c
> > @@ -828,7 +828,8 @@ static int perf_copy_chunk(struct perf_thread *pthr,
> > tx->callback_param = pthr;
> > dma_set_unmap(tx, unmap);
> >
> > - if (dma_submit_error(dmaengine_submit(tx))) {
> > + ret = dma_submit_error(dmaengine_submit(tx));
> > + if (ret) {
> > dmaengine_unmap_put(unmap);
> > goto err_free_resource;
> > }
WARNING: multiple messages have this Message-ID (diff)
From: Jon Mason <jdmason@kudzu.us>
To: Serge Semin <fancer.lancer@gmail.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
Dave Jiang <dave.jiang@intel.com>,
Allen Hubbe <allenbh@gmail.com>, Gary R Hook <gary.hook@amd.com>,
Logan Gunthorpe <logang@deltatee.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-ntb@googlegroups.com, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] ntb_perf: Fix an error code in perf_copy_chunk()
Date: Tue, 23 Jan 2018 23:07:29 -0500 [thread overview]
Message-ID: <20180124040728.GC20474@kudzu.us> (raw)
In-Reply-To: <20180123085531.GA17853@mobilestation>
On Tue, Jan 23, 2018 at 11:55:31AM +0300, Serge Semin wrote:
> On Tue, Jan 23, 2018 at 11:33:56AM +0300, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> > We accidentally return success if dmaengine_submit() fails. The fix is
> > to preserve the error code from dma_submit_error().
> >
>
> Yep, absolutely right. Thanks!
>
> Acked-by: Serge Semin <fancer.lancer@gmail.com>
Applied to ntb-next
Thanks,
Jon
>
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> >
> > diff --git a/drivers/ntb/test/ntb_perf.c b/drivers/ntb/test/ntb_perf.c
> > index 8de72f3fba4d..387e685063fc 100644
> > --- a/drivers/ntb/test/ntb_perf.c
> > +++ b/drivers/ntb/test/ntb_perf.c
> > @@ -828,7 +828,8 @@ static int perf_copy_chunk(struct perf_thread *pthr,
> > tx->callback_param = pthr;
> > dma_set_unmap(tx, unmap);
> >
> > - if (dma_submit_error(dmaengine_submit(tx))) {
> > + ret = dma_submit_error(dmaengine_submit(tx));
> > + if (ret) {
> > dmaengine_unmap_put(unmap);
> > goto err_free_resource;
> > }
next prev parent reply other threads:[~2018-01-24 4:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-23 8:33 [PATCH] ntb_perf: Fix an error code in perf_copy_chunk() Dan Carpenter
2018-01-23 8:33 ` Dan Carpenter
2018-01-23 8:55 ` Serge Semin
2018-01-23 8:55 ` Serge Semin
2018-01-24 4:07 ` Jon Mason [this message]
2018-01-24 4:07 ` Jon Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180124040728.GC20474@kudzu.us \
--to=jdmason@kudzu.us \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.