From: Yuanhan Liu <yliu@fridaylinux.org>
To: "Gaëtan Rivet" <gaetan.rivet@6wind.com>
Cc: Thomas Monjalon <thomas@monjalon.net>,
Ferruh Yigit <ferruh.yigit@intel.com>,
dev@dpdk.org
Subject: Re: [PATCH] doc: document the new devargs syntax
Date: Wed, 24 Jan 2018 23:24:32 +0800 [thread overview]
Message-ID: <20180124152432.GX29540@yliu-mob> (raw)
In-Reply-To: <20180123160816.uvsvegtltmzrr4yi@bidouze.vm.6wind.com>
On Tue, Jan 23, 2018 at 05:08:16PM +0100, Gaëtan Rivet wrote:
> Drivers answers to a specific API (ethdev, cryptodev, ...), to create
> standardized objects in response to parameters that are given to them
> for init. I think matching properties should be restricted to higher
> classes (bus, eth/crypto),
That's also what I thought. But I'm okay to have "driver" category
included for matching. I just don't really see a good example for that.
> while the driver class should be left
> free-form and to the responsibility of the PMD itself (while having the
> proper libraries for helping parsing safely, thus driving developpers
> toward similar syntaxes, while not forcing them in those).
I agree. The drv args are parsed by the drivers after all. It's hard to
have a good parser for all. I also don't know why we have to force them
to use "key=value" pairs.
I even see some drawbacks from the forcement:
- some PMDs already use none key/value format. Forcing them breaks more.
If the "-w" "--vdev" compatibility is kept", nothing will be broken
from the user point of view. However, if "key=value" pair is going to
be used, user have to do some changes.
- Some "value" might have to use the nested "=". Handling the nested pairs
introduces more complexity.
- sometimes, it's simple without an assignment. For example, it could be
"driver=vhost-pmd,...,client" to let the vhost PMD acts as the client
mode.
Both Linux kernel and QEMU don't force the "key=value" pair usage, I don't
see any good reason why we have to do that.
--yliu
next prev parent reply other threads:[~2018-01-24 15:24 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-16 14:50 [PATCH] doc: document the new devargs syntax Yuanhan Liu
2018-01-16 16:33 ` Mcnamara, John
2018-01-16 23:19 ` Gaëtan Rivet
2018-01-16 23:22 ` Thomas Monjalon
2018-01-16 23:46 ` Gaëtan Rivet
2018-01-17 0:03 ` Thomas Monjalon
2018-01-17 9:37 ` Gaëtan Rivet
2018-01-17 9:43 ` Thomas Monjalon
2018-01-17 10:11 ` Gaëtan Rivet
2018-01-17 10:54 ` Thomas Monjalon
2018-01-17 12:34 ` Ferruh Yigit
2018-01-18 7:35 ` Yuanhan Liu
2018-01-18 8:46 ` Thomas Monjalon
2018-01-18 9:46 ` Gaëtan Rivet
2018-01-23 12:46 ` Yuanhan Liu
2018-01-23 14:29 ` Thomas Monjalon
2018-01-23 16:08 ` Gaëtan Rivet
2018-01-23 17:22 ` Thomas Monjalon
2018-01-23 17:37 ` Gaëtan Rivet
2018-01-23 18:12 ` Thomas Monjalon
2018-01-24 15:24 ` Yuanhan Liu [this message]
2018-01-24 16:51 ` Thomas Monjalon
2018-01-24 6:43 ` Yuanhan Liu
2018-01-24 8:19 ` Thomas Monjalon
2018-01-24 9:28 ` Yuanhan Liu
2018-01-24 10:21 ` Thomas Monjalon
2018-01-24 10:36 ` Yuanhan Liu
2018-01-24 10:37 ` Thomas Monjalon
2018-01-24 15:04 ` Yuanhan Liu
2018-01-24 16:57 ` Thomas Monjalon
2018-01-25 14:41 ` Yuanhan Liu
2018-01-25 14:58 ` Thomas Monjalon
2023-06-08 22:51 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180124152432.GX29540@yliu-mob \
--to=yliu@fridaylinux.org \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=gaetan.rivet@6wind.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.