All of lore.kernel.org
 help / color / mirror / Atom feed
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Shakeel Butt <shakeelb@google.com>
Cc: Amir Goldstein <amir73il@gmail.com>, Jan Kara <jack@suse.cz>,
	Yang Shi <yang.s@alibaba-inc.com>,
	Michal Hocko <mhocko@kernel.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	Linux MM <linux-mm@kvack.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] fs: fsnotify: account fsnotify metadata to kmemcg
Date: Thu, 25 Jan 2018 01:54:41 +0000	[thread overview]
Message-ID: <20180125015441.GS13338@ZenIV.linux.org.uk> (raw)
In-Reply-To: <CALvZod4PyqfaqgEswegF5uOjNwVwbY1C4ptJB0Ouvgchv2aVFg@mail.gmail.com>

On Wed, Jan 24, 2018 at 05:08:27PM -0800, Shakeel Butt wrote:
> First, let me apologize, I think I might have led the discussion in
> wrong direction by giving one wrong information. The current upstream
> kernel, from the syscall context, does not invoke oom-killer when a
> memcg hits its limit and fails to reclaim memory, instead ENOMEM is
> returned. The memcg oom-killer is only invoked on page faults. However
> in a separate effort I do plan to converge the behavior, long
> discussion at <https://patchwork.kernel.org/patch/9988063/>.

Correct me if I'm misinterpreting you, but your rationale in there
appears to be along the lines of "userland applications might not
be ready to handle -ENOMEM gracefully, so let's hit them with
kill -9 instead - that will be handled properly, 'cuz M4G1C!!1!!!!"

I must admit that I like the general feel of that idea; may I suggest,
as a modest improvement, appending "/usr/local/bin/self-LART\n"
to the end of $HOME/.bashrc as well?  Killing luser's processes is
a nice start, but you have to allow for local policies...

-- 
WWSimonDo?

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

WARNING: multiple messages have this Message-ID (diff)
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Shakeel Butt <shakeelb@google.com>
Cc: Amir Goldstein <amir73il@gmail.com>, Jan Kara <jack@suse.cz>,
	Yang Shi <yang.s@alibaba-inc.com>,
	Michal Hocko <mhocko@kernel.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	Linux MM <linux-mm@kvack.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] fs: fsnotify: account fsnotify metadata to kmemcg
Date: Thu, 25 Jan 2018 01:54:41 +0000	[thread overview]
Message-ID: <20180125015441.GS13338@ZenIV.linux.org.uk> (raw)
In-Reply-To: <CALvZod4PyqfaqgEswegF5uOjNwVwbY1C4ptJB0Ouvgchv2aVFg@mail.gmail.com>

On Wed, Jan 24, 2018 at 05:08:27PM -0800, Shakeel Butt wrote:
> First, let me apologize, I think I might have led the discussion in
> wrong direction by giving one wrong information. The current upstream
> kernel, from the syscall context, does not invoke oom-killer when a
> memcg hits its limit and fails to reclaim memory, instead ENOMEM is
> returned. The memcg oom-killer is only invoked on page faults. However
> in a separate effort I do plan to converge the behavior, long
> discussion at <https://patchwork.kernel.org/patch/9988063/>.

Correct me if I'm misinterpreting you, but your rationale in there
appears to be along the lines of "userland applications might not
be ready to handle -ENOMEM gracefully, so let's hit them with
kill -9 instead - that will be handled properly, 'cuz M4G1C!!1!!!!"

I must admit that I like the general feel of that idea; may I suggest,
as a modest improvement, appending "/usr/local/bin/self-LART\n"
to the end of $HOME/.bashrc as well?  Killing luser's processes is
a nice start, but you have to allow for local policies...

-- 
WWSimonDo?

  reply	other threads:[~2018-01-25  1:54 UTC|newest]

Thread overview: 75+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-27 18:22 [PATCH v2] fs: fsnotify: account fsnotify metadata to kmemcg Yang Shi
2017-10-27 18:22 ` Yang Shi
2017-10-27 18:22 ` Yang Shi
2017-10-28 14:19 ` Amir Goldstein
2017-10-28 14:19   ` Amir Goldstein
2017-10-29  2:39   ` Matthew Wilcox
2017-10-29  2:39     ` Matthew Wilcox
2017-10-30 12:43 ` Jan Kara
2017-10-30 12:43   ` Jan Kara
2017-10-30 16:39   ` Yang Shi
2017-10-30 16:39     ` Yang Shi
2017-10-31 10:12     ` Jan Kara
2017-10-31 10:12       ` Jan Kara
2017-10-31 16:44       ` Yang Shi
2017-10-31 16:44         ` Yang Shi
2017-11-01 15:15         ` Jan Kara
2017-11-01 15:15           ` Jan Kara
2017-11-09 13:54       ` Michal Hocko
2017-11-09 13:54         ` Michal Hocko
2017-11-13 19:10         ` Yang Shi
2017-11-13 19:10           ` Yang Shi
2017-11-14  9:39           ` Michal Hocko
2017-11-14  9:39             ` Michal Hocko
2017-11-14 17:32             ` Yang Shi
2017-11-14 17:32               ` Yang Shi
2017-11-15  9:31               ` Jan Kara
2017-11-15  9:31                 ` Jan Kara
2018-01-19 15:02                 ` Shakeel Butt
2018-01-19 15:02                   ` Shakeel Butt
2018-01-22 20:31                   ` Amir Goldstein
2018-01-22 20:31                     ` Amir Goldstein
2018-01-24 10:34                     ` Jan Kara
2018-01-24 10:34                       ` Jan Kara
2018-01-24 11:12                       ` Amir Goldstein
2018-01-24 11:12                         ` Amir Goldstein
2018-01-25  1:08                         ` Shakeel Butt
2018-01-25  1:08                           ` Shakeel Butt
2018-01-25  1:54                           ` Al Viro [this message]
2018-01-25  1:54                             ` Al Viro
2018-01-25  2:15                             ` Shakeel Butt
2018-01-25  2:15                               ` Shakeel Butt
2018-01-25  7:51                           ` Amir Goldstein
2018-01-25  7:51                             ` Amir Goldstein
2018-01-25 20:20                             ` Shakeel Butt
2018-01-25 20:20                               ` Shakeel Butt
2018-01-25 20:36                               ` Amir Goldstein
2018-01-25 20:36                                 ` Amir Goldstein
     [not found]                                 ` <CAOQ4uxgJqn0CJaf=LMH-iv2g1MJZwPM97K6iCtzrcY3eoN6KjA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-02-13  6:30                                   ` Amir Goldstein
2018-02-13  6:30                                     ` Amir Goldstein
2018-02-13  6:30                                     ` Amir Goldstein
     [not found]                                     ` <CAOQ4uxjgKUFJ_uhyrQdcTs1FzcN6JrR_JpPc9QBrGJEU+cf65w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-02-13 21:10                                       ` Shakeel Butt
2018-02-13 21:10                                         ` Shakeel Butt
2018-02-13 21:10                                         ` Shakeel Butt
2018-02-13 21:54                                         ` Amir Goldstein
2018-02-13 21:54                                           ` Amir Goldstein
2018-02-13 22:20                                           ` Shakeel Butt
2018-02-13 22:20                                             ` Shakeel Butt
     [not found]                                             ` <CALvZod7FTNzoGfGnaorqjk4KEsxJFdz1pApHi04P1cF10ejxpQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-02-14  1:59                                               ` Shakeel Butt
2018-02-14  1:59                                                 ` Shakeel Butt
2018-02-14  1:59                                                 ` Shakeel Butt
2018-02-14  8:38                                                 ` Amir Goldstein
2018-02-14  8:38                                                   ` Amir Goldstein
2018-02-19 13:50                                                   ` Jan Kara
2018-02-19 13:50                                                     ` Jan Kara
2018-02-19 19:07                                                     ` Amir Goldstein
2018-02-19 19:07                                                       ` Amir Goldstein
2018-02-20 12:43                                                       ` Jan Kara
2018-02-20 12:43                                                         ` Jan Kara
2018-02-20 19:20                                                         ` Shakeel Butt
2018-02-20 19:20                                                           ` Shakeel Butt
2018-02-20 20:30                                                         ` Amir Goldstein
2018-02-20 20:30                                                           ` Amir Goldstein
2018-02-14  9:00                                               ` Amir Goldstein
2018-02-14  9:00                                                 ` Amir Goldstein
2018-02-14  9:00                                                 ` Amir Goldstein

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180125015441.GS13338@ZenIV.linux.org.uk \
    --to=viro@zeniv.linux.org.uk \
    --cc=amir73il@gmail.com \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    --cc=shakeelb@google.com \
    --cc=yang.s@alibaba-inc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.