All of lore.kernel.org
 help / color / mirror / Atom feed
From: linus.luessing@c0d3.blue (Linus Lüssing)
To: linus-amlogic@lists.infradead.org
Subject: [RFC PATCH v1] pinctrl: meson: meson8b: fix requesting GPIOs greater than GPIOZ_3
Date: Thu, 25 Jan 2018 05:03:31 +0100	[thread overview]
Message-ID: <20180125040331.GE1756@otheros> (raw)
In-Reply-To: <20180124002738.32338-1-martin.blumenstingl@googlemail.com>

On Wed, Jan 24, 2018 at 01:27:38AM +0100, Martin Blumenstingl wrote:
> Meson8b's AO GPIO controller is not affected by this issue since it does
> not have any holes in it - only the CBUS GPIO controller is affected.
> 
> This was initially seen by Linus L?ssing who was preparing SD card
> support on Odroid-C1 which uses CARD_6 as "card detect" GPIO.
> 
> Fixes: db80f0e158e621 ("pinctrl: meson: get rid of unneeded domain structures")
> Reported-by: Linus L?ssing <linus.luessing@c0d3.blue>
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>

Hi Martin,

Just wanted to confirm that this indeed fixes the splats and
crashes I was experiencing. And I was able to successfully
read/write from/to a microSD card. Also card detect worked fine, I
could successfully unplug, replug and then read from it again.
Here some dmesg from a successful card detection:

[  512.584687] mmcblk0: error -84 sending status command, retrying
[  512.586985] mmcblk0: timed out sending r/w cmd command, card status 0xd00
[  512.591756] mmcblk0: status not valid, retrying timeout
[  638.652986] mmc0: card 1234 removed
[  656.722455] mmc0: new high speed SDHC card at address 1234
[  656.724667] mmcblk0: mmc0:1234 SA16G 14.4 GiB 
[  656.730312]  mmcblk0: p1 p2

There error happened when typing "$ sync" after the write. However
the written file seemed fine in the end.

The address 1234 also seemed like a weird coincidence. But maybe
that's just a bug in my DT changes.

I'll post the DT changes I had been experimenting with as an RFC
to linux-amlogic shortly.

Regards, Linus

WARNING: multiple messages have this Message-ID (diff)
From: "Linus Lüssing" <linus.luessing@c0d3.blue>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: khilman@baylibre.com, linux-gpio@vger.kernel.org,
	linux-amlogic@lists.infradead.org, carlo@caione.org,
	jbrunet@baylibre.com, linus.walleij@linaro.org
Subject: Re: [RFC PATCH v1] pinctrl: meson: meson8b: fix requesting GPIOs greater than GPIOZ_3
Date: Thu, 25 Jan 2018 05:03:31 +0100	[thread overview]
Message-ID: <20180125040331.GE1756@otheros> (raw)
In-Reply-To: <20180124002738.32338-1-martin.blumenstingl@googlemail.com>

On Wed, Jan 24, 2018 at 01:27:38AM +0100, Martin Blumenstingl wrote:
> Meson8b's AO GPIO controller is not affected by this issue since it does
> not have any holes in it - only the CBUS GPIO controller is affected.
> 
> This was initially seen by Linus Lüssing who was preparing SD card
> support on Odroid-C1 which uses CARD_6 as "card detect" GPIO.
> 
> Fixes: db80f0e158e621 ("pinctrl: meson: get rid of unneeded domain structures")
> Reported-by: Linus Lüssing <linus.luessing@c0d3.blue>
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>

Hi Martin,

Just wanted to confirm that this indeed fixes the splats and
crashes I was experiencing. And I was able to successfully
read/write from/to a microSD card. Also card detect worked fine, I
could successfully unplug, replug and then read from it again.
Here some dmesg from a successful card detection:

[  512.584687] mmcblk0: error -84 sending status command, retrying
[  512.586985] mmcblk0: timed out sending r/w cmd command, card status 0xd00
[  512.591756] mmcblk0: status not valid, retrying timeout
[  638.652986] mmc0: card 1234 removed
[  656.722455] mmc0: new high speed SDHC card at address 1234
[  656.724667] mmcblk0: mmc0:1234 SA16G 14.4 GiB 
[  656.730312]  mmcblk0: p1 p2

There error happened when typing "$ sync" after the write. However
the written file seemed fine in the end.

The address 1234 also seemed like a weird coincidence. But maybe
that's just a bug in my DT changes.

I'll post the DT changes I had been experimenting with as an RFC
to linux-amlogic shortly.

Regards, Linus

  parent reply	other threads:[~2018-01-25  4:03 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-24  0:27 [RFC PATCH v1] pinctrl: meson: meson8b: fix requesting GPIOs greater than GPIOZ_3 Martin Blumenstingl
2018-01-24  0:27 ` Martin Blumenstingl
2018-01-24  8:28 ` Jerome Brunet
2018-01-24  8:28   ` Jerome Brunet
2018-01-24 10:10   ` Martin Blumenstingl
2018-01-24 10:10     ` Martin Blumenstingl
2018-01-24 14:52     ` Jerome Brunet
2018-01-24 14:52       ` Jerome Brunet
2018-01-24 17:54       ` Martin Blumenstingl
2018-01-24 17:54         ` Martin Blumenstingl
2018-02-17 19:44         ` Martin Blumenstingl
2018-02-17 19:44           ` Martin Blumenstingl
2018-02-19  8:07           ` Jerome Brunet
2018-02-19 21:19             ` Martin Blumenstingl
2018-01-25  4:03 ` Linus Lüssing [this message]
2018-01-25  4:03   ` Linus Lüssing

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180125040331.GE1756@otheros \
    --to=linus.luessing@c0d3.blue \
    --cc=linus-amlogic@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.