All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] ARM: dts: imx27-eukrea-mbimxsd27-baseboard: Pass missing unit address
@ 2017-12-27 16:23 Fabio Estevam
  2017-12-27 16:23 ` [PATCH 2/2] ARM: dts: imx27-eukrea-cpuimx27: Remove 'simple-bus' from clocks node Fabio Estevam
  2018-01-29  6:36 ` [PATCH 1/2] ARM: dts: imx27-eukrea-mbimxsd27-baseboard: Pass missing unit address Shawn Guo
  0 siblings, 2 replies; 4+ messages in thread
From: Fabio Estevam @ 2017-12-27 16:23 UTC (permalink / raw)
  To: linux-arm-kernel

From: Fabio Estevam <fabio.estevam@nxp.com>

ads7846 is connected to SPI chip select 0, so pass the unit address
accordingly to fix the following build warning with W=1:

arch/arm/boot/dts/imx27-eukrea-mbimxsd27-baseboard.dtb: Warning (unit_address_vs_reg): Node /soc/aipi at 10000000/cspi at 1000e000/ads7846 has a reg or ranges property, but no unit name

Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
 arch/arm/boot/dts/imx27-eukrea-mbimxsd27-baseboard.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/imx27-eukrea-mbimxsd27-baseboard.dts b/arch/arm/boot/dts/imx27-eukrea-mbimxsd27-baseboard.dts
index f565357..15145e7 100644
--- a/arch/arm/boot/dts/imx27-eukrea-mbimxsd27-baseboard.dts
+++ b/arch/arm/boot/dts/imx27-eukrea-mbimxsd27-baseboard.dts
@@ -84,7 +84,7 @@
 	cs-gpios = <&gpio4 28 GPIO_ACTIVE_LOW>;
 	status = "okay";
 
-	ads7846 {
+	ads7846 at 0 {
 		compatible = "ti,ads7846";
 		pinctrl-names = "default";
 		pinctrl-0 = <&pinctrl_touch>;
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 2/2] ARM: dts: imx27-eukrea-cpuimx27: Remove 'simple-bus' from clocks node
  2017-12-27 16:23 [PATCH 1/2] ARM: dts: imx27-eukrea-mbimxsd27-baseboard: Pass missing unit address Fabio Estevam
@ 2017-12-27 16:23 ` Fabio Estevam
  2018-01-29  6:36   ` Shawn Guo
  2018-01-29  6:36 ` [PATCH 1/2] ARM: dts: imx27-eukrea-mbimxsd27-baseboard: Pass missing unit address Shawn Guo
  1 sibling, 1 reply; 4+ messages in thread
From: Fabio Estevam @ 2017-12-27 16:23 UTC (permalink / raw)
  To: linux-arm-kernel

From: Fabio Estevam <fabio.estevam@nxp.com>

clock node should not have a 'simple-bus' compatible string, so remove it
in order to fix the following build warning with W=1:

arch/arm/boot/dts/imx27-eukrea-mbimxsd27-baseboard.dtb: Warning (simple_bus_reg): Node /clocks/osc26m missing or empty reg/ranges property

Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
 arch/arm/boot/dts/imx27-eukrea-cpuimx27.dtsi | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm/boot/dts/imx27-eukrea-cpuimx27.dtsi b/arch/arm/boot/dts/imx27-eukrea-cpuimx27.dtsi
index 2cf896c..7c75147 100644
--- a/arch/arm/boot/dts/imx27-eukrea-cpuimx27.dtsi
+++ b/arch/arm/boot/dts/imx27-eukrea-cpuimx27.dtsi
@@ -23,7 +23,6 @@
 	clocks {
 		#address-cells = <1>;
 		#size-cells = <0>;
-		compatible = "simple-bus";
 
 		clk14745600: clock at 0 {
 			#clock-cells = <0>;
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 2/2] ARM: dts: imx27-eukrea-cpuimx27: Remove 'simple-bus' from clocks node
  2017-12-27 16:23 ` [PATCH 2/2] ARM: dts: imx27-eukrea-cpuimx27: Remove 'simple-bus' from clocks node Fabio Estevam
@ 2018-01-29  6:36   ` Shawn Guo
  0 siblings, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2018-01-29  6:36 UTC (permalink / raw)
  To: linux-arm-kernel

On Wed, Dec 27, 2017 at 02:23:24PM -0200, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
> 
> clock node should not have a 'simple-bus' compatible string, so remove it
> in order to fix the following build warning with W=1:
> 
> arch/arm/boot/dts/imx27-eukrea-mbimxsd27-baseboard.dtb: Warning (simple_bus_reg): Node /clocks/osc26m missing or empty reg/ranges property
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
>  arch/arm/boot/dts/imx27-eukrea-cpuimx27.dtsi | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/imx27-eukrea-cpuimx27.dtsi b/arch/arm/boot/dts/imx27-eukrea-cpuimx27.dtsi
> index 2cf896c..7c75147 100644
> --- a/arch/arm/boot/dts/imx27-eukrea-cpuimx27.dtsi
> +++ b/arch/arm/boot/dts/imx27-eukrea-cpuimx27.dtsi
> @@ -23,7 +23,6 @@
>  	clocks {
>  		#address-cells = <1>;
>  		#size-cells = <0>;
> -		compatible = "simple-bus";
>  
>  		clk14745600: clock at 0 {
>  			#clock-cells = <0>;

We should probably fix it in another way - put the node directly under
root with a unique node name and drop unit-address.

Shawn

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 1/2] ARM: dts: imx27-eukrea-mbimxsd27-baseboard: Pass missing unit address
  2017-12-27 16:23 [PATCH 1/2] ARM: dts: imx27-eukrea-mbimxsd27-baseboard: Pass missing unit address Fabio Estevam
  2017-12-27 16:23 ` [PATCH 2/2] ARM: dts: imx27-eukrea-cpuimx27: Remove 'simple-bus' from clocks node Fabio Estevam
@ 2018-01-29  6:36 ` Shawn Guo
  1 sibling, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2018-01-29  6:36 UTC (permalink / raw)
  To: linux-arm-kernel

On Wed, Dec 27, 2017 at 02:23:23PM -0200, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
> 
> ads7846 is connected to SPI chip select 0, so pass the unit address
> accordingly to fix the following build warning with W=1:
> 
> arch/arm/boot/dts/imx27-eukrea-mbimxsd27-baseboard.dtb: Warning (unit_address_vs_reg): Node /soc/aipi at 10000000/cspi at 1000e000/ads7846 has a reg or ranges property, but no unit name
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>

Applied, thanks.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-01-29  6:36 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-27 16:23 [PATCH 1/2] ARM: dts: imx27-eukrea-mbimxsd27-baseboard: Pass missing unit address Fabio Estevam
2017-12-27 16:23 ` [PATCH 2/2] ARM: dts: imx27-eukrea-cpuimx27: Remove 'simple-bus' from clocks node Fabio Estevam
2018-01-29  6:36   ` Shawn Guo
2018-01-29  6:36 ` [PATCH 1/2] ARM: dts: imx27-eukrea-mbimxsd27-baseboard: Pass missing unit address Shawn Guo

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.