From: LABBE Corentin <clabbe@baylibre.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
devel@driverdev.osuosl.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: Re: [PATCH] staging: media: atomisp2: remove unused headers
Date: Mon, 29 Jan 2018 14:30:14 +0100 [thread overview]
Message-ID: <20180129133014.GB32503@Red> (raw)
In-Reply-To: <CAHp75Vd_xmPvejjn71khk_-XcZQf=i2f0Xgn4Njq+bkju11_xg@mail.gmail.com>
On Mon, Jan 29, 2018 at 03:22:33PM +0200, Andy Shevchenko wrote:
> On Mon, Jan 29, 2018 at 3:11 PM, Corentin Labbe <clabbe@baylibre.com> wrote:
> > All thoses headers are not used by any source files.
> > Lets just remove them.
>
> How did you test this?
>
> P.S. I like the patch, but since driver in a state of coma vigil, I'm
> afraid you may do something which shouldn't be done for working
> driver.
>
For testing I have:
- successfully compiling the driver
- for each file, grepping its name in tree to be sure that no one uses it.
WARNING: multiple messages have this Message-ID (diff)
From: LABBE Corentin <clabbe@baylibre.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: devel@driverdev.osuosl.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: Re: [PATCH] staging: media: atomisp2: remove unused headers
Date: Mon, 29 Jan 2018 14:30:14 +0100 [thread overview]
Message-ID: <20180129133014.GB32503@Red> (raw)
In-Reply-To: <CAHp75Vd_xmPvejjn71khk_-XcZQf=i2f0Xgn4Njq+bkju11_xg@mail.gmail.com>
On Mon, Jan 29, 2018 at 03:22:33PM +0200, Andy Shevchenko wrote:
> On Mon, Jan 29, 2018 at 3:11 PM, Corentin Labbe <clabbe@baylibre.com> wrote:
> > All thoses headers are not used by any source files.
> > Lets just remove them.
>
> How did you test this?
>
> P.S. I like the patch, but since driver in a state of coma vigil, I'm
> afraid you may do something which shouldn't be done for working
> driver.
>
For testing I have:
- successfully compiling the driver
- for each file, grepping its name in tree to be sure that no one uses it.
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2018-01-29 13:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-29 13:11 [PATCH] staging: media: atomisp2: remove unused headers Corentin Labbe
2018-01-29 13:11 ` Corentin Labbe
2018-01-29 13:22 ` Andy Shevchenko
2018-01-29 13:30 ` LABBE Corentin [this message]
2018-01-29 13:30 ` LABBE Corentin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180129133014.GB32503@Red \
--to=clabbe@baylibre.com \
--cc=andy.shevchenko@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.