From: LABBE Corentin <clabbe-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
To: Jason Gunthorpe <jgg-uk2M96/98Pc@public.gmane.org>
Cc: Joe Perches <joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>,
dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
swise-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] IB/cxgb3: remove cxio_dbg.c
Date: Tue, 30 Jan 2018 09:23:14 +0100 [thread overview]
Message-ID: <20180130082314.GA12047@Red> (raw)
In-Reply-To: <20180128210903.GL23869-uk2M96/98Pc@public.gmane.org>
On Sun, Jan 28, 2018 at 02:09:03PM -0700, Jason Gunthorpe wrote:
> On Sun, Jan 28, 2018 at 08:24:22AM -0800, Joe Perches wrote:
> > On Sun, 2018-01-28 at 15:11 +0000, Corentin Labbe wrote:
> > > cxio_dbg.c is uncompiled since commit 2b540355cd2f ("RDMA/cxgb3: cleanups")
> > > 10 years after, we could remove it.
> >
> > OK, now you could remove the prototypes and probably
> > CONFIG_INFINIBAND_CXGB3_DEBUG too.
> >
> > There is a DEBUG test and many uses of pr_debug
> > that would have modified behavior.
> >
> > The pr_debug uses would only be emitted via a
> > dynamic_debug enable and the #ifdef DEBUG is
> > probably not necessary or useful as it guards
> > a BUG_ON.
> >
> > drivers/infiniband/hw/cxgb3/Kconfig | 9 ---------
> > drivers/infiniband/hw/cxgb3/Makefile | 2 --
> > drivers/infiniband/hw/cxgb3/cxio_hal.h | 9 ---------
> > drivers/infiniband/hw/cxgb3/iwch_cq.c | 7 -------
> > 4 files changed, 27 deletions(-)
>
> Yes, can you resend the patch with Joe's hunks as well?
>
Yes I will do
Regards
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: LABBE Corentin <clabbe@baylibre.com>
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: Joe Perches <joe@perches.com>,
dledford@redhat.com, hal.rosenstock@gmail.com,
sean.hefty@intel.com, swise@chelsio.com,
linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
Subject: Re: [PATCH] IB/cxgb3: remove cxio_dbg.c
Date: Tue, 30 Jan 2018 09:23:14 +0100 [thread overview]
Message-ID: <20180130082314.GA12047@Red> (raw)
In-Reply-To: <20180128210903.GL23869@ziepe.ca>
On Sun, Jan 28, 2018 at 02:09:03PM -0700, Jason Gunthorpe wrote:
> On Sun, Jan 28, 2018 at 08:24:22AM -0800, Joe Perches wrote:
> > On Sun, 2018-01-28 at 15:11 +0000, Corentin Labbe wrote:
> > > cxio_dbg.c is uncompiled since commit 2b540355cd2f ("RDMA/cxgb3: cleanups")
> > > 10 years after, we could remove it.
> >
> > OK, now you could remove the prototypes and probably
> > CONFIG_INFINIBAND_CXGB3_DEBUG too.
> >
> > There is a DEBUG test and many uses of pr_debug
> > that would have modified behavior.
> >
> > The pr_debug uses would only be emitted via a
> > dynamic_debug enable and the #ifdef DEBUG is
> > probably not necessary or useful as it guards
> > a BUG_ON.
> >
> > drivers/infiniband/hw/cxgb3/Kconfig | 9 ---------
> > drivers/infiniband/hw/cxgb3/Makefile | 2 --
> > drivers/infiniband/hw/cxgb3/cxio_hal.h | 9 ---------
> > drivers/infiniband/hw/cxgb3/iwch_cq.c | 7 -------
> > 4 files changed, 27 deletions(-)
>
> Yes, can you resend the patch with Joe's hunks as well?
>
Yes I will do
Regards
next prev parent reply other threads:[~2018-01-30 8:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-28 15:11 [PATCH] IB/cxgb3: remove cxio_dbg.c Corentin Labbe
2018-01-28 16:24 ` Joe Perches
[not found] ` <1517156662.765.10.camel-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2018-01-28 21:09 ` Jason Gunthorpe
2018-01-28 21:09 ` Jason Gunthorpe
[not found] ` <20180128210903.GL23869-uk2M96/98Pc@public.gmane.org>
2018-01-30 8:23 ` LABBE Corentin [this message]
2018-01-30 8:23 ` LABBE Corentin
[not found] ` <1517152289-25052-1-git-send-email-clabbe-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
2018-01-28 18:27 ` Steve Wise
2018-01-28 18:27 ` Steve Wise
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180130082314.GA12047@Red \
--to=clabbe-rdvid1duhrbwk0htik3j/w@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=jgg-uk2M96/98Pc@public.gmane.org \
--cc=joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=swise-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.