From: Vinod Koul <vinod.koul@intel.com>
To: "Yang, Shunyong" <shunyong.yang@hxt-semitech.com>
Cc: "dan.j.williams@intel.com" <dan.j.williams@intel.com>,
"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: [1/2] dmaengine: dmatest: change symbolic permissions to octal values
Date: Tue, 30 Jan 2018 15:34:45 +0530 [thread overview]
Message-ID: <20180130100444.GU18649@localhost> (raw)
On Mon, Jan 29, 2018 at 06:26:40AM +0000, Yang, Shunyong wrote:
> Hi, Vinod
>
> On Mon, 2018-01-29 at 10:18 +0530, Vinod Koul wrote:
> > On Mon, Jan 22, 2018 at 06:44:40PM +0800, Yang Shunyong wrote:
> > >
> > > Current coding style prefers octal permissions values. This patch
> > > changes symbolic permissions to octal values.
> > Is this preference documented anywhere?
> >
>
> When using symbolic permissions like "S_IRUGO | S_IWUSR". The
> checkpatch.pl will output some warnings to suggest to use octal values.
> I quote following lines from checkpatch.pl,
>
> # check for uses of S_<PERMS> that could be octal for readability
> ...
> if (WARN("SYMBOLIC_PERMS",
> "Symbolic permissions '$oval' are not
> preferred. Consider using octal permissions '$octal'.\n" . $herecurr)
> &&
It is a warning and a preference. And I don't prefer changing code for no
benefit. Sorry but I am not considering this change
WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vinod.koul@intel.com>
To: "Yang, Shunyong" <shunyong.yang@hxt-semitech.com>
Cc: "dan.j.williams@intel.com" <dan.j.williams@intel.com>,
"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: Re: [PATCH 1/2] dmaengine: dmatest: change symbolic permissions to octal values
Date: Tue, 30 Jan 2018 15:34:45 +0530 [thread overview]
Message-ID: <20180130100444.GU18649@localhost> (raw)
In-Reply-To: <1517207190.2845.6.camel@hxt-semitech.com>
On Mon, Jan 29, 2018 at 06:26:40AM +0000, Yang, Shunyong wrote:
> Hi, Vinod
>
> On Mon, 2018-01-29 at 10:18 +0530, Vinod Koul wrote:
> > On Mon, Jan 22, 2018 at 06:44:40PM +0800, Yang Shunyong wrote:
> > >
> > > Current coding style prefers octal permissions values. This patch
> > > changes symbolic permissions to octal values.
> > Is this preference documented anywhere?
> >
>
> When using symbolic permissions like "S_IRUGO | S_IWUSR". The
> checkpatch.pl will output some warnings to suggest to use octal values.
> I quote following lines from checkpatch.pl,
>
> # check for uses of S_<PERMS> that could be octal for readability
> ...
> if (WARN("SYMBOLIC_PERMS",
> "Symbolic permissions '$oval' are not
> preferred. Consider using octal permissions '$octal'.\n" . $herecurr)
> &&
It is a warning and a preference. And I don't prefer changing code for no
benefit. Sorry but I am not considering this change
--
~Vinod
next reply other threads:[~2018-01-30 10:04 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-30 10:04 Vinod Koul [this message]
2018-01-30 10:04 ` Re: [PATCH 1/2] dmaengine: dmatest: change symbolic permissions to octal values Vinod Koul
-- strict thread matches above, loose matches on Subject: below --
2018-02-01 3:57 [1/2] " Joe Perches
2018-02-01 3:57 ` [PATCH 1/2] " Joe Perches
2018-02-01 3:46 [1/2] " Viresh Kumar
2018-02-01 3:46 ` [PATCH 1/2] " Viresh Kumar
2018-02-01 3:45 [1/2] " Vinod Koul
2018-02-01 3:45 ` [PATCH 1/2] " Vinod Koul
2018-01-31 10:01 [1/2] " Viresh Kumar
2018-01-31 10:01 ` [PATCH 1/2] " Viresh Kumar
2018-01-31 7:38 [2/2] dmaengine: dmatest: add norandom option Yang Shunyong
2018-01-31 7:38 ` Re: [PATCH 2/2] " Yang, Shunyong
2018-01-31 7:34 [2/2] " Vinod Koul
2018-01-31 7:34 ` [PATCH 2/2] " Vinod Koul
2018-01-29 6:26 [1/2] dmaengine: dmatest: change symbolic permissions to octal values Yang Shunyong
2018-01-29 6:26 ` Re: [PATCH 1/2] " Yang, Shunyong
2018-01-29 4:48 [1/2] " Vinod Koul
2018-01-29 4:48 ` [PATCH 1/2] " Vinod Koul
2018-01-22 10:44 [2/2] dmaengine: dmatest: add norandom option Yang Shunyong
2018-01-22 10:44 ` [PATCH 2/2] " Yang Shunyong
2018-01-22 10:44 [1/2] dmaengine: dmatest: change symbolic permissions to octal values Yang Shunyong
2018-01-22 10:44 ` [PATCH 1/2] " Yang Shunyong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180130100444.GU18649@localhost \
--to=vinod.koul@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shunyong.yang@hxt-semitech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.