From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Stefan Roese <sr@denx.de>
Cc: linux-pci@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [RFC PATCH] PCI: pciehp: Add module parameter to enable debouncing of HP link events
Date: Tue, 30 Jan 2018 12:28:40 +0200 [thread overview]
Message-ID: <20180130102840.GF27654@lahna.fi.intel.com> (raw)
In-Reply-To: <20180130084121.18653-1-sr@denx.de>
On Tue, Jan 30, 2018 at 09:41:21AM +0100, Stefan Roese wrote:
> Hotplugging of some PCIe devices on our platform sometimes leads to a
> bounce of link-up and link-down events, resulting in problems in the
> corresponding PCI drivers.
>
> Here an example of such a hotplug event bounce for a AHCI PCIe card:
> ...
> pciehp 0000:00:1c.1:pcie004: Slot(1): Card present
> pciehp 0000:00:1c.1:pcie004: Slot(1): Link Up
> pciehp 0000:00:1c.1:pcie004: Slot(1): Link Up event ignored; already powering on
> pciehp 0000:00:1c.1:pcie004: Slot(1): Link Down
> pciehp 0000:00:1c.1:pcie004: Slot(1): Card present
> pciehp 0000:00:1c.1:pcie004: Slot(1): Link Up
It would be good to find out why this happens in the first place.
Perhaps there is some environmental interference or something causing
this?
> pci 0000:02:00.0: [1b4b:9215] type 00 class 0x010601
> pci 0000:02:00.0: reg 0x10: [io 0x8000-0x8007]
> ...
> ata3: SATA max UDMA/133 abar m2048@0x80910000 port 0x80910100 irq 100
> ata4: SATA max UDMA/133 abar m2048@0x80910000 port 0x80910180 irq 100
> ata5: SATA max UDMA/133 abar m2048@0x80910000 port 0x80910200 irq 100
> ata6: SATA max UDMA/133 abar m2048@0x80910000 port 0x80910280 irq 100
> pciehp 0000:00:1c.1:pcie004: Slot(1): Link Up event ignored; already powering on
> ahci 0000:02:00.0: PME# disabled
> ata3: SATA link down (SStatus 0 SControl 300)
> ata5: SATA link down (SStatus 0 SControl 300)
> ata4: SATA link down (SStatus 0 SControl 300)
> WARNING: CPU: 2 PID: 1162 at drivers/ata/libata-core.c:6620 ata_host_detach+0x125/0x130
I think the AHCI driver should be fixed to cope with this.
> ata6: SATA link down (SStatus 0 SControl 300)
> Modules linked in:
> CPU: 2 PID: 1162 Comm: kworker/u8:5 Not tainted 4.15.0+ #26
> Hardware name: congatec conga-qeval20-qa3-e3845/conga-qeval20-qa3-e3845, BIOS 2018.01-00033-g0125f37185-dirty 01/18/2018
> Workqueue: pciehp-1 pciehp_power_thread
> ...
>
> This patch now adds the 'pciehp_debounce_time' module parameter, which
> can be used to drop all events for the specified time (in milliseconds)
> after a link-up event occurred. A value of ~100ms works fine in my tests
> to debounce all the link-up / link-down events in my tests.
This sounds a bit "hackish". I would rather make sure we can handle
situations like this properly without passing additional parameters.
next prev parent reply other threads:[~2018-01-30 10:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-30 8:41 [RFC PATCH] PCI: pciehp: Add module parameter to enable debouncing of HP link events Stefan Roese
2018-01-30 10:28 ` Mika Westerberg [this message]
2018-02-02 13:38 ` Stefan Roese
2018-02-02 13:47 ` Lukas Wunner
2018-02-02 14:44 ` Stefan Roese
2018-02-02 19:20 ` Bjorn Helgaas
2018-02-02 13:56 ` Mika Westerberg
2018-02-02 14:50 ` Stefan Roese
2018-02-02 15:11 ` Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180130102840.GF27654@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=linux-pci@vger.kernel.org \
--cc=sr@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.