From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Stefan Roese <sr@denx.de>
Cc: linux-pci@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [RFC PATCH] PCI: pciehp: Add module parameter to enable debouncing of HP link events
Date: Fri, 2 Feb 2018 17:11:00 +0200 [thread overview]
Message-ID: <20180202151100.GP27654@lahna.fi.intel.com> (raw)
In-Reply-To: <15ddf930-66e2-fae8-09c7-1d1ad7d5b07a@denx.de>
On Fri, Feb 02, 2018 at 03:50:55PM +0100, Stefan Roese wrote:
> I've already sent a patch regarding a libata problem while unplugging
> an AHCI controller:
>
> https://www.spinics.net/lists/linux-ide/msg55038.html
Great :)
> > BTW, have you checked whether presence detect actually toggles similarly
> > or is it only triggered when the link is fully up? Since currently we
> > prioritize link up/down higher than presence detect but it may be that
> > we should do the opposite.
>
> As seen in the log sent in my previous mail, presence detect also
> toggles. Here again:
>
> [ 41.260667] pciehp 0000:00:1c.1:pcie004: Slot(1): Card present
> [ 41.260731] pciehp 0000:00:1c.1:pcie004: Slot(1): Link Up
> [ 41.290650] pciehp 0000:00:1c.1:pcie004: Slot(1): Link Down
> [ 41.295837] pciehp 0000:00:1c.1:pcie004: Slot(1): Card present
> [ 41.320664] pciehp 0000:00:1c.1:pcie004: Slot(1): Card not present
> [ 41.330042] pciehp 0000:00:1c.1:pcie004: Slot(1): Card present
> [ 41.330110] pciehp 0000:00:1c.1:pcie004: Slot(1): Link Up
> [ 41.375950] pci 0000:02:00.0: [1b4b:9215] type 00 class 0x010601
> ...
Indeed, it seems to follow link status changes closely. So changing the
"priority" here would not help.
prev parent reply other threads:[~2018-02-02 15:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-30 8:41 [RFC PATCH] PCI: pciehp: Add module parameter to enable debouncing of HP link events Stefan Roese
2018-01-30 10:28 ` Mika Westerberg
2018-02-02 13:38 ` Stefan Roese
2018-02-02 13:47 ` Lukas Wunner
2018-02-02 14:44 ` Stefan Roese
2018-02-02 19:20 ` Bjorn Helgaas
2018-02-02 13:56 ` Mika Westerberg
2018-02-02 14:50 ` Stefan Roese
2018-02-02 15:11 ` Mika Westerberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180202151100.GP27654@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=linux-pci@vger.kernel.org \
--cc=sr@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.