All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Mohammed Gamal <mgamal@redhat.com>
Cc: otubo@redhat.com, sthemmin@microsoft.com, netdev@vger.kernel.org,
	haiyangz@microsoft.com, linux-kernel@vger.kernel.org,
	devel@linuxdriverproject.org, vkuznets@redhat.com
Subject: Re: [RFC PATCH 2/2] hv_netvsc: Change GPADL teardown order according to Hyper-V version
Date: Tue, 30 Jan 2018 11:30:41 -0800	[thread overview]
Message-ID: <20180130113041.43ce732f@xeon-e3> (raw)
In-Reply-To: <1516700045-32142-3-git-send-email-mgamal@redhat.com>

On Tue, 23 Jan 2018 10:34:05 +0100
Mohammed Gamal <mgamal@redhat.com> wrote:

> Commit 0cf737808ae7 ("hv_netvsc: netvsc_teardown_gpadl() split")
> introduced a regression causing VMs not to shutdown on pre-Wind2016
> hosts after netvsc_remove_device() is called. This was caused as the
> GPADL teardown sequence was changed.
> 
> This patch restores the old behavior for pre-Win2016 hosts, while
> keeping the changes from 0cf7378 for Win2016 and higher hosts.
> 
> Signed-off-by: Mohammed Gamal <mgamal@redhat.com>

Investigated the Windows driver to see how it handled this.
It uses NVSP version < 4 to check for older hosts. So that patch
should use that.

Currently testing a version with that change.
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

WARNING: multiple messages have this Message-ID (diff)
From: Stephen Hemminger <stephen@networkplumber.org>
To: Mohammed Gamal <mgamal@redhat.com>
Cc: otubo@redhat.com, sthemmin@microsoft.com, netdev@vger.kernel.org,
	haiyangz@microsoft.com, linux-kernel@vger.kernel.org,
	devel@linuxdriverproject.org, vkuznets@redhat.com
Subject: Re: [RFC PATCH 2/2] hv_netvsc: Change GPADL teardown order according to Hyper-V version
Date: Tue, 30 Jan 2018 11:30:41 -0800	[thread overview]
Message-ID: <20180130113041.43ce732f@xeon-e3> (raw)
In-Reply-To: <1516700045-32142-3-git-send-email-mgamal@redhat.com>

On Tue, 23 Jan 2018 10:34:05 +0100
Mohammed Gamal <mgamal@redhat.com> wrote:

> Commit 0cf737808ae7 ("hv_netvsc: netvsc_teardown_gpadl() split")
> introduced a regression causing VMs not to shutdown on pre-Wind2016
> hosts after netvsc_remove_device() is called. This was caused as the
> GPADL teardown sequence was changed.
> 
> This patch restores the old behavior for pre-Win2016 hosts, while
> keeping the changes from 0cf7378 for Win2016 and higher hosts.
> 
> Signed-off-by: Mohammed Gamal <mgamal@redhat.com>

Investigated the Windows driver to see how it handled this.
It uses NVSP version < 4 to check for older hosts. So that patch
should use that.

Currently testing a version with that change.

  reply	other threads:[~2018-01-30 19:30 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-23  9:34 [RFC PATCH 0/2] hv_netvsc: Fix shutdown regression on Win2012 hosts Mohammed Gamal
2018-01-23  9:34 ` Mohammed Gamal
2018-01-23  9:34 ` [RFC PATCH 1/2] hv_netvsc: Split netvsc_revoke_buf() and netvsc_teardown_gpadl() Mohammed Gamal
2018-01-23  9:34   ` Mohammed Gamal
2018-01-30 19:29   ` Stephen Hemminger
2018-01-30 19:29     ` Stephen Hemminger
2018-01-31 11:16     ` Mohammed Gamal
2018-01-31 11:16       ` Mohammed Gamal
2018-01-31 23:01       ` Stephen Hemminger
2018-01-31 23:01         ` Stephen Hemminger
2018-02-01  8:37         ` Mohammed Gamal
2018-02-01  8:37           ` Mohammed Gamal
2018-02-01 22:34           ` Mohammed Gamal
2018-02-01 22:38             ` Stephen Hemminger
2018-02-01 22:38               ` Stephen Hemminger
2018-01-23  9:34 ` [RFC PATCH 2/2] hv_netvsc: Change GPADL teardown order according to Hyper-V version Mohammed Gamal
2018-01-23  9:34   ` Mohammed Gamal
2018-01-30 19:30   ` Stephen Hemminger [this message]
2018-01-30 19:30     ` Stephen Hemminger
2018-01-23 15:43 ` [RFC PATCH 0/2] hv_netvsc: Fix shutdown regression on Win2012 hosts Haiyang Zhang
2018-01-23 15:43   ` Haiyang Zhang
2018-01-23 16:33 ` Stephen Hemminger
2018-01-23 16:33   ` Stephen Hemminger
2018-01-26 18:10 ` Stephen Hemminger
2018-01-26 18:10   ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180130113041.43ce732f@xeon-e3 \
    --to=stephen@networkplumber.org \
    --cc=devel@linuxdriverproject.org \
    --cc=haiyangz@microsoft.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgamal@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=otubo@redhat.com \
    --cc=sthemmin@microsoft.com \
    --cc=vkuznets@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.