From: Pavel Machek <pavel-+ZI9xUNit7I@public.gmane.org>
To: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: "Ladislav Michl" <ladis-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org>,
lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
perex-/Fr2/VpizcU@public.gmane.org,
tiwai-IBi9RG/b67k@public.gmane.org,
bhumirks-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
pali.rohar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
linux-arm-kernel
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org,
khilman-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
aaro.koskinen-X3B1VOXEql0@public.gmane.org,
ivo.g.dimitrov.75-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
patrikbachan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
serge-A9i7LUbDfNHQT0dZR+AlfA@public.gmane.org,
abcloriens-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
clayton-fehKsxFhGzZIf6P1QZMOBw@public.gmane.org,
martijn-28JJ9oSIdodmR6Xm/wNWPw@public.gmane.org,
sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org,
"Filip Matijević"
<filip.matijevic.pz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH] sound/tlv320dac33: Add device tree support
Date: Tue, 30 Jan 2018 13:28:29 +0100 [thread overview]
Message-ID: <20180130122829.GA10373@amd> (raw)
In-Reply-To: <20180130113238.GA10525-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1126 bytes --]
On Tue 2018-01-30 11:32:38, Mark Brown wrote:
> On Tue, Jan 30, 2018 at 09:53:14AM +0100, Pavel Machek wrote:
>
> > Well, notice I'm converting existing driver to device tree. And that
> > one already has GPIO dependency. It is possible that more work needs
> > to be done there, but that should not be a reason to delay this. Feel
> > free to help.
>
> No, it's a very good reason to delay merging something. A DT binding is
> an ABI so we need to sort out interface issues and describe things as
> well as we can, with board files it's not an ABI so we can just do any
> old thing that happens to work and while it might not be ideal it
> doesn't really matter since we can change it later if we need to.
Whatever.
Turns out this was GPIO after all.
I believe power-gpio and reset-gpio are equiavalent, with different
polarity. (After all, devices in reset consume less power).
If you prefer one solution over another, let me know...
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: pavel@ucw.cz (Pavel Machek)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] sound/tlv320dac33: Add device tree support
Date: Tue, 30 Jan 2018 13:28:29 +0100 [thread overview]
Message-ID: <20180130122829.GA10373@amd> (raw)
In-Reply-To: <20180130113238.GA10525@sirena.org.uk>
On Tue 2018-01-30 11:32:38, Mark Brown wrote:
> On Tue, Jan 30, 2018 at 09:53:14AM +0100, Pavel Machek wrote:
>
> > Well, notice I'm converting existing driver to device tree. And that
> > one already has GPIO dependency. It is possible that more work needs
> > to be done there, but that should not be a reason to delay this. Feel
> > free to help.
>
> No, it's a very good reason to delay merging something. A DT binding is
> an ABI so we need to sort out interface issues and describe things as
> well as we can, with board files it's not an ABI so we can just do any
> old thing that happens to work and while it might not be ideal it
> doesn't really matter since we can change it later if we need to.
Whatever.
Turns out this was GPIO after all.
I believe power-gpio and reset-gpio are equiavalent, with different
polarity. (After all, devices in reset consume less power).
If you prefer one solution over another, let me know...
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180130/df26b399/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Pavel Machek <pavel@ucw.cz>
To: Mark Brown <broonie@kernel.org>
Cc: "Ladislav Michl" <ladis@linux-mips.org>,
lgirdwood@gmail.com, robh+dt@kernel.org, mark.rutland@arm.com,
perex@perex.cz, tiwai@suse.com, bhumirks@gmail.com,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, pali.rohar@gmail.com,
sre@kernel.org,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-omap@vger.kernel.org, tony@atomide.com, khilman@kernel.org,
aaro.koskinen@iki.fi, ivo.g.dimitrov.75@gmail.com,
patrikbachan@gmail.com, serge@hallyn.com, abcloriens@gmail.com,
clayton@craftyguy.net, martijn@brixit.nl,
sakari.ailus@linux.intel.com,
"Filip Matijević" <filip.matijevic.pz@gmail.com>
Subject: Re: [PATCH] sound/tlv320dac33: Add device tree support
Date: Tue, 30 Jan 2018 13:28:29 +0100 [thread overview]
Message-ID: <20180130122829.GA10373@amd> (raw)
In-Reply-To: <20180130113238.GA10525@sirena.org.uk>
[-- Attachment #1: Type: text/plain, Size: 1126 bytes --]
On Tue 2018-01-30 11:32:38, Mark Brown wrote:
> On Tue, Jan 30, 2018 at 09:53:14AM +0100, Pavel Machek wrote:
>
> > Well, notice I'm converting existing driver to device tree. And that
> > one already has GPIO dependency. It is possible that more work needs
> > to be done there, but that should not be a reason to delay this. Feel
> > free to help.
>
> No, it's a very good reason to delay merging something. A DT binding is
> an ABI so we need to sort out interface issues and describe things as
> well as we can, with board files it's not an ABI so we can just do any
> old thing that happens to work and while it might not be ideal it
> doesn't really matter since we can change it later if we need to.
Whatever.
Turns out this was GPIO after all.
I believe power-gpio and reset-gpio are equiavalent, with different
polarity. (After all, devices in reset consume less power).
If you prefer one solution over another, let me know...
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2018-01-30 12:28 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-29 23:05 [PATCH] sound/tlv320dac33: Add device tree support Pavel Machek
2018-01-29 23:05 ` Pavel Machek
2018-01-29 23:20 ` Ladislav Michl
2018-01-29 23:20 ` Ladislav Michl
2018-01-29 23:20 ` Ladislav Michl
2018-01-29 23:33 ` Pavel Machek
2018-01-29 23:33 ` Pavel Machek
2018-01-30 8:34 ` Ladislav Michl
2018-01-30 8:34 ` Ladislav Michl
2018-01-30 8:53 ` Pavel Machek
2018-01-30 8:53 ` Pavel Machek
2018-01-30 8:53 ` Pavel Machek
2018-01-30 9:11 ` Filip Matijević
2018-01-30 9:11 ` Filip Matijević
[not found] ` <1141b126-b883-a246-85ad-c5a69acb90bb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-01-30 9:38 ` Ladislav Michl
2018-01-30 9:38 ` Ladislav Michl
2018-01-30 9:38 ` Ladislav Michl
2018-01-30 10:00 ` Pavel Machek
2018-01-30 10:00 ` Pavel Machek
2018-01-30 10:00 ` Pavel Machek
2018-01-30 10:10 ` Ladislav Michl
2018-01-30 10:10 ` Ladislav Michl
2018-01-30 10:35 ` Pavel Machek
2018-01-30 10:35 ` Pavel Machek
2018-01-30 10:35 ` Pavel Machek
2018-01-30 11:38 ` Ladislav Michl
2018-01-30 11:38 ` Ladislav Michl
2018-01-30 11:38 ` Ladislav Michl
2018-01-31 9:24 ` Peter Ujfalusi
2018-01-31 9:24 ` [alsa-devel] " Peter Ujfalusi
2018-01-31 9:24 ` Peter Ujfalusi
2018-01-30 11:32 ` Mark Brown
2018-01-30 11:32 ` Mark Brown
2018-01-30 11:32 ` Mark Brown
[not found] ` <20180130113238.GA10525-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2018-01-30 12:28 ` Pavel Machek [this message]
2018-01-30 12:28 ` Pavel Machek
2018-01-30 12:28 ` Pavel Machek
2018-01-31 9:12 ` Peter Ujfalusi
2018-01-31 9:12 ` [alsa-devel] " Peter Ujfalusi
2018-01-31 9:12 ` Peter Ujfalusi
2018-01-31 19:01 ` [PATCHv2] tlv320dac33: Add device tree bindings Pavel Machek
2018-01-31 19:01 ` Pavel Machek
2018-02-01 7:39 ` Peter Ujfalusi
2018-02-01 7:39 ` Peter Ujfalusi
2018-02-05 8:24 ` [PATCHv3] " Pavel Machek
2018-02-05 8:24 ` Pavel Machek
2018-02-05 8:24 ` Pavel Machek
2018-02-06 12:11 ` Mark Brown
2018-02-06 12:11 ` Mark Brown
2018-02-06 12:11 ` Mark Brown
[not found] ` <20180206121122.GG5681-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2018-02-06 13:49 ` Pavel Machek
2018-02-06 13:49 ` Pavel Machek
2018-02-06 13:49 ` Pavel Machek
2018-02-06 15:27 ` Mark Brown
2018-02-06 15:27 ` Mark Brown
2018-02-06 15:27 ` Mark Brown
2018-02-24 20:57 ` Pavel Machek
2018-02-24 20:57 ` Pavel Machek
2018-02-24 20:57 ` Pavel Machek
2018-03-05 12:52 ` Peter Ujfalusi
2018-03-05 12:52 ` Peter Ujfalusi
2018-03-05 12:52 ` Peter Ujfalusi
2018-02-09 2:25 ` Rob Herring
2018-02-09 2:25 ` Rob Herring
2018-02-09 2:25 ` Rob Herring
2018-02-05 6:08 ` [PATCHv2] " Rob Herring
2018-02-05 6:08 ` Rob Herring
2018-02-05 6:08 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180130122829.GA10373@amd \
--to=pavel-+zi9xunit7i@public.gmane.org \
--cc=aaro.koskinen-X3B1VOXEql0@public.gmane.org \
--cc=abcloriens-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org \
--cc=bhumirks-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=clayton-fehKsxFhGzZIf6P1QZMOBw@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=filip.matijevic.pz-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=ivo.g.dimitrov.75-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=khilman-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=ladis-6z/3iImG2C8G8FEW9MqTrA@public.gmane.org \
--cc=lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=martijn-28JJ9oSIdodmR6Xm/wNWPw@public.gmane.org \
--cc=pali.rohar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=patrikbachan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=perex-/Fr2/VpizcU@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
--cc=serge-A9i7LUbDfNHQT0dZR+AlfA@public.gmane.org \
--cc=sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=tiwai-IBi9RG/b67k@public.gmane.org \
--cc=tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.