[PATCH] xfs: remove experimental tag for reverse mapping

[PATCH] xfs: remove experimental tag for reverse mapping

[Darrick J. Wong]

From: Darrick J. Wong <darrick.wong@oracle.com>

Reverse mapping has had a while to soak, so remove the experimental tag.
Now that we've landed space metadata cross-referencing in scrub, the
feature actually has a purpose.

Reject rmap filesystems with an rt device until the code to support it
is actually implemented.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
 fs/xfs/xfs_super.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
index f3e0001..f436eec 100644
--- a/fs/xfs/xfs_super.c
+++ b/fs/xfs/xfs_super.c
@@ -1684,12 +1684,10 @@ xfs_fs_fill_super(
 	if (xfs_sb_version_hasrmapbt(&mp->m_sb)) {
 		if (mp->m_sb.sb_rblocks) {
 			xfs_alert(mp,
-	"EXPERIMENTAL reverse mapping btree not compatible with realtime device!");
+	"reverse mapping btree not compatible with realtime device!");
 			error = -EINVAL;
 			goto out_filestream_unmount;
 		}
-		xfs_alert(mp,
-	"EXPERIMENTAL reverse mapping btree feature enabled. Use at your own risk!");
 	}
 
 	error = xfs_mountfs(mp);

Re: [PATCH] xfs: remove experimental tag for reverse mapping

[Bill O'Donnell]

On Wed, Jan 31, 2018 at 09:49:13AM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
> 
> Reverse mapping has had a while to soak, so remove the experimental tag.
> Now that we've landed space metadata cross-referencing in scrub, the
> feature actually has a purpose.
> 
> Reject rmap filesystems with an rt device until the code to support it
> is actually implemented.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>

Reviewed-by: Bill O'Donnell <billodo@redhat.com>

> ---
>  fs/xfs/xfs_super.c |    4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
> index f3e0001..f436eec 100644
> --- a/fs/xfs/xfs_super.c
> +++ b/fs/xfs/xfs_super.c
> @@ -1684,12 +1684,10 @@ xfs_fs_fill_super(
>  	if (xfs_sb_version_hasrmapbt(&mp->m_sb)) {
>  		if (mp->m_sb.sb_rblocks) {
>  			xfs_alert(mp,
> -	"EXPERIMENTAL reverse mapping btree not compatible with realtime device!");
> +	"reverse mapping btree not compatible with realtime device!");
>  			error = -EINVAL;
>  			goto out_filestream_unmount;
>  		}
> -		xfs_alert(mp,
> -	"EXPERIMENTAL reverse mapping btree feature enabled. Use at your own risk!");
>  	}
>  
>  	error = xfs_mountfs(mp);
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] xfs: remove experimental tag for reverse mapping

[Dave Chinner]

On Wed, Jan 31, 2018 at 09:49:13AM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
> 
> Reverse mapping has had a while to soak, so remove the experimental tag.
> Now that we've landed space metadata cross-referencing in scrub, the
> feature actually has a purpose.
> 
> Reject rmap filesystems with an rt device until the code to support it
> is actually implemented.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>

I've been using it for as long as I've been using reflink, and rmap
has posed less problems than reflink. So I think this is the right
time to remove the experimental flag.

Reviewed-by: Dave Chinner <dchinner@redhat.com>
-- 
Dave Chinner
david@fromorbit.com