From: Baoquan He <bhe@redhat.com>
To: Dave Hansen <dave.hansen@intel.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
akpm@linux-foundation.org, kirill.shutemov@linux.intel.com,
mhocko@suse.com, tglx@linutronix.de, douly.fnst@cn.fujitsu.com
Subject: Re: [PATCH 1/2] mm/sparsemem: Defer the ms->section_mem_map clearing a little later
Date: Thu, 1 Feb 2018 22:38:08 +0800 [thread overview]
Message-ID: <20180201143808.GE1770@localhost.localdomain> (raw)
In-Reply-To: <87acc80a-8a9a-5037-8efc-9bb64ddaaffb@intel.com>
On 02/01/18 at 06:15am, Dave Hansen wrote:
> On 01/31/2018 11:19 PM, Baoquan He wrote:
> > for_each_present_section_nr(0, pnum) {
> > + struct mem_section *ms;
> > + ms = __nr_to_section(pnum);
> > usemap = usemap_map[pnum];
> > - if (!usemap)
> > + if (!usemap) {
> > +#ifdef CONFIG_SPARSEMEM_ALLOC_MEM_MAP_TOGETHER
> > + ms->section_mem_map = 0;
> > +#endif
> > continue;
> > + }
> >
> > #ifdef CONFIG_SPARSEMEM_ALLOC_MEM_MAP_TOGETHER
> > map = map_map[pnum];
> > #else
> > map = sparse_early_mem_map_alloc(pnum);
> > #endif
> > - if (!map)
> > + if (!map) {
> > +#ifdef CONFIG_SPARSEMEM_ALLOC_MEM_MAP_TOGETHER
> > + ms->section_mem_map = 0;
> > +#endif
> > continue;
> > + }
>
> This is starting to look like code that only a mother could love. Can
> this be cleaned up a bit?
Sorry, will try. Just wonder why we don't need to clear
ms->section_mem_map when CONFIG_SPARSEMEM_ALLOC_MEM_MAP_TOGETHER is not
set. Will look into to find reason.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Baoquan He <bhe@redhat.com>
To: Dave Hansen <dave.hansen@intel.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
akpm@linux-foundation.org, kirill.shutemov@linux.intel.com,
mhocko@suse.com, tglx@linutronix.de, douly.fnst@cn.fujitsu.com
Subject: Re: [PATCH 1/2] mm/sparsemem: Defer the ms->section_mem_map clearing a little later
Date: Thu, 1 Feb 2018 22:38:08 +0800 [thread overview]
Message-ID: <20180201143808.GE1770@localhost.localdomain> (raw)
In-Reply-To: <87acc80a-8a9a-5037-8efc-9bb64ddaaffb@intel.com>
On 02/01/18 at 06:15am, Dave Hansen wrote:
> On 01/31/2018 11:19 PM, Baoquan He wrote:
> > for_each_present_section_nr(0, pnum) {
> > + struct mem_section *ms;
> > + ms = __nr_to_section(pnum);
> > usemap = usemap_map[pnum];
> > - if (!usemap)
> > + if (!usemap) {
> > +#ifdef CONFIG_SPARSEMEM_ALLOC_MEM_MAP_TOGETHER
> > + ms->section_mem_map = 0;
> > +#endif
> > continue;
> > + }
> >
> > #ifdef CONFIG_SPARSEMEM_ALLOC_MEM_MAP_TOGETHER
> > map = map_map[pnum];
> > #else
> > map = sparse_early_mem_map_alloc(pnum);
> > #endif
> > - if (!map)
> > + if (!map) {
> > +#ifdef CONFIG_SPARSEMEM_ALLOC_MEM_MAP_TOGETHER
> > + ms->section_mem_map = 0;
> > +#endif
> > continue;
> > + }
>
> This is starting to look like code that only a mother could love. Can
> this be cleaned up a bit?
Sorry, will try. Just wonder why we don't need to clear
ms->section_mem_map when CONFIG_SPARSEMEM_ALLOC_MEM_MAP_TOGETHER is not
set. Will look into to find reason.
next prev parent reply other threads:[~2018-02-01 14:38 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-01 7:19 [PATCH 0/2] Optimize the code of mem_map allocation in Baoquan He
2018-02-01 7:19 ` Baoquan He
2018-02-01 7:19 ` [PATCH 1/2] mm/sparsemem: Defer the ms->section_mem_map clearing a little later Baoquan He
2018-02-01 7:19 ` Baoquan He
2018-02-01 14:15 ` Dave Hansen
2018-02-01 14:15 ` Dave Hansen
2018-02-01 14:38 ` Baoquan He [this message]
2018-02-01 14:38 ` Baoquan He
2018-02-01 7:19 ` [PATCH 2/2] mm/sparse.c: Add nr_present_sections to change the mem_map allocation Baoquan He
2018-02-01 7:19 ` Baoquan He
2018-02-01 10:16 ` Kirill A. Shutemov
2018-02-01 10:16 ` Kirill A. Shutemov
2018-02-01 13:49 ` Dave Hansen
2018-02-01 13:49 ` Dave Hansen
2018-02-01 14:19 ` Baoquan He
2018-02-01 14:19 ` Baoquan He
2018-02-01 14:23 ` Dave Hansen
2018-02-01 14:23 ` Dave Hansen
2018-02-01 14:33 ` Baoquan He
2018-02-01 14:33 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180201143808.GE1770@localhost.localdomain \
--to=bhe@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dave.hansen@intel.com \
--cc=douly.fnst@cn.fujitsu.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.