Re: [Qemu-devel] [PATCH v2 1/2] s390x/tcg: wire up pci instructions

[Cornelia Huck <cohuck@redhat.com>]

On Thu, 1 Feb 2018 11:00:09 +0100
Pierre Morel <pmorel@linux.vnet.ibm.com> wrote:

> On 31/01/2018 19:17, Cornelia Huck wrote:
> > On s390x, pci support is implemented via a set of instructions
> > (no mmio). Unfortunately, none of them are documented in the
> > PoP; the code is based upon the existing implementation for KVM
> > and the Linux zpci driver.
> >
> > Signed-off-by: Cornelia Huck <cohuck@redhat.com>
> > ---
> >   target/s390x/helper.h      |   9 ++++
> >   target/s390x/insn-data.def |  15 +++++++
> >   target/s390x/misc_helper.c | 109 +++++++++++++++++++++++++++++++++++++++++++++
> >   target/s390x/translate.c   | 101 +++++++++++++++++++++++++++++++++++++++++
> >   4 files changed, 234 insertions(+)

> Hi,
> 
> I am not an expert for TCG but the patches are looking clean to me.
> 
> And since I also rapidly tested with multibus, virtio_pci_block, and all 
> went good so:
> 
> Reviewed-by: Pierre Morel <pmorel@linux.vnet.ibm.com>

Thanks!

Out of curiousity, do you have some scripts or instructions for testing
you can share?