Re: [Qemu-devel] [PATCH v2 1/2] s390x/tcg: wire up pci instructions

[Cornelia Huck <cohuck@redhat.com>]

On Wed, 31 Jan 2018 19:17:41 +0100
Cornelia Huck <cohuck@redhat.com> wrote:

> +void HELPER(sic)(CPUS390XState *env, uint64_t r1, uint64_t r3)
> +{
> +    int r;
> +
> +    qemu_mutex_lock_iothread();
> +    r = css_do_sic(env, r1 & 0xffff, (r3 >> 27) & 0x7);

Here, the arguments have to be swapped around...

> +    qemu_mutex_unlock_iothread();
> +    if (r) {
> +        s390_program_interrupt(env, PGM_OPERATION, 4, GETPC());

...and here we have to pass -r instead of PGM_OPERATION. (Thanks to
David for spotting those!)

> +    }
> +}

With that fixed (and rebased upon current s390-next, which contains
David's latest changes), I can also turn on ais for tcg (which means
pre-4.15 kernels can see pci devices as well.)