All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anatolij Gustschin <agust@denx.de>
To: linux-fpga@vger.kernel.org
Cc: Alan Tull <atull@kernel.org>, Moritz Fischer <mdf@kernel.org>,
	Joshua Clayton <stillcompiling@gmail.com>
Subject: [PATCH] fpga-manager: altera-ps-spi: preserve nCONFIG state
Date: Thu,  1 Feb 2018 23:20:04 +0100	[thread overview]
Message-ID: <20180201222004.15949-1-agust@denx.de> (raw)

If the driver module is loaded when FPGA is configured, the FPGA
is reset because nconfig is pulled low (low-active gpio inited
with GPIOD_OUT_HIGH activates the signal which means setting its
value to low). Init nconfig with GPIOD_OUT_LOW to prevent this.

Signed-off-by: Anatolij Gustschin <agust@denx.de>
---
 drivers/fpga/altera-ps-spi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/fpga/altera-ps-spi.c b/drivers/fpga/altera-ps-spi.c
index c593f33d8db9..6891933d072d 100644
--- a/drivers/fpga/altera-ps-spi.c
+++ b/drivers/fpga/altera-ps-spi.c
@@ -258,7 +258,7 @@ static int altera_ps_probe(struct spi_device *spi)
 	}
 
 	conf->spi = spi;
-	conf->config = devm_gpiod_get(&spi->dev, "nconfig", GPIOD_OUT_HIGH);
+	conf->config = devm_gpiod_get(&spi->dev, "nconfig", GPIOD_OUT_LOW);
 	if (IS_ERR(conf->config)) {
 		dev_err(&spi->dev, "Failed to get config gpio: %ld\n",
 			PTR_ERR(conf->config));
-- 
2.11.0

             reply	other threads:[~2018-02-01 22:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-01 22:20 Anatolij Gustschin [this message]
2018-02-12 16:02 ` [PATCH] fpga-manager: altera-ps-spi: preserve nCONFIG state Alan Tull
2018-02-14 23:05 ` Moritz Fischer
  -- strict thread matches above, loose matches on Subject: below --
2018-04-15 18:33 Moritz Fischer
2018-04-15 18:33 ` Moritz Fischer
2018-04-16  8:10 ` Greg KH
2018-04-16  8:34   ` Anatolij Gustschin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180201222004.15949-1-agust@denx.de \
    --to=agust@denx.de \
    --cc=atull@kernel.org \
    --cc=linux-fpga@vger.kernel.org \
    --cc=mdf@kernel.org \
    --cc=stillcompiling@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.