All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Moritz Fischer <mdf@kernel.org>
Cc: atull@kernel.org, linux-fpga@vger.kernel.org,
	linux-kernel@vger.kernel.org, Anatolij Gustschin <agust@denx.de>
Subject: Re: [PATCH] fpga-manager: altera-ps-spi: preserve nCONFIG state
Date: Mon, 16 Apr 2018 10:10:08 +0200	[thread overview]
Message-ID: <20180416081008.GA31469@kroah.com> (raw)
In-Reply-To: <20180415183308.31402-1-mdf@kernel.org>

On Sun, Apr 15, 2018 at 11:33:08AM -0700, Moritz Fischer wrote:
> From: Anatolij Gustschin <agust@denx.de>
> 
> If the driver module is loaded when FPGA is configured, the FPGA
> is reset because nconfig is pulled low (low-active gpio inited
> with GPIOD_OUT_HIGH activates the signal which means setting its
> value to low). Init nconfig with GPIOD_OUT_LOW to prevent this.
> 
> Signed-off-by: Anatolij Gustschin <agust@denx.de>
> Acked-by: Alan Tull <atull@kernel.org>
> Signed-off-by: Moritz Fischer <mdf@kernel.org>
> ---
> 
> Hi Greg,
> 
> as discussed. Can you please take this bugfix for 4.17?
> I rebased it against next.

Is it also needed in any older kernel versions?

thanks,

greg k-h

  reply	other threads:[~2018-04-16  8:10 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-15 18:33 [PATCH] fpga-manager: altera-ps-spi: preserve nCONFIG state Moritz Fischer
2018-04-15 18:33 ` Moritz Fischer
2018-04-16  8:10 ` Greg KH [this message]
2018-04-16  8:34   ` Anatolij Gustschin
  -- strict thread matches above, loose matches on Subject: below --
2018-02-01 22:20 Anatolij Gustschin
2018-02-12 16:02 ` Alan Tull
2018-02-14 23:05 ` Moritz Fischer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180416081008.GA31469@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=agust@denx.de \
    --cc=atull@kernel.org \
    --cc=linux-fpga@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mdf@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.