From: Jason Gunthorpe <jgg@ziepe.ca>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Doug Ledford <dledford@redhat.com>,
Leon Romanovsky <leonro@mellanox.com>,
Steve Wise <swise@opengridcomputing.com>,
Mark Bloch <markb@mellanox.com>,
linux-rdma@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] RDMA/nldev: missing error code in nldev_res_get_doit()
Date: Thu, 01 Feb 2018 22:50:15 +0000 [thread overview]
Message-ID: <20180201225015.GC8590@ziepe.ca> (raw)
In-Reply-To: <20180201100148.GA8959@mwanda>
On Thu, Feb 01, 2018 at 01:01:48PM +0300, Dan Carpenter wrote:
> We should return -ENOMEM if the allocation fails. The current code
> accidentally returns success.
>
> Fixes: bf3c5a93c523 ("RDMA/nldev: Provide global resource utilization")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
Applied to for-next, thanks
Jason
WARNING: multiple messages have this Message-ID (diff)
From: Jason Gunthorpe <jgg@ziepe.ca>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Doug Ledford <dledford@redhat.com>,
Leon Romanovsky <leonro@mellanox.com>,
Steve Wise <swise@opengridcomputing.com>,
Mark Bloch <markb@mellanox.com>,
linux-rdma@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] RDMA/nldev: missing error code in nldev_res_get_doit()
Date: Thu, 1 Feb 2018 15:50:15 -0700 [thread overview]
Message-ID: <20180201225015.GC8590@ziepe.ca> (raw)
In-Reply-To: <20180201100148.GA8959@mwanda>
On Thu, Feb 01, 2018 at 01:01:48PM +0300, Dan Carpenter wrote:
> We should return -ENOMEM if the allocation fails. The current code
> accidentally returns success.
>
> Fixes: bf3c5a93c523 ("RDMA/nldev: Provide global resource utilization")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
Applied to for-next, thanks
Jason
next prev parent reply other threads:[~2018-02-01 22:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-01 10:01 [PATCH] RDMA/nldev: missing error code in nldev_res_get_doit() Dan Carpenter
2018-02-01 10:01 ` Dan Carpenter
2018-02-01 10:34 ` Leon Romanovsky
2018-02-01 10:34 ` Leon Romanovsky
2018-02-01 22:50 ` Jason Gunthorpe [this message]
2018-02-01 22:50 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180201225015.GC8590@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=dan.carpenter@oracle.com \
--cc=dledford@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=leonro@mellanox.com \
--cc=linux-rdma@vger.kernel.org \
--cc=markb@mellanox.com \
--cc=swise@opengridcomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.